Skip to content

HBASE-25986 set default value of normalization enabled from hbase site - #3492

Merged
virajjasani merged 1 commit into
apache:branch-1from
mnpoonia:branch_1_HBASE_25986
Jul 19, 2021
Merged

HBASE-25986 set default value of normalization enabled from hbase site#3492
virajjasani merged 1 commit into
apache:branch-1from
mnpoonia:branch_1_HBASE_25986

Conversation

@mnpoonia

Copy link
Copy Markdown
Contributor

No description provided.

@mnpoonia
mnpooniaforce-pushed the branch_1_HBASE_25986 branch from a0eb31c to 687abe9CompareJuly 15, 2021 09:40
@virajjasani
virajjasani self-requested a review July 15, 2021 11:17
@virajjasanivirajjasani added the backport This PR is a back port of some issue or issues already committed to master label Jul 15, 2021
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec18m 3sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 28sMaven dependency ordering for branch
+1 💚mvninstall8m 16sbranch-1 passed
+1 💚compile1m 20sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 31sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle3m 9sbranch-1 passed
+0 🆗refguide4m 13sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚shadedjars3m 17sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 10sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 30sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs2m 58sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 35sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 1sthe patch passed
+1 💚compile1m 22sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 21sthe patch passed
+1 💚compile1m 31sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 31sthe patch passed
-1 ❌checkstyle0m 37shbase-client: The patch generated 1 new + 90 unchanged - 0 fixed = 91 total (was 90)
-1 ❌checkstyle1m 47shbase-server: The patch generated 2 new + 212 unchanged - 0 fixed = 214 total (was 212)
-1 ❌whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌xml0m 0sThe patch has 1 ill-formed XML file(s).
+0 🆗refguide3m 13spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚shadedjars3m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck4m 44sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc1m 10sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 29sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs6m 5sthe patch passed
_ Other Tests _
+1 💚unit2m 33shbase-common in the patch passed.
+1 💚unit2m 41shbase-client in the patch passed.
-1 ❌unit164m 57shbase-server in the patch failed.
+1 💚asflicense1m 6sThe patch does not generate ASF License warnings.
254m 8s
ReasonTests
XMLParsing Error(s):
hbase-common/src/main/resources/hbase-default.xml
Failed junit testshadoop.hbase.mapreduce.TestLoadIncrementalHFiles
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/2/artifact/out/Dockerfile
GITHUB PR#3492
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml
unameLinux 259c830042a6 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3492/out/precommit/personality/provided.sh
git revisionbranch-1 / edd6ea9
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/2/artifact/out/branch-site/book.html
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/2/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/2/artifact/out/diff-checkstyle-hbase-server.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/2/artifact/out/whitespace-eol.txt
xmlhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/2/artifact/out/xml.txt
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/2/artifact/out/patch-site/book.html
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/2/testReport/
Max. process+thread count4024 (vs. ulimit of 10000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/2/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani

Copy link
Copy Markdown
Contributor

Checkstyles and whitespace, once fixed, will merge all PRs of HBASE-25986 together.

@mnpoonia
mnpooniaforce-pushed the branch_1_HBASE_25986 branch from 687abe9 to e1b3de6CompareJuly 19, 2021 05:01
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 51sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 29sMaven dependency ordering for branch
+1 💚mvninstall8m 6sbranch-1 passed
+1 💚compile1m 20sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 34sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle2m 48sbranch-1 passed
+0 🆗refguide4m 5sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚shadedjars3m 2sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 13sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 30sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs2m 44sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 14sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall1m 53sthe patch passed
+1 💚compile1m 21sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 21sthe patch passed
+1 💚compile1m 33sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 33sthe patch passed
+1 💚checkstyle0m 29sThe patch passed checkstyle in hbase-common
+1 💚checkstyle0m 37shbase-client: The patch generated 0 new + 89 unchanged - 1 fixed = 89 total (was 90)
+1 💚checkstyle1m 34sThe patch passed checkstyle in hbase-server
-1 ❌whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌xml0m 1sThe patch has 1 ill-formed XML file(s).
+0 🆗refguide2m 57spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚shadedjars2m 53spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck4m 38sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc1m 10sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 30sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs5m 36sthe patch passed
_ Other Tests _
+1 💚unit2m 44shbase-common in the patch passed.
+1 💚unit2m 46shbase-client in the patch passed.
+1 💚unit139m 5shbase-server in the patch passed.
+1 💚asflicense1m 19sThe patch does not generate ASF License warnings.
214m 42s
ReasonTests
XMLParsing Error(s):
hbase-common/src/main/resources/hbase-default.xml
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/3/artifact/out/Dockerfile
GITHUB PR#3492
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml
unameLinux 55b1e8e8eb9e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3492/out/precommit/personality/provided.sh
git revisionbranch-1 / edd6ea9
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/3/artifact/out/branch-site/book.html
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/3/artifact/out/whitespace-eol.txt
xmlhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/3/artifact/out/xml.txt
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/3/artifact/out/patch-site/book.html
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/3/testReport/
Max. process+thread count4764 (vs. ulimit of 10000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3492/3/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani
virajjasani merged commit b2d329b into apache:branch-1Jul 19, 2021
@mnpoonia
mnpoonia deleted the branch_1_HBASE_25986 branch July 19, 2021 11:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mnpoonia@Apache-HBase@virajjasani