Skip to content

HBASE-26096 Cleanup the deprecated methods in HBTU related classes and format code - #3503

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-26096
Jul 29, 2021
Merged

HBASE-26096 Cleanup the deprecated methods in HBTU related classes and format code#3503
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-26096

Conversation

@Apache9

@Apache9Apache9 commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this Jul 19, 2021
@Apache-HBase

Apache-HBase commented Jul 19, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 58smaster passed
+1 💚compile5m 13smaster passed
+1 💚checkstyle1m 56smaster passed
+1 💚spotbugs3m 50smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 40sthe patch passed
+1 💚compile5m 9sthe patch passed
-0 ⚠️javac0m 30shbase-zookeeper generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
-0 ⚠️javac3m 11shbase-server generated 35 new + 158 unchanged - 35 fixed = 193 total (was 193)
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-zookeeper
-0 ⚠️checkstyle1m 3shbase-server: The patch generated 7 new + 80 unchanged - 87 fixed = 87 total (was 167)
+1 💚checkstyle0m 18shbase-mapreduce: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚checkstyle0m 17sThe patch passed checkstyle in hbase-it
-0 ⚠️whitespace0m 0sThe patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚hadoopcheck18m 7sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs4m 40sthe patch passed
_ Other Tests _
+1 💚asflicense0m 51sThe patch does not generate ASF License warnings.
59m 8s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3503
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 5cb1d3dda910 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 8bc2fc0
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/1/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-zookeeper hbase-server hbase-mapreduce hbase-it U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9Apache9 changed the title HBASE-26096 Cleanup the deprecated methods in HBTU related classesHBASE-26096 Cleanup the deprecated methods in HBTU related classes and format codeJul 19, 2021
@Apache-HBase

Apache-HBase commented Jul 20, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 53smaster passed
+1 💚compile5m 54smaster passed
+1 💚checkstyle2m 21smaster passed
+1 💚spotbugs4m 32smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 39sthe patch passed
+1 💚compile6m 0sthe patch passed
+1 💚javac0m 51shbase-common in the patch passed.
+1 💚javac0m 29shbase-zookeeper generated 0 new + 96 unchanged - 1 fixed = 96 total (was 97)
-0 ⚠️javac3m 11shbase-server generated 40 new + 153 unchanged - 40 fixed = 193 total (was 193)
+1 💚javac0m 47shbase-mapreduce in the patch passed.
+1 💚javac0m 42shbase-it in the patch passed.
+1 💚checkstyle0m 24sThe patch passed checkstyle in hbase-common
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-zookeeper
-0 ⚠️checkstyle1m 5shbase-server: The patch generated 1 new + 77 unchanged - 94 fixed = 78 total (was 171)
+1 💚checkstyle0m 18shbase-mapreduce: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚checkstyle0m 17sThe patch passed checkstyle in hbase-it
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck18m 8sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs5m 32sthe patch passed
_ Other Tests _
+1 💚asflicense1m 4sThe patch does not generate ASF License warnings.
64m 21s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3503
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 59e33627be65 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 8bc2fc0
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-common hbase-zookeeper hbase-server hbase-mapreduce hbase-it U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

nyl3532016
nyl3532016 approved these changes Jul 26, 2021
View reviewed changes

@nyl3532016nyl3532016 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache-HBase

Apache-HBase commented Jul 26, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall4m 47smaster passed
+1 💚compile7m 38smaster passed
+1 💚checkstyle2m 40smaster passed
+1 💚spotbugs5m 41smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall5m 7sthe patch passed
+1 💚compile7m 58sthe patch passed
+1 💚javac0m 58shbase-common in the patch passed.
+1 💚javac0m 34shbase-zookeeper generated 0 new + 96 unchanged - 1 fixed = 96 total (was 97)
-0 ⚠️javac4m 25shbase-server generated 40 new + 153 unchanged - 40 fixed = 193 total (was 193)
+1 💚javac1m 7shbase-mapreduce in the patch passed.
+1 💚javac0m 54shbase-it in the patch passed.
+1 💚checkstyle0m 28sThe patch passed checkstyle in hbase-common
+1 💚checkstyle0m 16sThe patch passed checkstyle in hbase-zookeeper
+1 💚checkstyle1m 23shbase-server: The patch generated 0 new + 77 unchanged - 94 fixed = 77 total (was 171)
+1 💚checkstyle0m 20shbase-mapreduce: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚checkstyle0m 18sThe patch passed checkstyle in hbase-it
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck26m 0sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs9m 0sthe patch passed
_ Other Tests _
+1 💚asflicense1m 17sThe patch does not generate ASF License warnings.
87m 27s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3503
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 3e3b38faeb97 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4a3c7d7
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-common hbase-zookeeper hbase-server hbase-mapreduce hbase-it U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Jul 27, 2021

Copy link
Copy Markdown
ContributorAuthor

It is a bit strange that once we use the builder instead of constructor of MiniDFSCluster, some tests will fail. Let me revert back to use constructor and open a separated issue to address it.

@Apache-HBase

Apache-HBase commented Jul 27, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 56sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall3m 41smaster passed
+1 💚compile5m 55smaster passed
+1 💚checkstyle2m 18smaster passed
+1 💚spotbugs4m 31smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 41sthe patch passed
+1 💚compile5m 52sthe patch passed
+1 💚javac0m 47shbase-common in the patch passed.
+1 💚javac0m 29shbase-zookeeper generated 0 new + 96 unchanged - 1 fixed = 96 total (was 97)
-0 ⚠️javac3m 8shbase-server generated 40 new + 153 unchanged - 40 fixed = 193 total (was 193)
+1 💚javac0m 46shbase-mapreduce in the patch passed.
+1 💚javac0m 42shbase-it in the patch passed.
+1 💚checkstyle0m 23sThe patch passed checkstyle in hbase-common
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-zookeeper
+1 💚checkstyle1m 2shbase-server: The patch generated 0 new + 77 unchanged - 94 fixed = 77 total (was 171)
+1 💚checkstyle0m 18shbase-mapreduce: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚checkstyle0m 17sThe patch passed checkstyle in hbase-it
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck18m 17sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs5m 29sthe patch passed
_ Other Tests _
+1 💚asflicense1m 2sThe patch does not generate ASF License warnings.
66m 58s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3503
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 4c07799b44c6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 02d263e
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-common hbase-zookeeper hbase-server hbase-mapreduce hbase-it U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 27, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 30sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 8sMaven dependency ordering for branch
+1 💚mvninstall3m 38smaster passed
+1 💚compile2m 39smaster passed
+1 💚shadedjars8m 21sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 51smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 42sthe patch passed
+1 💚compile2m 39sthe patch passed
+1 💚javac2m 39sthe patch passed
+1 💚shadedjars8m 17spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 50sthe patch passed
_ Other Tests _
+1 💚unit1m 39shbase-common in the patch passed.
+1 💚unit0m 44shbase-zookeeper in the patch passed.
+1 💚unit151m 25shbase-server in the patch passed.
+1 💚unit10m 57shbase-mapreduce in the patch passed.
+1 💚unit1m 16shbase-it in the patch passed.
209m 24s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3503
Optional Testsjavac javadoc unit shadedjars compile
unameLinux cc48b28fdb2d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 02d263e
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/testReport/
Max. process+thread count4676 (vs. ulimit of 30000)
modulesC: hbase-common hbase-zookeeper hbase-server hbase-mapreduce hbase-it U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 27, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec8m 31sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 33sMaven dependency ordering for branch
+1 💚mvninstall6m 32smaster passed
+1 💚compile3m 55smaster passed
+1 💚shadedjars10m 12sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 25smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall5m 52sthe patch passed
+1 💚compile4m 2sthe patch passed
+1 💚javac4m 2sthe patch passed
+1 💚shadedjars10m 15spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 25sthe patch passed
_ Other Tests _
+1 💚unit2m 44shbase-common in the patch passed.
+1 💚unit1m 1shbase-zookeeper in the patch passed.
+1 💚unit233m 58shbase-server in the patch passed.
+1 💚unit17m 26shbase-mapreduce in the patch passed.
+1 💚unit1m 21shbase-it in the patch passed.
314m 37s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3503
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6c996045a834 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 02d263e
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/testReport/
Max. process+thread count3308 (vs. ulimit of 30000)
modulesC: hbase-common hbase-zookeeper hbase-server hbase-mapreduce hbase-it U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 5f09505 into apache:masterJul 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunhellysunhellysunhelly approved these changes
@nyl3532016nyl3532016nyl3532016 approved these changes

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9@Apache-HBase@sunhelly@nyl3532016