Uh oh!
There was an error while loading. Please reload this page.
HBASE-25881: Create a chore to update age related metrics - #3518
Open
rahulLiving wants to merge 12 commits into
Open
HBASE-25881: Create a chore to update age related metrics#3518rahulLiving wants to merge 12 commits into
rahulLiving wants to merge 12 commits into
Conversation
Apache-HBase
commented
Jul 22, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2021
💔 -1 overall
This message was automatically generated. |
rahulLiving
commented
Jul 26, 2021
ContributorAuthor
Still have to look into test failure. @shahrs87@anoopsjohn wondering if you guys can have a look and provide feedback about the approach if any. Thanks |
Apache-HBase
commented
Jul 30, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 30, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 30, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 30, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 30, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 30, 2021
🎊 +1 overall
This message was automatically generated. |
rahulLiving
commented
Jul 31, 2021
ContributorAuthor
@virajjasani@apurtell@anoopsjohn Looking for review on this PR. Thanks |
virajjasani
self-requested a review
August 2, 2021 07:59
anoopsjohn
left a comment
Contributor
There was a problem hiding this comment.
Did u test it in a real write heavy replicating cluster setup? How the metric reporting ? Provided now we will update the metric in every 1 min (default). On write heavy, this may look slower?
| */ | ||
| @InterfaceAudience.Private | ||
| @InterfaceStability.Evolving | ||
| public class MetricsReplicationSourceRefresherChore extends ScheduledChore { |
Contributor
There was a problem hiding this comment.
ReplicationSourceMetricsRefresherChore a better name?
| */ | ||
| private long getOldestWalTimestamp() { | ||
| long oldestWalTimestamp = Long.MAX_VALUE; | ||
| for (Map.Entry<String, PriorityBlockingQueue<Path>> entry : this.replicationSource.getQueues() |
| private MetricsSource metrics; | ||
| public static final String DURATION = "hbase.metrics.replication.source.refresher.duration"; |
Contributor
There was a problem hiding this comment.
Here also..
better name would be hbase.replication.source.metrics.refresher.duration
Or even
hbase.replication.source.metrics.refresher.period ?
shahrs87
requested changes
Aug 3, 2021
shahrs87
left a comment
Contributor
There was a problem hiding this comment.
@rahulLiving Thank you for the patch. Added some comments.
| public class MetricsReplicationSourceRefresherChore extends ScheduledChore { | ||
| private ReplicationSource replicationSource; | ||
| this.abortOnError = this.conf.getBoolean("replication.source.regionserver.abort", | ||
| true); | ||
| int duration = this.conf.getInt(MetricsReplicationSourceRefresherChore.DURATION, |
Contributor
There was a problem hiding this comment.
Are we creating a chore for every replication source ? If we have 2-3 peers, this will create that many chores. Instead is it possible to create just 1 chore and initialize with ReplicationSourceManager which has list of all replicationSources and just iterate over them every time this chore wakes up. Thoughts ?
| /* | ||
| * Returns the age of oldest wal. | ||
| */ | ||
| long getOldestWalAge() { |
Contributor
There was a problem hiding this comment.
@rahulLiving There are many age related metrics in Replication subsytem. We want to update all the metrics from this Chore. I don't think it is a good idea to move the implementation from ReplicationSourceLogQueue to here.
What I had in my mind is: Compute oldestWalTimestamp (not the age, just the timestamp) in ReplicationSourceLogQueue and keep it as a class variable. Don't calculate the age there. Instead calculate the age in this chore. So for some reason if Replication thread is stuck, it will not update oldestWalTimestamp and since age is calculated in this chore, it will be updated. Does that make sense ?
| // Diff of current time (10) and log-walgroup-a.8 timestamp will be 2. | ||
| source.enqueueLog(log1); | ||
| // Sleep for chore to update WAL age | ||
| Thread.sleep(1000); |
Contributor
There was a problem hiding this comment.
Use Waiter.waitFor method to wait on some condition. That way if the jenkins machine are slow, it will not create flaky tests.
shahrs87
commented
Oct 19, 2021
Contributor
@rahulLiving Checking whether you are still interested in working on this patch ? If not, then I can carry forward the work that you have done until now. Thank you ! |
rahulLiving
commented
Oct 20, 2021
ContributorAuthor
Hi @shahrs87 , sorry about not being able to prioritise the above review comments. Unfortunately, won't be able to focus on this PR for current month at least. Please feel free to take it up if this has to be prioritised. Thanks |
Apache-HBase
commented
Jan 27, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 27, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 28, 2022
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.