Uh oh!
There was an error while loading. Please reload this page.
HBASE-25469 Add detailed RIT info in JSON format for consumption as metrics - #3535
Conversation
Apache-HBase
commented
Jul 27, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 28, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 28, 2021
🎊 +1 overall
This message was automatically generated. |
| @Override | ||
| protected void configureInfoServer() { | ||
| infoServer.addUnprivilegedServlet("master-status", "/master-status", MasterStatusServlet.class); | ||
| infoServer.addPrivilegedServlet("rits", "/rits", RitServlet.class); |
There was a problem hiding this comment.
Nit: Let's call it "/rit".
Not a big deal, but other paths are not in the plural form.
| } | ||
| if (rits.isEmpty()) { | ||
| out.write("There are currently no regions in transition."); |
There was a problem hiding this comment.
is it okay to return an empty map then?
bharathv
left a comment
There was a problem hiding this comment.
Is it not better to consolidate the code under rits.jsp?format=json ? It already supports text and html, think you just need to add another branch?
caroliney14
commented
Aug 2, 2021
@bharathv I considered consolidating, but mainly wrote it this way so that 1) the url isn't so complex, and 2) the code is not dependent on this page/the complex url (we can also attach the servlet elsewhere if we want). |
Apache-HBase
commented
Aug 2, 2021
🎊 +1 overall
This message was automatically generated. |
bharathv
commented
Aug 2, 2021
The problem is that the two places can now diverge. If someone is not familiar with the other page, they just update one of them. As an operator it is now confusing whether to use /rit or /rit.jsp or both or how they differ apart from the output type is not obvious. Is it difficult to clean up rit.jsp or move rit.jsp logic into /rit servlet (and add a redirect in branch-2) ? |
@bharathv there already are multiple places where RIT info can be found: the main |
caroliney14
commented
Aug 3, 2021
actually, I think it makes more sense to link |
Apache-HBase
commented
Aug 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 3, 2021
🎊 +1 overall
This message was automatically generated. |
bharathv
commented
Aug 3, 2021
I'm not convinced by the explanation. I can see how /master-status has a summary in the footer and is a bit different from the other pages but it is usually a common pattern to do something like /rits?type=html /rits?type=json /rits?type=txt etc and all are served by the backing page (especially when they are serving the same information presented in different ways). Not a big deal though, don't want to block the progress here. I'm ok if @apurtell has already +1ed the patch. |
caroliney14
commented
Aug 3, 2021
@bharathv ok, I moved the JSON logic into |
bharathv
left a comment
There was a problem hiding this comment.
Thanks. Did you test it locally with some inputs?
| <div class="page-header"> | ||
| <a href="/rits.jsp?format=txt&filter=region&table=<%=table%>&state=<%=state%>" class="btn btn-primary">Regions in text format</a> | ||
| <a href="/rits.jsp?format=txt&filter=procedure&table=<%=table%>&state=<%=state%>" class="btn btn-info">Procedures in text format</a> | ||
| <a href="/rits.jsp?format=json" class="btn btn-info">RIT info as JSON</a> |
There was a problem hiding this comment.
Add table and state filters (=null) for completeness?
Apache-HBase
commented
Aug 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 3, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 3, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 4, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 4, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 4, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2021
🎊 +1 overall
This message was automatically generated. |
No description provided.