Uh oh!
There was an error while loading. Please reload this page.
HBASE-26189 Reduce log level of CompactionProgress notice to DEBUG - #3579
Conversation
Apache-HBase
commented
Aug 11, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 11, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 11, 2021
🎊 +1 overall
This message was automatically generated. |
virajjasani
left a comment
There was a problem hiding this comment.
Left a minor nit, looks good otherwise
| public long getTotalCompactingKVs() { | ||
| if (totalCompactingKVs < currentCompactedKVs) { | ||
| LOG.warn("totalCompactingKVs={} less than currentCompactedKVs={}", | ||
| if (LOG.isDebugEnabled()) { |
There was a problem hiding this comment.
isEnabled() check is redundant as we are using placeholders in log, which are going to be evaluated only if DEBUG level is enabled.
There was a problem hiding this comment.
Sure, I'll remember that (and remove the check)
ndimiduk
left a comment
There was a problem hiding this comment.
Looks good. Mind back porting to branch-2.3 as well? Thanks!
Apache-HBase
commented
Aug 16, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 16, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 16, 2021
🎊 +1 overall
This message was automatically generated. |
Reduce log level of CompactionProgress WARN "totalCompactingKVs=N less than currentCompactedKVs=M" to DEBUG pending resolution of the underlying issue.
Apache-HBase
commented
Aug 27, 2021
💔 -1 overall
This message was automatically generated. |
…3579) Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
…3579) Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
…3579) Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
…3579) Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Apache-HBase
commented
Aug 27, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 27, 2021
💔 -1 overall
This message was automatically generated. |
Reduce log level of CompactionProgress WARN "totalCompactingKVs=N less than currentCompactedKVs=M" to DEBUG pending resolution of the underlying issue.
Avoids noise in the logs at WARN level which can be an issue for operations. Those warnings are not currently actionable.