Amend HBASE-26187 UTs, adding a check for Split procedure completion … by wchevreuil · Pull Request #3598 · apache/hbase

wchevreuil · 2021-08-18T10:12:34Z

…before proceeding with test logic.

…before proceeding with test logic. Change-Id: I9a8066aa5c0f646d6e147ded1f09588a97ebe1ec

wchevreuil · 2021-08-18T10:19:30Z

+ List<Procedure<?>> procedures = TEST_UTIL.getHBaseCluster().getMaster().getProcedures();
+ if(procedures.size()>0) {
+ Procedure splitProc = procedures.stream().
+ filter(p -> p instanceof SplitTableRegionProcedure).findFirst().get();


Had to modify this logic a bit. The branch-2 version is wrong, leading to NoSuchElement when the first proc is not a split one. I will cherry-pick this once it gets merged.

Apache-HBase · 2021-08-18T11:01:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 5s	master passed
+1 💚	compile	3m 9s	master passed
+1 💚	checkstyle	1m 4s	master passed
+1 💚	spotbugs	2m 4s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 41s	the patch passed
+1 💚	compile	3m 6s	the patch passed
+1 💚	javac	3m 6s	the patch passed
+1 💚	checkstyle	0m 59s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 27s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 13s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		47m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3598/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3598
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 7408c80a3eda 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `33e15a2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3598/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-08-18T13:06:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 32s	master passed
+1 💚	compile	1m 13s	master passed
+1 💚	shadedjars	8m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 18s	the patch passed
+1 💚	compile	1m 12s	the patch passed
+1 💚	javac	1m 12s	the patch passed
+1 💚	shadedjars	8m 20s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
-1 ❌	unit	140m 56s	hbase-server in the patch failed.
		173m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3598/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3598
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8a190dd37854 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `33e15a2`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3598/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3598/1/testReport/
Max. process+thread count	4132 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3598/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil · 2021-08-18T13:25:01Z

The failed tests are passing, locally.

Apache-HBase · 2021-08-18T14:19:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 19s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 23s	master passed
+1 💚	compile	1m 2s	master passed
+1 💚	shadedjars	9m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 11s	the patch passed
+1 💚	compile	1m 10s	the patch passed
+1 💚	javac	1m 10s	the patch passed
+1 💚	shadedjars	9m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	212m 43s	hbase-server in the patch passed.
		246m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3598/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3598
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a9b45c0069aa 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `33e15a2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3598/1/testReport/
Max. process+thread count	2659 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3598/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…before proceeding with test logic. (#3598) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit f2e2140)

…before proceeding with test logic. (apache#3598) Signed-off-by: Duo Zhang <zhangduo@apache.org> Change-Id: Ieaf12fb87b73e573f59276c2be07d326531561bd

Amend HBASE-26187 UTs, adding a check for Split procedure completion …
01bbbc0
…before proceeding with test logic. Change-Id: I9a8066aa5c0f646d6e147ded1f09588a97ebe1ec

wchevreuil requested a review from Apache9 August 18, 2021 10:12

wchevreuil commented Aug 18, 2021
View reviewed changes

Apache9 approved these changes Aug 18, 2021
View reviewed changes

wchevreuil merged commit f2e2140 into apache:masterAug 18, 2021

wchevreuil added a commit that referenced this pull request Aug 18, 2021
AmendHBASE-26187UTs, adding a check for Split procedure completion …
f2f99ae
…before proceeding with test logic. (#3598) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit f2e2140)

Navigation Menu

Uh oh!

Amend HBASE-26187 UTs, adding a check for Split procedure completion … - #3598

Amend HBASE-26187 UTs, adding a check for Split procedure completion …#3598
wchevreuil merged 1 commit into
apache:masterfrom
wchevreuil:HBASE-26187-Amend

wchevreuil commented Aug 18, 2021

Uh oh!

wchevreuilAug 18, 2021•
edited
Loading

Uh oh!

Apache-HBase commented Aug 18, 2021

Uh oh!

Apache-HBase commented Aug 18, 2021

Uh oh!

wchevreuil commented Aug 18, 2021

Uh oh!

Apache-HBase commented Aug 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

wchevreuil commented Aug 18, 2021

Uh oh!

wchevreuilAug 18, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Aug 18, 2021

Uh oh!

Apache-HBase commented Aug 18, 2021

Uh oh!

wchevreuil commented Aug 18, 2021

Uh oh!

Apache-HBase commented Aug 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wchevreuilAug 18, 2021•
edited
Loading