Skip to content

HBASE-15666 shaded dependencies for hbase-testing-util - #360

Merged
meszibalu merged 6 commits into
apache:masterfrom
meszibalu:my/shaded-master
Jul 23, 2019
Merged

HBASE-15666 shaded dependencies for hbase-testing-util#360
meszibalu merged 6 commits into
apache:masterfrom
meszibalu:my/shaded-master

Conversation

@meszibalu

@meszibalumeszibalu commented Jul 5, 2019•
edited by busbey
Loading

Copy link
Copy Markdown
Contributor

Added new artifact hbase-shaded-testing-util. It wraps a whole hbase-server
with its testing dependencies. Users should use only the following dependency
in pom:

<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-shaded-testing-util</artifactId>
<version>${hbase.version}</version>
<scope>test</scope>
</dependency>

Added hbase-shaded-testing-util-tester maven module which ensures
that hbase-shaded-testing-util works with a shaded client.

@meszibalu
HBASE-15666 shaded dependencies for hbase-testing-util
cdeff0f
Added new artifact hbase-shaded-testing-util. It wraps a whole hbase-server
with its testing dependencies. Users should use only the following dependency
in pom:
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-shaded-testing-util</artifactId>
<version>${hbase.version}</version>
<scope>test</scope>
</dependency>
Added hbase-shaded-testing-util-tester maven module which ensures
that hbase-shaded-testing-util works with a shaded client.
@Apache-HBase

Apache-HBase commented Jul 5, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec24Docker mode activated.
_ Prechecks _
0shelldocs0Shelldocs was not available.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 3 new or modified test files.
_ master Compile Tests _
0mvndep12Maven dependency ordering for branch
+1mvninstall234master passed
+1compile158master passed
+1checkstyle126master passed
+1shadedjars261branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants .
+1findbugs0master passed
+1javadoc202master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall283the patch passed
+1compile164the patch passed
+1javac164the patch passed
-1checkstyle129root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1shellcheck0There were no new shellcheck issues.
+1whitespace0The patch has no whitespace issues.
+1xml8The patch has no ill-formed XML file.
+1shadedjars261patch has no errors when building our shaded downstream artifacts.
-1hadoopcheck586The patch causes 12 errors with Hadoop v3.1.2.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester
+1findbugs0the patch passed
+1javadoc230the patch passed
_ Other Tests _
+1unit12796root in the patch passed.
+1asflicense243The patch does not generate ASF License warnings.
15835
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/1/artifact/out/Dockerfile
GITHUB PR#360
Optional Testsdupname asflicense javac javadoc unit xml shellcheck shelldocs shadedjars hadoopcheck compile findbugs hbaseanti checkstyle
unameLinux 80125c2d5fe7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 9116534
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
shellcheckv0.4.4
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/1/artifact/out/diff-checkstyle-root.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/1/artifact/out/patch-javac-3.1.2.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/1/testReport/
Max. process+thread count5683 (vs. ulimit of 10000)
modulesC: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@busbey
busbey self-requested a review July 9, 2019 17:09
@busbey

busbey commented Jul 9, 2019

Copy link
Copy Markdown
Contributor

I presume the dependency information will go in a release note? Should we call this out in the ref guide now?

busbey
busbey requested changes Jul 9, 2019
View reviewed changes
Comment thread...testing-util-tester/src/test/java/org/apache/hbase/shaded/TestShadedHBaseTestingUtility.java
Comment thread...il/src/main/resources/org/apache/hadoop/hbase/shaded/org/eclipse/jetty/webapp/webdefault.xml
Comment threadpom.xml
busbey
busbey reviewed Jul 9, 2019
View reviewed changes
Comment threadhbase-resource-bundle/src/main/resources/supplemental-models.xml Outdated
@Apache-HBase

Apache-HBase commented Jul 9, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec23Docker mode activated.
_ Prechecks _
0shelldocs0Shelldocs was not available.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 3 new or modified test files.
_ master Compile Tests _
0mvndep11Maven dependency ordering for branch
+1mvninstall251master passed
+1compile165master passed
+1checkstyle125master passed
+1shadedjars260branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants .
+1findbugs0master passed
+1javadoc196master passed
_ Patch Compile Tests _
0mvndep13Maven dependency ordering for patch
+1mvninstall298the patch passed
+1compile166the patch passed
+1javac166the patch passed
-1checkstyle133root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1shellcheck1There were no new shellcheck issues.
+1whitespace0The patch has no whitespace issues.
+1xml9The patch has no ill-formed XML file.
+1shadedjars265patch has no errors when building our shaded downstream artifacts.
-1hadoopcheck589The patch causes 12 errors with Hadoop v3.1.2.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants .
+1findbugs0the patch passed
+1javadoc240the patch passed
_ Other Tests _
+1unit12283root in the patch passed.
+1asflicense185The patch does not generate ASF License warnings.
15297
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/2/artifact/out/Dockerfile
GITHUB PR#360
Optional Testsdupname asflicense javac javadoc unit xml shellcheck shelldocs shadedjars hadoopcheck compile findbugs hbaseanti checkstyle
unameLinux 16d12ca43f7e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 9ac9505
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
shellcheckv0.4.4
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/2/artifact/out/diff-checkstyle-root.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/2/artifact/out/patch-javac-3.1.2.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/2/testReport/
Max. process+thread count5185 (vs. ulimit of 10000)
modulesC: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@busbey

busbey commented Jul 12, 2019

Copy link
Copy Markdown
Contributor

Retest build

busbey
busbey reviewed Jul 12, 2019
View reviewed changes
Comment threadhbase-shaded/hbase-shaded-testing-util-tester/pom.xml
Comment threadpom.xml
@Apache-HBase

Apache-HBase commented Jul 12, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec34Docker mode activated.
_ Prechecks _
0shelldocs0Shelldocs was not available.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 3 new or modified test files.
_ master Compile Tests _
0mvndep28Maven dependency ordering for branch
+1mvninstall251master passed
+1compile161master passed
+1checkstyle130master passed
+1shadedjars269branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants .
+1findbugs0master passed
-1javadoc154root in master failed.
_ Patch Compile Tests _
0mvndep12Maven dependency ordering for patch
+1mvninstall285the patch passed
+1compile165the patch passed
+1javac165the patch passed
+1checkstyle122the patch passed
+1shellcheck1There were no new shellcheck issues.
+1whitespace0The patch has no whitespace issues.
+1xml8The patch has no ill-formed XML file.
+1shadedjars263patch has no errors when building our shaded downstream artifacts.
-1hadoopcheck579The patch causes 12 errors with Hadoop v3.1.2.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester
+1findbugs0the patch passed
+1javadoc226the patch passed
_ Other Tests _
+1unit12920root in the patch passed.
+1asflicense191The patch does not generate ASF License warnings.
15939
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/3/artifact/out/Dockerfile
GITHUB PR#360
Optional Testsdupname asflicense javac javadoc unit xml shellcheck shelldocs shadedjars hadoopcheck compile findbugs hbaseanti checkstyle
unameLinux 3aa57da84808 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 438bf32
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
shellcheckv0.4.4
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/3/artifact/out/branch-javadoc-root.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/3/artifact/out/patch-javac-3.1.2.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/3/testReport/
Max. process+thread count5497 (vs. ulimit of 10000)
modulesC: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 15, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec31Docker mode activated.
_ Prechecks _
0shelldocs1Shelldocs was not available.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 3 new or modified test files.
_ master Compile Tests _
0mvndep25Maven dependency ordering for branch
+1mvninstall248master passed
+1compile164master passed
+1checkstyle129master passed
+1shadedjars265branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants .
+1findbugs0master passed
+1javadoc204master passed
_ Patch Compile Tests _
0mvndep13Maven dependency ordering for patch
+1mvninstall277the patch passed
+1compile159the patch passed
+1javac159the patch passed
+1checkstyle126the patch passed
+1shellcheck0There were no new shellcheck issues.
+1whitespace0The patch has no whitespace issues.
+1xml7The patch has no ill-formed XML file.
+1shadedjars252patch has no errors when building our shaded downstream artifacts.
-1hadoopcheck591The patch causes 12 errors with Hadoop v3.1.2.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester
+1findbugs0the patch passed
+1javadoc221the patch passed
_ Other Tests _
-1unit10988root in the patch failed.
+1asflicense226The patch does not generate ASF License warnings.
14018
ReasonTests
Failed junit testshadoop.hbase.snapshot.TestExportSnapshot
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/4/artifact/out/Dockerfile
GITHUB PR#360
Optional Testsdupname asflicense javac javadoc unit xml shellcheck shelldocs shadedjars hadoopcheck compile findbugs hbaseanti checkstyle
unameLinux d000e4041bad 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 74731c2
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
shellcheckv0.4.4
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/4/artifact/out/patch-javac-3.1.2.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/4/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/4/testReport/
Max. process+thread count5153 (vs. ulimit of 10000)
modulesC: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/4/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 16, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec50Docker mode activated.
_ Prechecks _
0shelldocs1Shelldocs was not available.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 3 new or modified test files.
_ master Compile Tests _
0mvndep12Maven dependency ordering for branch
+1mvninstall230master passed
+1compile160master passed
+1checkstyle123master passed
+1shadedjars253branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants .
+1findbugs0master passed
+1javadoc203master passed
_ Patch Compile Tests _
0mvndep13Maven dependency ordering for patch
+1mvninstall274the patch passed
+1compile157the patch passed
+1javac157the patch passed
+1checkstyle118the patch passed
+1shellcheck0There were no new shellcheck issues.
+1whitespace0The patch has no whitespace issues.
+1xml9The patch has no ill-formed XML file.
+1shadedjars254patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck876Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester
+1findbugs0the patch passed
+1javadoc246the patch passed
_ Other Tests _
-1unit17255root in the patch failed.
+1asflicense230The patch does not generate ASF License warnings.
20858
ReasonTests
Failed junit testshadoop.hbase.replication.TestNamespaceReplication
hadoop.hbase.master.procedure.TestSCPWithReplicas
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/5/artifact/out/Dockerfile
GITHUB PR#360
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile shellcheck shelldocs findbugs hbaseanti checkstyle
unameLinux 9974019909e1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / cc38de1
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
shellcheckv0.4.4
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/5/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/5/testReport/
Max. process+thread count5084 (vs. ulimit of 10000)
modulesC: hbase-resource-bundle hbase-it hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/5/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 17, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec57Docker mode activated.
_ Prechecks _
0shelldocs0Shelldocs was not available.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 3 new or modified test files.
_ master Compile Tests _
0mvndep12Maven dependency ordering for branch
+1mvninstall226master passed
+1compile154master passed
+1checkstyle122master passed
+1shadedjars255branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants .
+1findbugs0master passed
+1javadoc220master passed
_ Patch Compile Tests _
0mvndep13Maven dependency ordering for patch
+1mvninstall276the patch passed
+1compile160the patch passed
+1javac160the patch passed
+1checkstyle123the patch passed
+1shellcheck1There were no new shellcheck issues.
+1whitespace0The patch has no whitespace issues.
+1xml8The patch has no ill-formed XML file.
+1shadedjars254patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck862Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester
+1findbugs0the patch passed
+1javadoc250the patch passed
_ Other Tests _
-1unit18622root in the patch failed.
+1asflicense151The patch does not generate ASF License warnings.
22162
ReasonTests
Failed junit testshadoop.hbase.master.procedure.TestSCPWithReplicas
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/6/artifact/out/Dockerfile
GITHUB PR#360
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile shellcheck shelldocs findbugs hbaseanti checkstyle
unameLinux 23671e104941 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 72e58a8
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
shellcheckv0.4.4
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/6/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/6/testReport/
Max. process+thread count4703 (vs. ulimit of 10000)
modulesC: hbase-resource-bundle hbase-it hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/6/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 21, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec172Docker mode activated.
_ Prechecks _
0shelldocs0Shelldocs was not available.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 3 new or modified test files.
_ master Compile Tests _
0mvndep27Maven dependency ordering for branch
+1mvninstall275master passed
+1compile185master passed
+1checkstyle157master passed
+1shadedjars288branch has no errors when building our shaded downstream artifacts.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-check-invariants
+1findbugs0master passed
+1javadoc219master passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall321the patch passed
+1compile190the patch passed
+1javac190the patch passed
+1checkstyle146the patch passed
+1shellcheck1There were no new shellcheck issues.
+1whitespace0The patch has no whitespace issues.
+1xml8The patch has no ill-formed XML file.
+1shadedjars285patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1061Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
0findbugs0Skipped patched modules with no Java source: hbase-resource-bundle hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester
+1findbugs0the patch passed
+1javadoc243the patch passed
_ Other Tests _
+1unit17462root in the patch passed.
+1asflicense219The patch does not generate ASF License warnings.
21690
SubsystemReport/Notes
DockerClient=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/7/artifact/out/Dockerfile
GITHUB PR#360
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile shellcheck shelldocs findbugs hbaseanti checkstyle
unameLinux 766f300413b2 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 00075ea
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
shellcheckv0.4.4
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/7/testReport/
Max. process+thread count5364 (vs. ulimit of 10000)
modulesC: hbase-resource-bundle hbase-it hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/7/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

joshelser
joshelser approved these changes Jul 22, 2019
View reviewed changes

@joshelserjoshelser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. I didn't realize what this was :)

You have my +1

Comment threadhbase-shaded/hbase-shaded-testing-util-tester/pom.xml
Comment threadhbase-shaded/hbase-shaded-testing-util/pom.xml
<artifactId>hadoop-common</artifactId>
<version>${hadoop.version}</version>
<type>test-jar</type>
<scope>compile</scope>

@joshelserjoshelserJul 22, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compile is the default scope, so couldn't you drop it for all of the dependencies here?

@joshelserjoshelserJul 22, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: OK if you just want to drop these on commit. Don't need to see a new version to just omit the defaults.

@meszibalumeszibaluJul 23, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these dependencies are also on the classpath through transitive dependencies with test scope. That's the reason why I added them explicitly with compile scope.

@joshelserjoshelserJul 23, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that matter? I am 99% sure that test-scoped dependencies are not transitively included (thus, the reason for making an hbase-shaded-testing-util module in the first place).

@Apache-HBase

Apache-HBase commented Jul 23, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec63Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
0shelldocs1Shelldocs was not available.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 3 new or modified test files.
_ master Compile Tests _
0mvndep12Maven dependency ordering for branch
+1mvninstall230master passed
+1compile156master passed
+1checkstyle137master passed
+1shadedjars263branch has no errors when building our shaded downstream artifacts.
+1javadoc216master passed
0spotbugs835Used deprecated FindBugs config; considering switching to SpotBugs.
0findbugs11branch/hbase-resource-bundle no findbugs output file (findbugsXml.xml)
0findbugs24branch/hbase-shaded no findbugs output file (findbugsXml.xml)
0findbugs10branch/hbase-shaded/hbase-shaded-check-invariants no findbugs output file (findbugsXml.xml)
0findbugs10branch/hbase-shaded/hbase-shaded-with-hadoop-check-invariants no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
0mvndep13Maven dependency ordering for patch
+1mvninstall277the patch passed
+1compile162the patch passed
+1javac162the patch passed
+1checkstyle136the patch passed
+1shellcheck1There were no new shellcheck issues.
+1whitespace0The patch has no whitespace issues.
+1xml9The patch has no ill-formed XML file.
+1shadedjars255patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck885Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc233the patch passed
0findbugs10hbase-resource-bundle has no data from findbugs
0findbugs36hbase-shaded has no data from findbugs
0findbugs19hbase-shaded/hbase-shaded-testing-util has no data from findbugs
0findbugs11hbase-shaded/hbase-shaded-check-invariants has no data from findbugs
0findbugs11hbase-shaded/hbase-shaded-with-hadoop-check-invariants has no data from findbugs
0findbugs12hbase-shaded/hbase-shaded-testing-util-tester has no data from findbugs
_ Other Tests _
-1unit15781root in the patch failed.
+1asflicense187The patch does not generate ASF License warnings.
21255
ReasonTests
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
SubsystemReport/Notes
DockerClient=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/12/artifact/out/Dockerfile
GITHUB PR#360
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile shellcheck shelldocs spotbugs findbugs hbaseanti checkstyle
unameLinux ffd478d65b0e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-360/out/precommit/personality/provided.sh
git revisionmaster / 9615c64
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/12/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/12/testReport/
Max. process+thread count4602 (vs. ulimit of 10000)
modulesC: hbase-resource-bundle hbase-it hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/12/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 23, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec57Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
0shelldocs0Shelldocs was not available.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 3 new or modified test files.
_ master Compile Tests _
0mvndep24Maven dependency ordering for branch
+1mvninstall333master passed
+1compile218master passed
+1checkstyle192master passed
+1shadedjars356branch has no errors when building our shaded downstream artifacts.
+1javadoc277master passed
0spotbugs1078Used deprecated FindBugs config; considering switching to SpotBugs.
0findbugs13branch/hbase-resource-bundle no findbugs output file (findbugsXml.xml)
0findbugs32branch/hbase-shaded no findbugs output file (findbugsXml.xml)
0findbugs13branch/hbase-shaded/hbase-shaded-check-invariants no findbugs output file (findbugsXml.xml)
0findbugs13branch/hbase-shaded/hbase-shaded-with-hadoop-check-invariants no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall388the patch passed
+1compile230the patch passed
+1javac230the patch passed
+1checkstyle185the patch passed
+1shellcheck1There were no new shellcheck issues.
+1whitespace0The patch has no whitespace issues.
+1xml13The patch has no ill-formed XML file.
+1shadedjars348patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1170Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc310the patch passed
0findbugs12hbase-resource-bundle has no data from findbugs
0findbugs46hbase-shaded has no data from findbugs
0findbugs27hbase-shaded/hbase-shaded-testing-util has no data from findbugs
0findbugs15hbase-shaded/hbase-shaded-check-invariants has no data from findbugs
0findbugs13hbase-shaded/hbase-shaded-with-hadoop-check-invariants has no data from findbugs
0findbugs15hbase-shaded/hbase-shaded-testing-util-tester has no data from findbugs
_ Other Tests _
-1unit16103root in the patch failed.
+1asflicense213The patch does not generate ASF License warnings.
23346
ReasonTests
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
SubsystemReport/Notes
DockerClient=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/13/artifact/out/Dockerfile
GITHUB PR#360
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile shellcheck shelldocs spotbugs findbugs hbaseanti checkstyle
unameLinux 264e938fedc8 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-360/out/precommit/personality/provided.sh
git revisionmaster / 0e34dcb
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/13/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/13/testReport/
Max. process+thread count4560 (vs. ulimit of 10000)
modulesC: hbase-resource-bundle hbase-it hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/13/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 23, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec153Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
0shelldocs1Shelldocs was not available.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 3 new or modified test files.
_ master Compile Tests _
0mvndep33Maven dependency ordering for branch
+1mvninstall392master passed
+1compile225master passed
+1checkstyle190master passed
+1shadedjars357branch has no errors when building our shaded downstream artifacts.
+1javadoc288master passed
0spotbugs1118Used deprecated FindBugs config; considering switching to SpotBugs.
0findbugs13branch/hbase-resource-bundle no findbugs output file (findbugsXml.xml)
0findbugs32branch/hbase-shaded no findbugs output file (findbugsXml.xml)
0findbugs15branch/hbase-shaded/hbase-shaded-check-invariants no findbugs output file (findbugsXml.xml)
0findbugs13branch/hbase-shaded/hbase-shaded-with-hadoop-check-invariants no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall405the patch passed
+1compile236the patch passed
+1javac236the patch passed
+1checkstyle182the patch passed
+1shellcheck0There were no new shellcheck issues.
+1whitespace0The patch has no whitespace issues.
+1xml12The patch has no ill-formed XML file.
+1shadedjars377patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1339Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc348the patch passed
0findbugs14hbase-resource-bundle has no data from findbugs
0findbugs50hbase-shaded has no data from findbugs
0findbugs25hbase-shaded/hbase-shaded-testing-util has no data from findbugs
0findbugs14hbase-shaded/hbase-shaded-check-invariants has no data from findbugs
0findbugs14hbase-shaded/hbase-shaded-with-hadoop-check-invariants has no data from findbugs
0findbugs16hbase-shaded/hbase-shaded-testing-util-tester has no data from findbugs
_ Other Tests _
-1unit14496root in the patch failed.
+1asflicense261The patch does not generate ASF License warnings.
22298
ReasonTests
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/15/artifact/out/Dockerfile
GITHUB PR#360
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile shellcheck shelldocs spotbugs findbugs hbaseanti checkstyle
unameLinux 14eeace2b1dc 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-360/out/precommit/personality/provided.sh
git revisionmaster / 06f5c43
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/15/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/15/testReport/
Max. process+thread count4623 (vs. ulimit of 10000)
modulesC: hbase-resource-bundle hbase-it hbase-shaded hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . hbase-shaded/hbase-shaded-testing-util-tester U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/15/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@meszibalu
meszibalu merged commit e74d501 into apache:masterJul 23, 2019
@Apache-HBase

Apache-HBase commented Jul 23, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec0Docker mode activated.
-1patch9#360 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
GITHUB PR#360
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-360/16/console
versionsgit=2.7.4
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@meszibalu
meszibalu deleted the my/shaded-master branch July 23, 2019 13:27
@wchevreuilwchevreuil mentioned this pull request Oct 26, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@busbeybusbeybusbey requested changes
@joshelserjoshelserjoshelser approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@meszibalu@Apache-HBase@busbey@joshelser