Skip to content

HBASE-22664 Move protobuf stuff in hbase-rsgroup to hbase-protocol-sh… - #362

Merged
Apache9 merged 1 commit into
apache:HBASE-22514from
Apache9:HBASE-22664
Jul 9, 2019
Merged

HBASE-22664 Move protobuf stuff in hbase-rsgroup to hbase-protocol-sh…#362
Apache9 merged 1 commit into
apache:HBASE-22514from
Apache9:HBASE-22664

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

…aded

@infraioinfraio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSGroupAdminEndpoint should import shaded proto?

public static HBaseProtos.TimeRange toTimeRange(TimeRange timeRange) {
if (timeRange == null) {
timeRange = TimeRange.allTime();
public static RSGroupProtos.RSGroupInfo toProtoGroupInfo(RSGroupInfo pojo) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method should be removed?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least we still need it for now as it is referenced in lots of places. Not sure if we can remove it at the end. FWIW, I think we still need to support the old way to change rsgroup, which uses coprocessor endpoint?

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec23Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep24Maven dependency ordering for branch
+1mvninstall245master passed
+1compile105master passed
+1checkstyle60master passed
+1shadedjars268branch has no errors when building our shaded downstream artifacts.
+1findbugs321master passed
+1javadoc63master passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall241the patch passed
+1compile104the patch passed
+1cc104the patch passed
+1javac104the patch passed
+1checkstyle60the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml2The patch has no ill-formed XML file.
+1shadedjars269patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck761Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc121the patch passed
+1findbugs362the patch passed
+1javadoc63the patch passed
_ Other Tests _
+1unit37hbase-protocol-shaded in the patch passed.
+1unit24hbase-protocol in the patch passed.
+1unit109hbase-client in the patch passed.
+1unit221hbase-rsgroup in the patch passed.
+1asflicense46The patch does not generate ASF License warnings.
3918
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/1/artifact/out/Dockerfile
GITHUB PR#362
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc xml
unameLinux 3dcf9ec97852 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 605f8a1
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/1/testReport/
Max. process+thread count4602 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-protocol hbase-client hbase-rsgroup U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec52Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep30Maven dependency ordering for branch
+1mvninstall275master passed
+1compile103master passed
+1checkstyle61master passed
+1shadedjars270branch has no errors when building our shaded downstream artifacts.
+1findbugs327master passed
+1javadoc68master passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall237the patch passed
+1compile104the patch passed
+1cc104the patch passed
+1javac104the patch passed
+1checkstyle67the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml1The patch has no ill-formed XML file.
+1shadedjars274patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck791Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc122the patch passed
+1findbugs353the patch passed
+1javadoc60the patch passed
_ Other Tests _
+1unit37hbase-protocol-shaded in the patch passed.
+1unit25hbase-protocol in the patch passed.
+1unit108hbase-client in the patch passed.
-1unit574hbase-rsgroup in the patch failed.
+1asflicense43The patch does not generate ASF License warnings.
4386
ReasonTests
Failed junit testshadoop.hbase.rsgroup.TestRSGroupsBalance
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/2/artifact/out/Dockerfile
GITHUB PR#362
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc xml
unameLinux 5bf55cae4981 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 605f8a1
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/2/artifact/out/patch-unit-hbase-rsgroup.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/2/testReport/
Max. process+thread count4514 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-protocol hbase-client hbase-rsgroup U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec151Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep25Maven dependency ordering for branch
+1mvninstall252master passed
+1compile106master passed
+1checkstyle69master passed
+1shadedjars266branch has no errors when building our shaded downstream artifacts.
+1findbugs321master passed
+1javadoc61master passed
_ Patch Compile Tests _
0mvndep13Maven dependency ordering for patch
+1mvninstall240the patch passed
+1compile107the patch passed
+1cc107the patch passed
+1javac107the patch passed
+1checkstyle65the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml2The patch has no ill-formed XML file.
+1shadedjars269patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck746Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1hbaseprotoc108the patch passed
+1findbugs399the patch passed
+1javadoc57the patch passed
_ Other Tests _
+1unit36hbase-protocol-shaded in the patch passed.
+1unit25hbase-protocol in the patch passed.
+1unit111hbase-client in the patch passed.
+1unit463hbase-rsgroup in the patch passed.
+1asflicense46The patch does not generate ASF License warnings.
4298
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/3/artifact/out/Dockerfile
GITHUB PR#362
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc xml
unameLinux 6270fc02cad9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 605f8a1
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/3/testReport/
Max. process+thread count4410 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-protocol hbase-client hbase-rsgroup U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-362/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

Any other concerns? @infraio
Thanks.

@infraioinfraio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. The RSGroupAdmin.proto not be removed and just copied to shade protobuf module.
+1.

@Apache9Apache9 changed the title HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh…HBASE-22664 Move protobuf stuff in hbase-rsgroup to hbase-protocol-sh…Jul 9, 2019
@Apache9
Apache9 changed the base branch from master to HBASE-22514July 9, 2019 01:50
@Apache9
Apache9 merged commit 83db672 into apache:HBASE-22514Jul 9, 2019
asfgit pushed a commit that referenced this pull request Jul 11, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Jul 14, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Jul 16, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Jul 18, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Jul 19, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Jul 21, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Jul 22, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Jul 23, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Jul 25, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Jul 28, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Jul 30, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 1, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 2, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 7, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 8, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 15, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 16, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 18, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 22, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 11, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 16, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 17, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 18, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 20, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 24, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Oct 5, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Oct 28, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Nov 5, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Nov 10, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Nov 13, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Dec 24, 2019
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 2, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 3, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 4, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 6, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 7, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 8, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 9, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 12, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 20, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 22, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 25, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 26, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 29, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Apache9 added a commit that referenced this pull request Mar 2, 2020
…aded (#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
…aded (apache#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
…aded (apache#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
…aded (apache#362)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
(cherry picked from commit d364364)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@infraio