Skip to content

HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because almost all of the heap allocation will happen in another separated allocator named HEAP - #365

Merged
openinx merged 1 commit into
apache:masterfrom
openinx:master
Jul 20, 2019
Merged

Conversation

@openinx

@openinxopeninx commented Jul 9, 2019

Copy link
Copy Markdown
Member

No description provided.

@Apache-HBase

Apache-HBase commented Jul 9, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec84Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep25Maven dependency ordering for branch
+1mvninstall276master passed
+1compile79master passed
+1checkstyle109master passed
+1shadedjars317branch has no errors when building our shaded downstream artifacts.
+1findbugs279master passed
+1javadoc57master passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall262the patch passed
+1compile78the patch passed
+1javac78the patch passed
+1checkstyle106the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars299patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck895Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs301the patch passed
+1javadoc59the patch passed
_ Other Tests _
+1unit187hbase-common in the patch passed.
+1unit14728hbase-server in the patch passed.
+1asflicense50The patch does not generate ASF License warnings.
18578
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/2/artifact/out/Dockerfile
GITHUB PR#365
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux c9f89faaca9d 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 605f8a1
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/2/testReport/
Max. process+thread count4923 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 9, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec72Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep35Maven dependency ordering for branch
+1mvninstall297master passed
+1compile79master passed
+1checkstyle93master passed
+1shadedjars283branch has no errors when building our shaded downstream artifacts.
+1findbugs256master passed
+1javadoc57master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall255the patch passed
+1compile77the patch passed
+1javac77the patch passed
+1checkstyle94the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars283patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck828Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs284the patch passed
+1javadoc55the patch passed
_ Other Tests _
+1unit179hbase-common in the patch passed.
-1unit19855hbase-server in the patch failed.
+1asflicense75The patch does not generate ASF License warnings.
23537
ReasonTests
Failed junit testshadoop.hbase.tool.TestSecureBulkLoadHFiles
hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs
hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.master.procedure.TestProcedurePriority
hadoop.hbase.replication.TestReplicationSyncUpTool
hadoop.hbase.namespace.TestNamespaceAuditor
hadoop.hbase.replication.TestReplicationSmallTestsSync
hadoop.hbase.tool.TestBulkLoadHFiles
hadoop.hbase.util.TestFromClientSide3WoUnsafe
hadoop.hbase.master.procedure.TestSCPWithReplicas
hadoop.hbase.replication.TestReplicationSmallTests
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/1/artifact/out/Dockerfile
GITHUB PR#365
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 162750ac65d7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 605f8a1
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/1/testReport/
Max. process+thread count5183 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 13, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec70Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep29Maven dependency ordering for branch
+1mvninstall277master passed
+1compile84master passed
+1checkstyle99master passed
+1shadedjars309branch has no errors when building our shaded downstream artifacts.
+1findbugs215master passed
+1javadoc61master passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall270the patch passed
+1compile87the patch passed
+1javac87the patch passed
+1checkstyle102the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars294patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck814Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs333the patch passed
+1javadoc59the patch passed
_ Other Tests _
+1unit184hbase-common in the patch passed.
-1unit15733hbase-server in the patch failed.
+1asflicense52The patch does not generate ASF License warnings.
19445
ReasonTests
Failed junit testshadoop.hbase.master.procedure.TestSCPWithReplicas
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/3/artifact/out/Dockerfile
GITHUB PR#365
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 85e2861d7beb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 438bf32
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/3/testReport/
Max. process+thread count5295 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

anoopsjohn
anoopsjohn approved these changes Jul 15, 2019
View reviewed changes

@anoopsjohnanoopsjohn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Apache-HBase

Apache-HBase commented Jul 15, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec27Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep23Maven dependency ordering for branch
+1mvninstall233master passed
+1compile71master passed
+1checkstyle85master passed
+1shadedjars254branch has no errors when building our shaded downstream artifacts.
+1findbugs243master passed
+1javadoc50master passed
_ Patch Compile Tests _
0mvndep13Maven dependency ordering for patch
+1mvninstall235the patch passed
+1compile68the patch passed
+1javac68the patch passed
+1checkstyle86the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars250patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck695Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs265the patch passed
+1javadoc51the patch passed
_ Other Tests _
+1unit169hbase-common in the patch passed.
+1unit7871hbase-server in the patch passed.
+1asflicense51The patch does not generate ASF License warnings.
11048
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/4/artifact/out/Dockerfile
GITHUB PR#365
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux f276bdba5faa 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 74731c2
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/4/testReport/
Max. process+thread count4363 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/4/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@openinx
HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because …
5c503d0
…all of the heap allocation will happen in another separated allocator named HEAP
@openinx

openinx commented Jul 16, 2019

Copy link
Copy Markdown
MemberAuthor

Thanks the +1 from @anoopsjohn , I think I forget to update the patch before...say when in disabled reservior case, we can share the global HEAP allocator. Yeah, I've updated the patch(Also some extra UT)
Let's see the hadoop QA, if OK I will commit the patch.

@Apache-HBase

Apache-HBase commented Jul 16, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec55Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep28Maven dependency ordering for branch
+1mvninstall274master passed
+1compile74master passed
+1checkstyle91master passed
+1shadedjars256branch has no errors when building our shaded downstream artifacts.
+1findbugs243master passed
+1javadoc49master passed
_ Patch Compile Tests _
0mvndep14Maven dependency ordering for patch
+1mvninstall225the patch passed
+1compile73the patch passed
+1javac73the patch passed
+1checkstyle85the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars255patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck708Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs191the patch passed
+1javadoc48the patch passed
_ Other Tests _
-1unit157hbase-common in the patch failed.
-1unit37hbase-server in the patch failed.
+1asflicense20The patch does not generate ASF License warnings.
3187
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/5/artifact/out/Dockerfile
GITHUB PR#365
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux b44788d8afc3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / cc38de1
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/5/artifact/out/patch-unit-hbase-common.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/5/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/5/testReport/
Max. process+thread count126 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/5/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 17, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec29Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0mvndep22Maven dependency ordering for branch
+1mvninstall234master passed
+1compile69master passed
+1checkstyle84master passed
+1shadedjars255branch has no errors when building our shaded downstream artifacts.
+1findbugs247master passed
+1javadoc49master passed
_ Patch Compile Tests _
0mvndep12Maven dependency ordering for patch
+1mvninstall228the patch passed
+1compile72the patch passed
+1javac72the patch passed
+1checkstyle88the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars259patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck745Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs268the patch passed
+1javadoc52the patch passed
_ Other Tests _
+1unit173hbase-common in the patch passed.
+1unit7778hbase-server in the patch passed.
+1asflicense57The patch does not generate ASF License warnings.
11049
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/6/artifact/out/Dockerfile
GITHUB PR#365
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 0f46a549805b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 72e58a8
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/6/testReport/
Max. process+thread count4741 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/6/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@openinx
openinx merged commit 00075ea into apache:masterJul 20, 2019
asfgit pushed a commit that referenced this pull request Jul 20, 2019
@openinx
HBASE-22663The HeapAllocationRatio in WebUI is not accurate because …
6fb03e6
…all of the heap allocation will happen in another separated allocator named HEAP (#365)
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@openinx@Apache9
HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because …
75a072a
…all of the heap allocation will happen in another separated allocator named HEAP (apache#365)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anoopsjohnanoopsjohnanoopsjohn approved these changes
@saintstacksaintstackAwaiting requested review from saintstack
@infraioinfraioAwaiting requested review from infraio
@ramkrish86ramkrish86Awaiting requested review from ramkrish86
@Apache9Apache9Awaiting requested review from Apache9

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openinx@Apache-HBase@anoopsjohn