Uh oh!
There was an error while loading. Please reload this page.
HBASE-26281 DBB got from BucketCache would be freed unexpectedly befo… - #3680
Conversation
| return null; | ||
| }); | ||
| } | ||
| /** |
There was a problem hiding this comment.
Here I move putIntoBackingMap from WriterThread to BucketCache to facilitate test.
| LOG.warn("Failed allocation for " + (re == null ? "" : re.getKey()) + "; " + fle); | ||
| // Presume can't add. Too big? Move index on. Entry will be cleared from ramCache below. | ||
| bucketEntries[index] = null; | ||
| /** |
There was a problem hiding this comment.
Here I move doDrainfrom WriterThread to BucketCache to facilitate test.
Apache-HBase
commented
Sep 14, 2021
🎊 +1 overall
This message was automatically generated. |
Apache9
left a comment
There was a problem hiding this comment.
The code is a bit difficult to fully understand but I read your description on jira and it is reasonable, and the test is good.
So I give a +1 here.
Let's see if we could pass all the UTs.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
Sep 14, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 14, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2021
🎊 +1 overall
This message was automatically generated. |
Apache9
commented
Sep 17, 2021
Please fix the checkstyle issue @comnetwork , then I will merge it~ Thanks. |
comnetwork
commented
Sep 17, 2021
@Apache9 , sorry for ignore the checkstyle issues.Fix it. |
Apache-HBase
commented
Sep 17, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 17, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 17, 2021
🎊 +1 overall
This message was automatically generated. |
…re RPC completed (#3680) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…re RPC completed (#3680) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…re RPC completed (#3680) Signed-off-by: Duo Zhang <zhangduo@apache.org>
… unexpectedly before RPC completed (apache#3680) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…re RPC completed (apache#3680) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…re RPC completed