Skip to content

HBASE-22673 Avoid to expose protobuf stuff in Hbck interface - #372

Merged
infraio merged 1 commit into
apache:masterfrom
infraio:hbck
Jul 19, 2019
Merged

HBASE-22673 Avoid to expose protobuf stuff in Hbck interface#372
infraio merged 1 commit into
apache:masterfrom
infraio:hbck

Conversation

@infraio

@infraioinfraio commented Jul 11, 2019

Copy link
Copy Markdown
Contributor

No description provided.

Apache9
Apache9 requested changes Jul 11, 2019
View reviewed changes
Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseHbck.java Outdated
Apache9
Apache9 approved these changes Jul 11, 2019
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

@Apache-HBase

Apache-HBase commented Jul 12, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec88Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall304master passed
+1compile25master passed
+1checkstyle29master passed
+1shadedjars267branch has no errors when building our shaded downstream artifacts.
+1findbugs62master passed
+1javadoc21master passed
_ Patch Compile Tests _
+1mvninstall254the patch passed
+1compile25the patch passed
+1javac25the patch passed
-1checkstyle29hbase-client: The patch generated 3 new + 114 unchanged - 0 fixed = 117 total (was 114)
+1whitespace0The patch has no whitespace issues.
+1shadedjars270patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck801Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs64the patch passed
+1javadoc19the patch passed
_ Other Tests _
+1unit107hbase-client in the patch passed.
+1asflicense10The patch does not generate ASF License warnings.
2686
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/1/artifact/out/Dockerfile
GITHUB PR#372
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux bf054a594670 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 438bf32
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/1/artifact/out/diff-checkstyle-hbase-client.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/1/testReport/
Max. process+thread count253 (vs. ulimit of 10000)
modulesC: hbase-client U: hbase-client
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet
HorizonNet reviewed Jul 14, 2019
View reviewed changes
Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/client/Hbck.java Outdated
throws IOException;
/**
* Use {@link #scheduleServerCrashProcedures(List)} instead.
* @deprecated since 2.2.1. Will removed in 2.3.0.

@HorizonNetHorizonNetJul 14, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please create a ticket targeting the 2.3.0 release and the current master for removal?

@infraioinfraioJul 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open a new issue HBASE-22708 for it.

@Apache-HBase

Apache-HBase commented Jul 15, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec54Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall256master passed
+1compile24master passed
+1checkstyle29master passed
+1shadedjars281branch has no errors when building our shaded downstream artifacts.
+1findbugs60master passed
+1javadoc22master passed
_ Patch Compile Tests _
+1mvninstall253the patch passed
+1compile24the patch passed
+1javac24the patch passed
-1checkstyle29hbase-client: The patch generated 3 new + 114 unchanged - 0 fixed = 117 total (was 114)
+1whitespace0The patch has no whitespace issues.
+1shadedjars280patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck769Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs67the patch passed
+1javadoc20the patch passed
_ Other Tests _
+1unit100hbase-client in the patch passed.
+1asflicense10The patch does not generate ASF License warnings.
2596
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/2/artifact/out/Dockerfile
GITHUB PR#372
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 9ee5269b13e0 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 74731c2
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/2/artifact/out/diff-checkstyle-hbase-client.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/2/testReport/
Max. process+thread count294 (vs. ulimit of 10000)
modulesC: hbase-client U: hbase-client
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 16, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec36Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall267master passed
+1compile23master passed
+1checkstyle29master passed
+1shadedjars275branch has no errors when building our shaded downstream artifacts.
+1findbugs59master passed
+1javadoc20master passed
_ Patch Compile Tests _
+1mvninstall255the patch passed
+1compile23the patch passed
+1javac23the patch passed
-1checkstyle31hbase-client: The patch generated 3 new + 114 unchanged - 0 fixed = 117 total (was 114)
+1whitespace0The patch has no whitespace issues.
+1shadedjars272patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck779Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs70the patch passed
+1javadoc22the patch passed
_ Other Tests _
+1unit113hbase-client in the patch passed.
+1asflicense10The patch does not generate ASF License warnings.
2599
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/3/artifact/out/Dockerfile
GITHUB PR#372
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 996e249e1054 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / cc38de1
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/3/artifact/out/diff-checkstyle-hbase-client.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/3/testReport/
Max. process+thread count287 (vs. ulimit of 10000)
modulesC: hbase-client U: hbase-client
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 17, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec64Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1mvninstall244root in master failed.
+1compile26master passed
+1checkstyle30master passed
+1shadedjars266branch has no errors when building our shaded downstream artifacts.
+1findbugs58master passed
+1javadoc20master passed
_ Patch Compile Tests _
-1mvninstall254root in the patch failed.
+1compile23the patch passed
+1javac23the patch passed
+1checkstyle28the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars268patch has no errors when building our shaded downstream artifacts.
-1hadoopcheck247The patch causes 10 errors with Hadoop v2.8.5.
-1hadoopcheck499The patch causes 10 errors with Hadoop v2.9.2.
-1hadoopcheck759The patch causes 10 errors with Hadoop v3.1.2.
+1findbugs66the patch passed
+1javadoc20the patch passed
_ Other Tests _
+1unit104hbase-client in the patch passed.
+1asflicense9The patch does not generate ASF License warnings.
2320
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/artifact/out/Dockerfile
GITHUB PR#372
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux c180c7eeb633 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 72e58a8
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/artifact/out/branch-mvninstall-root.txt
findbugsv3.1.11
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/artifact/out/patch-mvninstall-root.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/artifact/out/patch-javac-2.9.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/artifact/out/patch-javac-3.1.2.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/testReport/
Max. process+thread count295 (vs. ulimit of 10000)
modulesC: hbase-client U: hbase-client
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-372/4/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@infraio
infraio merged commit 48c623c into apache:masterJul 19, 2019
@infraio
infraio deleted the hbck branch July 19, 2019 00:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HorizonNetHorizonNetHorizonNet left review comments
@saintstacksaintstacksaintstack approved these changes
@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@infraio@Apache-HBase@saintstack@HorizonNet@Apache9