Skip to content

HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+ - #380

Closed
brfrn169 wants to merge 3 commits into
apache:branch-2from
brfrn169:HBASE-22690-branch-2
Closed

HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+#380
brfrn169 wants to merge 3 commits into
apache:branch-2from
brfrn169:HBASE-22690-branch-2

Conversation

@brfrn169

@brfrn169brfrn169 commented Jul 14, 2019•
edited
Loading

Copy link
Copy Markdown
Member

This is for branch-2. I changed OfflineMetaRepair to output a message pointing user to hbck2 operator tools and removed some unnecessary logics in HBaseFsck.

busbey
busbey requested changes Jul 14, 2019
View reviewed changes

@busbeybusbey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't point folks to unreleased code, so please just reference "hbck2 from hbase-operator-tools" and link to the explanation in the ref guide.

HorizonNet
HorizonNet requested changes Jul 14, 2019
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java Outdated
* mentioned.
*
* hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair ...
* We've deprecated this tool in hbase-2+ because it destroyed the hbase2 meta table.

@HorizonNetHorizonNetJul 14, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move this to the deprecated Javadoc annotation, stating the earliest version it was deprecated and in which version it should be removed?

@wchevreuil

wchevreuil commented Jul 15, 2019

Copy link
Copy Markdown
Contributor

Other than the suggestions from @busbey and @HorizonNet , lgtm. Tested that hbck readonly options still work, and trying to run OMR gives the warning message without doing anything.

@saintstack

saintstack commented Jul 15, 2019

Copy link
Copy Markdown
Contributor

Should we squash this PR @brfrn169 given you opened new one sir. Does new one address above comments? Thanks.

@Apache-HBase

Apache-HBase commented Jul 15, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec220Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
+1mvninstall260branch-2 passed
+1compile59branch-2 passed
+1checkstyle73branch-2 passed
+1shadedjars234branch has no errors when building our shaded downstream artifacts.
+1findbugs165branch-2 passed
+1javadoc36branch-2 passed
_ Patch Compile Tests _
+1mvninstall234the patch passed
+1compile53the patch passed
+1javac53the patch passed
-1checkstyle68hbase-server: The patch generated 4 new + 103 unchanged - 4 fixed = 107 total (was 107)
+1whitespace0The patch has no whitespace issues.
+1shadedjars246patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck709Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs170the patch passed
+1javadoc36the patch passed
_ Other Tests _
-1unit19226hbase-server in the patch failed.
+1asflicense30The patch does not generate ASF License warnings.
22126
ReasonTests
Failed junit testshadoop.hbase.client.TestRestoreSnapshotFromClientSimple
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.client.TestFromClientSideWithCoprocessor
hadoop.hbase.replication.TestReplicationKillSlaveRS
hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.client.TestCloneSnapshotFromClientNormal
hadoop.hbase.replication.TestMasterReplication
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.replication.TestReplicationAdminWithClusters
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/1/artifact/out/Dockerfile
GITHUB PR#380
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux bb5bc6b2b717 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionbranch-2 / b656944
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/1/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/1/testReport/
Max. process+thread count4575 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@brfrn169

brfrn169 commented Jul 16, 2019

Copy link
Copy Markdown
MemberAuthor

Thank you for reviewing guys.

I modified the patch for the review. Could you please review it? @busbey@HorizonNet

@brfrn169

brfrn169 commented Jul 16, 2019

Copy link
Copy Markdown
MemberAuthor

Should we squash this PR @brfrn169 given you opened new one sir. Does new one address above comments? Thanks.

@saintstack The new one means this PR, right?
#381

That is for the master branch. In that PR, I removed OfflineMetaRepair completely whereas in this PR (for branch-2), I changed OfflineMetaRepair to output a message pointing user to hbck2 operator tools.

My intention is to deprecate in 2.x and to remove in 3.0.

@Apache-HBase

Apache-HBase commented Jul 16, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec244Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
+1mvninstall455branch-2 passed
+1compile68branch-2 passed
+1checkstyle94branch-2 passed
+1shadedjars320branch has no errors when building our shaded downstream artifacts.
+1findbugs212branch-2 passed
+1javadoc42branch-2 passed
_ Patch Compile Tests _
+1mvninstall297the patch passed
+1compile68the patch passed
+1javac68the patch passed
-1checkstyle82hbase-server: The patch generated 4 new + 103 unchanged - 4 fixed = 107 total (was 107)
+1whitespace0The patch has no whitespace issues.
+1shadedjars311patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck914Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs191the patch passed
+1javadoc40the patch passed
_ Other Tests _
-1unit16102hbase-server in the patch failed.
+1asflicense42The patch does not generate ASF License warnings.
19859
ReasonTests
Failed junit testshadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/2/artifact/out/Dockerfile
GITHUB PR#380
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux cf3abb244e15 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionbranch-2 / 76c080b
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/2/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/2/testReport/
Max. process+thread count4887 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@brfrn169

brfrn169 commented Jul 16, 2019

Copy link
Copy Markdown
MemberAuthor

I fixed some checkstyle warnings.

@Apache-HBase

Apache-HBase commented Jul 17, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec34Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
+1mvninstall238branch-2 passed
+1compile52branch-2 passed
+1checkstyle70branch-2 passed
+1shadedjars240branch has no errors when building our shaded downstream artifacts.
+1findbugs151branch-2 passed
+1javadoc34branch-2 passed
_ Patch Compile Tests _
+1mvninstall231the patch passed
+1compile51the patch passed
+1javac51the patch passed
+1checkstyle67hbase-server: The patch generated 0 new + 101 unchanged - 6 fixed = 101 total (was 107)
+1whitespace0The patch has no whitespace issues.
+1shadedjars241patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck715Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs142the patch passed
+1javadoc32the patch passed
_ Other Tests _
+1unit7803hbase-server in the patch passed.
+1asflicense27The patch does not generate ASF License warnings.
10444
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/3/artifact/out/Dockerfile
GITHUB PR#380
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 9cc36205b412 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionbranch-2 / 6c834b9
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/3/testReport/
Max. process+thread count4637 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@brfrn169

brfrn169 commented Jul 19, 2019

Copy link
Copy Markdown
MemberAuthor

Ping @busbey@HorizonNet@saintstack

saintstack
saintstack approved these changes Jul 19, 2019
View reviewed changes

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent to me

@Apache-HBase

Apache-HBase commented Jul 20, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec85Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
+1mvninstall267branch-2 passed
+1compile58branch-2 passed
+1checkstyle89branch-2 passed
+1shadedjars285branch has no errors when building our shaded downstream artifacts.
+1findbugs216branch-2 passed
+1javadoc87branch-2 passed
_ Patch Compile Tests _
+1mvninstall278the patch passed
+1compile61the patch passed
+1javac61the patch passed
+1checkstyle84hbase-server: The patch generated 0 new + 101 unchanged - 6 fixed = 101 total (was 107)
+1whitespace0The patch has no whitespace issues.
+1shadedjars266patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck817Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs165the patch passed
+1javadoc35the patch passed
_ Other Tests _
-1unit15719hbase-server in the patch failed.
+1asflicense32The patch does not generate ASF License warnings.
18914
ReasonTests
Failed junit testshadoop.hbase.client.TestFromClientSide
hadoop.hbase.quotas.TestClusterScopeQuotaThrottle
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/4/artifact/out/Dockerfile
GITHUB PR#380
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux b508e2f9e409 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionbranch-2 / 6fb03e6
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/4/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/4/testReport/
Max. process+thread count4626 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/4/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 22, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec250Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
+1mvninstall404branch-2 passed
+1compile77branch-2 passed
+1checkstyle106branch-2 passed
+1shadedjars331branch has no errors when building our shaded downstream artifacts.
+1javadoc45branch-2 passed
0spotbugs246Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs244branch-2 passed
_ Patch Compile Tests _
+1mvninstall327the patch passed
+1compile64the patch passed
+1javac64the patch passed
+1checkstyle91hbase-server: The patch generated 0 new + 101 unchanged - 6 fixed = 101 total (was 107)
+1whitespace0The patch has no whitespace issues.
+1shadedjars289patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1022Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc40the patch passed
+1findbugs232the patch passed
_ Other Tests _
-1unit18925hbase-server in the patch failed.
+1asflicense31The patch does not generate ASF License warnings.
22889
ReasonTests
Failed junit testshadoop.hbase.client.TestAsyncSnapshotAdminApi
hadoop.hbase.client.TestFromClientSideWithCoprocessor
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestFromClientSide
SubsystemReport/Notes
DockerClient=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/5/artifact/out/Dockerfile
GITHUB PR#380
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 78b37afb3f2b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-380/out/precommit/personality/provided.sh
git revisionbranch-2 / c54085a
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/5/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/5/testReport/
Max. process+thread count4433 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/5/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@brfrn169

brfrn169 commented Jul 22, 2019

Copy link
Copy Markdown
MemberAuthor

Thank you for reviewing @saintstack. I'll commit this.

@Apache-HBase

Apache-HBase commented Jul 22, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec0Docker mode activated.
-1patch13#380 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
GITHUB PR#380
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/6/console
versionsgit=2.7.4
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 22, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec0Docker mode activated.
-1patch12#380 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
GITHUB PR#380
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/1/console
versionsgit=2.7.4
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 22, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec0Docker mode activated.
-1patch14#380 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
GITHUB PR#380
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-380/2/console
versionsgit=2.7.4
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@brfrn169brfrn169 self-assigned this Jul 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstacksaintstacksaintstack approved these changes
@Apache9Apache9Awaiting requested review from Apache9
@HorizonNetHorizonNetAwaiting requested review from HorizonNet
@busbeybusbeyAwaiting requested review from busbey

Assignees

@brfrn169brfrn169

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@brfrn169@wchevreuil@saintstack@Apache-HBase@busbey@HorizonNet