HBASE-22692 Added Rubocop definition file to bin directory by HorizonNet · Pull Request #382 · apache/hbase

HorizonNet · 2019-07-14T17:24:15Z

No description provided.

Apache-HBase · 2019-07-15T12:54:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	211	Docker mode activated.
		_ Prechecks _
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	11	The patch does not generate ASF License warnings.
		294

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/1/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux f4a0bfbba821 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `74731c2`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Max. process+thread count	46 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-16T09:46:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	74	Docker mode activated.
		_ Prechecks _
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	26	The patch does not generate ASF License warnings.
		163

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/2/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux a1e577a7e008 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `cc38de1`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Max. process+thread count	47 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-17T08:03:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	53	Docker mode activated.
		_ Prechecks _
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	12	The patch does not generate ASF License warnings.
		114

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/3/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux 9c0292f8663e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `72e58a8`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Max. process+thread count	46 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-20T18:07:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	157	Docker mode activated.
		_ Prechecks _
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	18	The patch does not generate ASF License warnings.
		240

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/4/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux 76e71a739755 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `00075ea`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Max. process+thread count	41 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-22T06:10:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	266	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	13	The patch does not generate ASF License warnings.
		334

Subsystem	Report/Notes
Docker	Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/5/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux 8303c5049865 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
git revision	master / `c9293b0`
Max. process+thread count	47 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-22T12:10:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	212	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	16	The patch does not generate ASF License warnings.
		283

Subsystem	Report/Notes
Docker	Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/6/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux 8b611cde7c6f 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
git revision	master / `aa9679d`
Max. process+thread count	47 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-22T14:14:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	116	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	14	The patch does not generate ASF License warnings.
		179

Subsystem	Report/Notes
Docker	Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/7/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux cff34dcd1156 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
git revision	master / `7f68591`
Max. process+thread count	46 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/7/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-22T17:18:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	127	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	18	The patch does not generate ASF License warnings.
		219

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/1/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux 22821ccb2809 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
git revision	master / `7f68591`
Max. process+thread count	41 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-22T22:14:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	192	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	16	The patch does not generate ASF License warnings.
		266

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/2/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux 5d727a25e42b 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
git revision	master / `9615c64`
Max. process+thread count	47 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-23T03:09:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	56	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	16	The patch does not generate ASF License warnings.
		127

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/3/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux bad4226cd82f 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
git revision	master / `0e34dcb`
Max. process+thread count	47 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-23T04:27:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	71	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	12	The patch does not generate ASF License warnings.
		130

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/4/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux 2d9f7bf23428 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
git revision	master / `06f5c43`
Max. process+thread count	47 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/4/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-23T05:35:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	37	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	12	The patch does not generate ASF License warnings.
		96

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/5/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux e40b699467da 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
git revision	master / `06f5c43`
Max. process+thread count	46 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-23T11:59:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	78	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	12	The patch does not generate ASF License warnings.
		157

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/6/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux f470781548b6 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
git revision	master / `b6d4529`
Max. process+thread count	46 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

petersomogyi · 2019-07-23T12:20:18Z

With this commit there will be 2 .rubocop.yml files in HBase with the same content. Would it make sense to move hbase-shell/src/main/ruby/.rubocop.yml to root folder instead?

Apache-HBase · 2019-07-23T13:23:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	67	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	18	The patch does not generate ASF License warnings.
		153

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/7/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint
uname	Linux d28687a6ef56 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
git revision	master / `e74d501`
Max. process+thread count	46 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/7/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet · 2019-07-23T13:28:43Z

@petersomogyi You're right. I updated the PR and moved the .rubocop.yml file into the root directory. Tested it by running Rubocop in both, the bin directory and the hbase-shell module. The reported violations are remaining the same.

Apache-HBase · 2019-07-24T04:51:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	80	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
0	mvndep	26	Maven dependency ordering for branch
+1	mvninstall	331	master passed
+1	javadoc	187	master passed
		_ Patch Compile Tests _
0	mvndep	13	Maven dependency ordering for patch
+1	mvninstall	338	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	javadoc	187	the patch passed
		_ Other Tests _
-1	unit	15519	root in the patch failed.
+1	asflicense	74	The patch does not generate ASF License warnings.
		16824

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestMobSnapshotCloneIndependence
	hadoop.hbase.util.TestFromClientSide3WoUnsafe

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/10/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint javac javadoc unit
uname	Linux c8e85f2163ac 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
git revision	master / `6705d4f`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/10/artifact/out/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/10/testReport/
Max. process+thread count	5027 (vs. ulimit of 10000)
modules	C: hbase-shell . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/10/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-24T08:41:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	63	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
0	mvndep	29	Maven dependency ordering for branch
+1	mvninstall	407	master passed
+1	javadoc	228	master passed
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
+1	mvninstall	389	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	javadoc	228	the patch passed
		_ Other Tests _
-1	unit	19820	root in the patch failed.
+1	asflicense	65	The patch does not generate ASF License warnings.
		21318

Reason	Tests
Failed junit tests	hadoop.hbase.replication.TestReplicationSmallTestsSync
	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
	hadoop.hbase.client.TestCloneSnapshotFromClientNormal
	hadoop.hbase.master.locking.TestLockProcedure
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.replication.TestReplicationSmallTests

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/11/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint javac javadoc unit
uname	Linux 8a5c053e9bad 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
git revision	master / `7ebf80f`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/11/artifact/out/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/11/testReport/
Max. process+thread count	4720 (vs. ulimit of 10000)
modules	C: hbase-shell . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/11/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-24T08:44:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	36	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
0	mvndep	28	Maven dependency ordering for branch
+1	mvninstall	305	master passed
+1	javadoc	193	master passed
		_ Patch Compile Tests _
0	mvndep	13	Maven dependency ordering for patch
+1	mvninstall	311	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	javadoc	180	the patch passed
		_ Other Tests _
+1	unit	13198	root in the patch passed.
+1	asflicense	61	The patch does not generate ASF License warnings.
		14393

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/12/artifact/out/Dockerfile
GITHUB PR	#382
Optional Tests	dupname asflicense yamllint javac javadoc unit
uname	Linux cc91547e8dd8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-382/out/precommit/personality/provided.sh
git revision	master / `7ebf80f`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/12/testReport/
Max. process+thread count	5461 (vs. ulimit of 10000)
modules	C: hbase-shell . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-382/12/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

HBASE-22692Added Rubocop definition file to bin directory
8f71f75

petersomogyi approved these changes Jul 23, 2019
View reviewed changes

petersomogyi merged commit 2edbf0b into apache:masterJul 24, 2019

HorizonNet deleted the HBASE-22692 branch July 24, 2019 20:27

Uh oh!

Conversation

HorizonNet commented Jul 14, 2019

Uh oh!

Apache-HBase commented Jul 15, 2019

Uh oh!

Apache-HBase commented Jul 16, 2019

Uh oh!

Apache-HBase commented Jul 17, 2019

Uh oh!

Apache-HBase commented Jul 20, 2019

Uh oh!

Apache-HBase commented Jul 22, 2019

Uh oh!

Apache-HBase commented Jul 22, 2019

Uh oh!

Apache-HBase commented Jul 22, 2019

Uh oh!

Apache-HBase commented Jul 22, 2019

Uh oh!

Apache-HBase commented Jul 22, 2019

Uh oh!

Apache-HBase commented Jul 23, 2019

Uh oh!

Apache-HBase commented Jul 23, 2019

Uh oh!

Apache-HBase commented Jul 23, 2019

Uh oh!

Apache-HBase commented Jul 23, 2019

Uh oh!

petersomogyi commented Jul 23, 2019

Uh oh!

Apache-HBase commented Jul 23, 2019

Uh oh!

HorizonNet commented Jul 23, 2019

Uh oh!

Apache-HBase commented Jul 24, 2019

Uh oh!

Apache-HBase commented Jul 24, 2019

Uh oh!

Apache-HBase commented Jul 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants