Uh oh!
There was an error while loading. Please reload this page.
HBASE-22382 Refactor tests in TestFromClientSide - #385
Merged
Conversation
anmolnar
commented
Jul 16, 2019
ContributorAuthor
retest build |
Apache-HBase
commented
Jul 16, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 17, 2019
🎊 +1 overall
This message was automatically generated. |
infraio
reviewed
Jul 17, 2019
| public void testNull() throws Exception { | ||
| final TableName tableName = TableName.valueOf(name.getMethodName()); | ||
| public void testNull_TableName() { |
Contributor
There was a problem hiding this comment.
testNullTableName? I thought we should keep use Camel-Case for method name.
infraio
reviewed
Jul 17, 2019
| } | ||
| @Test | ||
| public void testNull_FamilyName() { |
Contributor
There was a problem hiding this comment.
Ditto. Please update other methods' name too. Thanks.
Apache-HBase
commented
Jul 21, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2019
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
Jul 23, 2019
| try { | ||
| TEST_UTIL.createTable((TableName)null, FAMILY); | ||
| fail("Creating a table with null name passed, should have failed"); | ||
| } catch(Exception e) {} |
Contributor
There was a problem hiding this comment.
Since we have split the method, we can use the @test(expected = XXXException.class) so we do not need to catch the exception any more?
ContributorAuthor
There was a problem hiding this comment.
Right. Makes perfect sense.
| @@ -1234,7 +1246,14 @@ public void testNull() throws Exception { | |||
| } catch (Exception e) { | |||
| throw new IOException("Using a row with null qualifier threw exception, should "); | |||
Contributor
There was a problem hiding this comment.
Not your fault but since this is a refactoring, let's fix the message?
| } | ||
| @Test | ||
| @SuppressWarnings("checkstyle:MethodLength") |
Contributor
There was a problem hiding this comment.
Maybe in the future we will also split these methods so let's do not suppress the warning?
ContributorAuthor
There was a problem hiding this comment.
I tried to do so. But it seems to me that these tests are doing a sequence of operations which cannot be broken without doing a lot of redundant initialisation logic. I believe that the gain of making these tests smaller doesn't overcome the hit on the efficiency.
To be honest, checkstyle rule for maximizing the size of integration tests doesn't make sense to me.
| } | ||
| @Test | ||
| @SuppressWarnings("checkstyle:MethodLength") |
Apache-HBase
commented
Jul 23, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 23, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 23, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 23, 2019
🎊 +1 overall
This message was automatically generated. |
anmolnar
commented
Jul 23, 2019
ContributorAuthor
@Apache9 It's done and the build is green again. PTAL. |
Apache9
commented
Jul 23, 2019
Contributor
My comments are still not resolved? |
anmolnar
commented
Jul 23, 2019
ContributorAuthor
…ption, fixed language
Apache-HBase
commented
Jul 23, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
💔 -1 overall
This message was automatically generated. |
asfgit pushed a commit
that referenced
this pull request
Jul 25, 2019
Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit pushed a commit
that referenced
this pull request
Jul 25, 2019
Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit pushed a commit
that referenced
this pull request
Jul 25, 2019
Signed-off-by: Duo Zhang <zhangduo@apache.org>
infraio pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
Signed-off-by: Duo Zhang <zhangduo@apache.org>
symat pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit dcc2c4d) Change-Id: I771e7713240700a47a55fdb743efc1e184c51856
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testNull()into multiple,testVersionLimits()- cannot split,testDeletesWithReverseScan()- cannot split