Skip to content

HBASE-26468 Region Server doesn't exit cleanly incase it crashes. - #3866

Merged
virajjasani merged 1 commit into
apache:branch-1from
shahrs87:HBASE-26468-branch-1
Dec 1, 2021
Merged

HBASE-26468 Region Server doesn't exit cleanly incase it crashes.#3866
virajjasani merged 1 commit into
apache:branch-1from
shahrs87:HBASE-26468-branch-1

Conversation

@shahrs87

@shahrs87shahrs87 commented Nov 20, 2021

Copy link
Copy Markdown
Contributor

No description provided.

virajjasani
virajjasani approved these changes Nov 20, 2021
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, pending QA

@virajjasanivirajjasani mentioned this pull request Nov 20, 2021
Merged
@virajjasanivirajjasani added the backport This PR is a back port of some issue or issues already committed to master label Nov 20, 2021
@Apache-HBase

Apache-HBase commented Nov 20, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec8m 3sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+1 💚mvninstall10m 34sbranch-1 passed
+1 💚compile0m 46sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile0m 51sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle1m 56sbranch-1 passed
+1 💚shadedjars4m 23sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 59sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc0m 52sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs3m 38sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs3m 34sbranch-1 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 47sthe patch passed
+1 💚compile0m 57sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac0m 57sthe patch passed
+1 💚compile0m 59sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac0m 59sthe patch passed
+1 💚checkstyle1m 50sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars3m 51spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck6m 8sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 34sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc0m 45sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs3m 15sthe patch passed
_ Other Tests _
-1 ❌unit157m 26shbase-server in the patch failed.
+1 💚asflicense0m 34sThe patch does not generate ASF License warnings.
215m 11s
ReasonTests
Failed junit testshadoop.hbase.replication.TestMasterReplication
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/1/artifact/out/Dockerfile
GITHUB PR#3866
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux bc10bdf61f0e 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3866/out/precommit/personality/provided.sh
git revisionbranch-1 / 0d214ff
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/1/testReport/
Max. process+thread count3970 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/1/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

shahrs87
shahrs87 commented Nov 30, 2021
View reviewed changes
Comment threadhbase-common/src/main/java/org/apache/hadoop/hbase/util/Threads.java
public static boolean isNonDaemonThreadRunning() {
AtomicInteger nonDaemonThreadCount = new AtomicInteger();
Set<Thread> threads = Thread.getAllStackTraces().keySet();
for (Thread t: threads) {

@shahrs87shahrs87Nov 30, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small difference between master patch and branch-1 patch.

  1. Replaced threads.forEach(t -> { with for (Thread t: threads)
  2. Replaced org.apache.commons.logging.Log with org.slf4j.LoggerFactory since the former doesn't allow String formatter.

Cc @virajjasani

@Apache-HBase

Apache-HBase commented Nov 30, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 57sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 33sMaven dependency ordering for branch
+1 💚mvninstall8m 43sbranch-1 passed
+1 💚compile1m 7sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 11sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle2m 4sbranch-1 passed
+1 💚shadedjars3m 12sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 1sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 8sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs2m 47sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 5sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall2m 5sthe patch passed
+1 💚compile1m 4sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 4sthe patch passed
+1 💚compile1m 12sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 12sthe patch passed
-1 ❌checkstyle1m 30shbase-server: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars3m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 3sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 51sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 6sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs4m 9sthe patch passed
_ Other Tests _
+1 💚unit2m 59shbase-common in the patch passed.
+1 💚unit132m 57shbase-server in the patch passed.
+1 💚asflicense0m 58sThe patch does not generate ASF License warnings.
188m 8s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/2/artifact/out/Dockerfile
GITHUB PR#3866
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux b98ea0115e3d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3866/out/precommit/personality/provided.sh
git revisionbranch-1 / 13787ae
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/2/artifact/out/diff-checkstyle-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/2/testReport/
Max. process+thread count4470 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/2/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Dec 1, 2021
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the backport

@virajjasani
virajjasani merged commit 7192423 into apache:branch-1Dec 1, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shahrs87@Apache-HBase@virajjasani