Uh oh!
There was an error while loading. Please reload this page.
HBASE-22642 Make move operations of RSGroup idempotent - #387
Conversation
Apache-HBase
commented
Jul 16, 2019
🎊 +1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
Jul 17, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 20, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 23, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 23, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 23, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 23, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 23, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 25, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 25, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 25, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 25, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 26, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 27, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 27, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 27, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 24, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 24, 2019
🎊 +1 overall
This message was automatically generated. |
saintstack
commented
Aug 25, 2019
Any chance of a new version of the patch addressing review comments @sunhelly ? Thanks. |
Apache-HBase
commented
Aug 25, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 25, 2019
🎊 +1 overall
This message was automatically generated. |
sunhelly
commented
Aug 26, 2019
Thanks @saintstack . I have added comments for the added UTs according to @xcangCRM 's comments. Thanks @xcangCRM for reviewing. |
Apache-HBase
commented
Aug 26, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 26, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 26, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 27, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 27, 2019
🎊 +1 overall
This message was automatically generated. |
| } | ||
| RSGroupInfo srcGrp = new RSGroupInfo(tmpSrcGrp); | ||
| if (srcGrp.getName().equals(targetGroupName)) { | ||
| throw new ConstraintException("Target RSGroup " + targetGroupName + |
There was a problem hiding this comment.
If a table have 10 regions, and only 1 region is on the wrong rsgroup. The move will only move the wrong region and don't move the other 9 regions?
There was a problem hiding this comment.
Yes. It will judge which regions should be moved. Regions in correct group will not be moved in the origin logic.
Apache-HBase
commented
Aug 28, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 28, 2019
🎊 +1 overall
This message was automatically generated. |
sunhelly
commented
Aug 29, 2019
Hi @infraio , is there any other concerns about this PR? Thanks. |
Apache-HBase
commented
Aug 29, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 30, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 30, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 31, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 31, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 1, 2019
🎊 +1 overall
This message was automatically generated. |
Apache9
commented
Sep 1, 2019
Let's finish this? @infraio |
Apache-HBase
commented
Sep 1, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 1, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 2, 2019
🎊 +1 overall
This message was automatically generated. |
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: Guanghao Zhang <zghao@apache.org>
No description provided.