Skip to content

HBASE-26459 HMaster should move non-meta region only if meta is ONLINE - #3875

Merged
virajjasani merged 12 commits into
apache:branch-1from
YutSean:HBASE-26459
Dec 3, 2021
Merged

HBASE-26459 HMaster should move non-meta region only if meta is ONLINE#3875
virajjasani merged 12 commits into
apache:branch-1from
YutSean:HBASE-26459

Conversation

@YutSean

@YutSeanYutSean commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

@Apache-HBase

Apache-HBase commented Nov 23, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌docker10m 20sDocker failed to build yetus/hbase:57dbad11da.
SubsystemReport/Notes
GITHUB PR#3875
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/1/console
versionsgit=2.17.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@shahrs87

shahrs87 commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

@YutSean Can we add some tests ?

@YutSean

YutSean commented Nov 23, 2021

Copy link
Copy Markdown
ContributorAuthor

OK, let me try.

@Apache-HBase

Apache-HBase commented Nov 23, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 12sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 1sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 36sMaven dependency ordering for branch
+1 💚mvninstall9m 27sbranch-1 passed
+1 💚compile1m 20sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 28sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle2m 47sbranch-1 passed
+1 💚shadedjars4m 42sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 18sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 26sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs3m 33sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 12sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall2m 53sthe patch passed
+1 💚compile1m 28sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 28sthe patch passed
+1 💚compile1m 36sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 36sthe patch passed
-1 ❌checkstyle1m 58shbase-server: The patch generated 1 new + 212 unchanged - 0 fixed = 213 total (was 212)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars4m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck6m 30sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc1m 4sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 21sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs5m 27sthe patch passed
_ Other Tests _
+1 💚unit3m 2shbase-common in the patch passed.
-1 ❌unit167m 13shbase-server in the patch failed.
+1 💚asflicense0m 50sThe patch does not generate ASF License warnings.
239m 51s
ReasonTests
Failed junit testshadoop.hbase.master.cleaner.TestSnapshotFromMaster
hadoop.hbase.replication.TestMasterReplication
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/2/artifact/out/Dockerfile
GITHUB PR#3875
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux db9637011fd5 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3875/out/precommit/personality/provided.sh
git revisionbranch-1 / 1701f0d
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/2/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/2/testReport/
Max. process+thread count4147 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/2/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 25, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 29sMaven dependency ordering for branch
+1 💚mvninstall9m 9sbranch-1 passed
+1 💚compile1m 4sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 16sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle2m 24sbranch-1 passed
+1 💚shadedjars3m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 58sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 6sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs3m 1sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 30sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 18sthe patch passed
+1 💚compile1m 7sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 7sthe patch passed
+1 💚compile1m 18sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 18sthe patch passed
-1 ❌checkstyle1m 47shbase-server: The patch generated 3 new + 215 unchanged - 0 fixed = 218 total (was 215)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars3m 23spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 35sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 49sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 6sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs4m 32sthe patch passed
_ Other Tests _
+1 💚unit2m 38shbase-common in the patch passed.
-1 ❌unit152m 24shbase-server in the patch failed.
+1 💚asflicense0m 49sThe patch does not generate ASF License warnings.
210m 23s
ReasonTests
Failed junit testshadoop.hbase.master.TestMaster
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/3/artifact/out/Dockerfile
GITHUB PR#3875
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 08f203e71f52 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3875/out/precommit/personality/provided.sh
git revisionbranch-1 / 13787ae
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/3/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/3/testReport/
Max. process+thread count4042 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/3/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 25, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 39sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 1sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 28sMaven dependency ordering for branch
+1 💚mvninstall8m 31sbranch-1 passed
+1 💚compile1m 14sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 20sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle2m 22sbranch-1 passed
+1 💚shadedjars3m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 4sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 7sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs3m 2sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 24sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall2m 22sthe patch passed
+1 💚compile1m 9sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 9sthe patch passed
+1 💚compile1m 16sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 16sthe patch passed
-1 ❌checkstyle1m 46shbase-server: The patch generated 3 new + 215 unchanged - 0 fixed = 218 total (was 215)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars3m 25spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 31sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 50sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 6sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs4m 36sthe patch passed
_ Other Tests _
+1 💚unit2m 38shbase-common in the patch passed.
-1 ❌unit162m 3shbase-server in the patch failed.
+1 💚asflicense0m 51sThe patch does not generate ASF License warnings.
220m 22s
ReasonTests
Failed junit testshadoop.hbase.replication.TestReplicationSource
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/4/artifact/out/Dockerfile
GITHUB PR#3875
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 31898692cda2 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3875/out/precommit/personality/provided.sh
git revisionbranch-1 / 13787ae
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/4/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/4/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/4/testReport/
Max. process+thread count4129 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/4/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 25, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 5sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 29sMaven dependency ordering for branch
+1 💚mvninstall8m 20sbranch-1 passed
+1 💚compile1m 7sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 15sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle2m 15sbranch-1 passed
+1 💚shadedjars3m 14sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 0sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 6sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs2m 50sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 9sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall2m 9sthe patch passed
+1 💚compile1m 5sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 5sthe patch passed
+1 💚compile1m 15sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 15sthe patch passed
+1 💚checkstyle2m 2sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars2m 59spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 1sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 52sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 7sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs4m 15sthe patch passed
_ Other Tests _
+1 💚unit2m 54shbase-common in the patch passed.
-1 ❌unit168m 49shbase-server in the patch failed.
+1 💚asflicense1m 4sThe patch does not generate ASF License warnings.
223m 56s
ReasonTests
Failed junit testshadoop.hbase.client.TestReplicaWithCluster
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/5/artifact/out/Dockerfile
GITHUB PR#3875
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 5bd85050e156 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3875/out/precommit/personality/provided.sh
git revisionbranch-1 / 13787ae
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/5/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/5/testReport/
Max. process+thread count4449 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/5/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@YutSean

YutSean commented Nov 26, 2021

Copy link
Copy Markdown
ContributorAuthor

The failed UT passed locally. It is a little bit flaky.

virajjasani
virajjasani reviewed Nov 26, 2021
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, thanks @YutSean for the improvement

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Outdated
Comment on lines +1858 to +1860
LOG.info("Moving " + rp + " failed. " +
"While there is still meta regions in transition after " +
timeoutWaitMetaRegionAssignment + "ms waiting.");

@virajjasanivirajjasaniNov 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ERROR log would be better. Also, how about this error message?

LOG.error("This is fail-fast of the region move because hbase:meta region is in transition. Failed region move info: " + rp);

@YutSeanYutSeanNov 26, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. Changed in the latest commit.

Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
Comment threadhbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java Outdated
public static final String HBASE_MASTER_WAITING_META_ASSIGNMENT_TIMEOUT =
"hbase.master.waiting.meta.assignment.timeout";

public static final long HBASE_MASTER_WAITING_META_ASSIGNMENT_TIMEOUT_DEFAULT = 5000;

@virajjasanivirajjasaniNov 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it 10000 (10 s)?

@YutSeanYutSeanNov 26, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if 10s is better. Actually, 5s is my intuition. Have changed in the latest commit. But could you explain the reason to change to 10s a little bit?

@Apache-HBase

Apache-HBase commented Nov 26, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 5sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 30sMaven dependency ordering for branch
+1 💚mvninstall8m 25sbranch-1 passed
+1 💚compile1m 5sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 17sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle2m 12sbranch-1 passed
+1 💚shadedjars3m 15sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 0sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 6sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs3m 14sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 36sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall2m 34sthe patch passed
+1 💚compile1m 20sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 20sthe patch passed
+1 💚compile1m 27sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 27sthe patch passed
+1 💚checkstyle2m 20sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars3m 47spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck6m 10sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 54sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 10sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs4m 26sthe patch passed
_ Other Tests _
+1 💚unit2m 44shbase-common in the patch passed.
-1 ❌unit177m 37shbase-server in the patch failed.
+1 💚asflicense1m 5sThe patch does not generate ASF License warnings.
236m 50s
ReasonTests
Failed junit testshadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
hadoop.hbase.replication.TestReplicationKillSlaveRS
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/6/artifact/out/Dockerfile
GITHUB PR#3875
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 80981ea46991 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3875/out/precommit/personality/provided.sh
git revisionbranch-1 / 13787ae
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/6/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/6/testReport/
Max. process+thread count4739 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/6/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani reviewed Nov 26, 2021
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Outdated
if (assignmentManager.getRegionStates().isMetaRegionInTransition()) {
LOG.error("This is fail-fast of the region move because "
+ "hbase:meta region is in transition. Failed region move info: " + rp);
return;

@virajjasanivirajjasaniNov 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can throw HBaseIOException here since this is fail-fast scenario?

@YutSeanYutSeanNov 29, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, exception could be detected by the client. Have changed to throw exception in the latest commit.

Comment threadhbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
@Apache-HBase

Apache-HBase commented Nov 29, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 39sMaven dependency ordering for branch
+1 💚mvninstall8m 34sbranch-1 passed
+1 💚compile1m 4sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 18sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle2m 22sbranch-1 passed
+1 💚shadedjars3m 31sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 59sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 7sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs3m 3sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 27sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 20sthe patch passed
+1 💚compile1m 5sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 5sthe patch passed
+1 💚compile1m 18sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 18sthe patch passed
+1 💚checkstyle2m 16sthe patch passed
-1 ❌whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚shadedjars3m 20spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 30sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 49sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 7sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs4m 36sthe patch passed
_ Other Tests _
+1 💚unit2m 38shbase-common in the patch passed.
-1 ❌unit154m 8shbase-server in the patch failed.
+1 💚asflicense0m 50sThe patch does not generate ASF License warnings.
211m 37s
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestSplitTransactionOnCluster
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/7/artifact/out/Dockerfile
GITHUB PR#3875
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux c97315e2365c 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3875/out/precommit/personality/provided.sh
git revisionbranch-1 / 13787ae
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/7/artifact/out/whitespace-eol.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/7/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/7/testReport/
Max. process+thread count4127 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/7/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 29, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 26sMaven dependency ordering for branch
+1 💚mvninstall8m 27sbranch-1 passed
+1 💚compile1m 5sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 18sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle2m 23sbranch-1 passed
+1 💚shadedjars3m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 58sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 6sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs3m 1sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 25sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 19sthe patch passed
+1 💚compile1m 5sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 5sthe patch passed
+1 💚compile1m 18sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 18sthe patch passed
+1 💚checkstyle2m 16sthe patch passed
-1 ❌whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚shadedjars3m 23spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 24sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 50sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 7sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs4m 34sthe patch passed
_ Other Tests _
+1 💚unit2m 45shbase-common in the patch passed.
-1 ❌unit187m 12shbase-server in the patch failed.
+1 💚asflicense1m 36sThe patch does not generate ASF License warnings.
245m 24s
ReasonTests
Failed junit testshadoop.hbase.replication.TestReplicationSource
hadoop.hbase.replication.TestReplicationChangingPeerRegionservers
hadoop.hbase.master.TestMasterBalanceThrottling
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/8/artifact/out/Dockerfile
GITHUB PR#3875
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 038b63858be8 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3875/out/precommit/personality/provided.sh
git revisionbranch-1 / 13787ae
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/8/artifact/out/whitespace-eol.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/8/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/8/testReport/
Max. process+thread count4134 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/8/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani reviewed Nov 29, 2021
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Thanks @YutSean. Can you please also take care of the recent whitespace warning?

@YutSean

YutSean commented Nov 29, 2021

Copy link
Copy Markdown
ContributorAuthor

Fixed in the latest commit. Let's see if it is ok this time.

@Apache-HBase

Apache-HBase commented Nov 29, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec8m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 37sMaven dependency ordering for branch
+1 💚mvninstall9m 15sbranch-1 passed
+1 💚compile1m 25sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 42sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle2m 42sbranch-1 passed
+1 💚shadedjars4m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 15sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 19sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs3m 39sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 14sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall2m 46sthe patch passed
+1 💚compile1m 23sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 23sthe patch passed
+1 💚compile1m 31sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 31sthe patch passed
+1 💚checkstyle2m 35sthe patch passed
-1 ❌whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚shadedjars3m 56spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck6m 17sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc1m 5sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 19sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs5m 29sthe patch passed
_ Other Tests _
+1 💚unit3m 11shbase-common in the patch passed.
-1 ❌unit184m 31shbase-server in the patch failed.
+1 💚asflicense0m 56sThe patch does not generate ASF License warnings.
258m 28s
ReasonTests
Failed junit testshadoop.hbase.mapreduce.TestLoadIncrementalHFiles
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/9/artifact/out/Dockerfile
GITHUB PR#3875
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux be70a2487666 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3875/out/precommit/personality/provided.sh
git revisionbranch-1 / 13787ae
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/9/artifact/out/whitespace-eol.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/9/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/9/testReport/
Max. process+thread count4393 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/9/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 30, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 38sMaven dependency ordering for branch
+1 💚mvninstall9m 55sbranch-1 passed
+1 💚compile1m 6sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 17sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle2m 32sbranch-1 passed
+1 💚shadedjars3m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 1sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 7sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs3m 1sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 39sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 21sthe patch passed
+1 💚compile1m 4sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 4sthe patch passed
+1 💚compile1m 18sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 18sthe patch passed
+1 💚checkstyle2m 16sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars3m 22spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 32sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 50sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 7sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs4m 34sthe patch passed
_ Other Tests _
+1 💚unit2m 50shbase-common in the patch passed.
-1 ❌unit153m 9shbase-server in the patch failed.
+1 💚asflicense0m 49sThe patch does not generate ASF License warnings.
212m 37s
ReasonTests
Failed junit testshadoop.hbase.security.visibility.TestVisibilityLabelsWithACL
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/10/artifact/out/Dockerfile
GITHUB PR#3875
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 79c37618cfe1 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3875/out/precommit/personality/provided.sh
git revisionbranch-1 / 13787ae
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/10/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/10/testReport/
Max. process+thread count4203 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/10/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani reviewed Dec 3, 2021
View reviewed changes
Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
@Apache-HBase

Apache-HBase commented Dec 3, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec7m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 28sMaven dependency ordering for branch
+1 💚mvninstall8m 36sbranch-1 passed
+1 💚compile1m 5sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 17sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle2m 24sbranch-1 passed
+1 💚shadedjars3m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 7sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs3m 1sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 25sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 19sthe patch passed
+1 💚compile1m 6sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 6sthe patch passed
+1 💚compile1m 14sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 14sthe patch passed
+1 💚checkstyle2m 15sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars3m 20spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 28sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 50sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 6sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs4m 36sthe patch passed
_ Other Tests _
+1 💚unit2m 38shbase-common in the patch passed.
-1 ❌unit150m 21shbase-server in the patch failed.
+1 💚asflicense0m 49sThe patch does not generate ASF License warnings.
214m 18s
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestSplitTransactionOnCluster
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/11/artifact/out/Dockerfile
GITHUB PR#3875
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux d7ede1c57347 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3875/out/precommit/personality/provided.sh
git revisionbranch-1 / 7192423
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/11/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/11/testReport/
Max. process+thread count4215 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3875/11/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Dec 3, 2021
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
@virajjasani
virajjasani merged commit c472329 into apache:branch-1Dec 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YutSean@Apache-HBase@shahrs87@virajjasani