HBASE-26530 Backport HBASE-26524 Support remove coprocessor by class … by taklwu · Pull Request #3908 · apache/hbase

taklwu · 2021-12-02T00:15:35Z

…name via alter table command

we need one line from HBASE-24874 for setting
up constant CLASSNAME

original commit 19b0b2e

…name via alter table command we need one line from HBASE-24874 for setting up constant CLASSNAME original commit 19b0b2e

Apache-HBase · 2021-12-02T00:56:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 53s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 53s	branch-2 passed
+1 💚	compile	1m 36s	branch-2 passed
+1 💚	checkstyle	0m 47s	branch-2 passed
+1 💚	spotbugs	1m 16s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 32s	the patch passed
+1 💚	compile	1m 30s	the patch passed
+1 💚	javac	1m 30s	the patch passed
+1 💚	checkstyle	0m 49s	the patch passed
-0 ⚠️	rubocop	0m 21s	The patch generated 23 new + 620 unchanged - 5 fixed = 643 total (was 625)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 53s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	1m 25s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		40m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3908
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop
uname	Linux c4edc2813c6e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `d1c68a2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-client hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-02T00:57:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 7s	branch-2 passed
+1 💚	compile	0m 50s	branch-2 passed
+1 💚	shadedjars	7m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 1s	the patch passed
+1 💚	compile	0m 49s	the patch passed
+1 💚	javac	0m 49s	the patch passed
+1 💚	shadedjars	7m 3s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 14s	hbase-client in the patch passed.
+1 💚	unit	9m 0s	hbase-shell in the patch passed.
		40m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3908
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8c6494d6489c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `d1c68a2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/1/testReport/
Max. process+thread count	1549 (vs. ulimit of 12500)
modules	C: hbase-client hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-02T00:58:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 52s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 40s	branch-2 passed
+1 💚	compile	0m 58s	branch-2 passed
+1 💚	shadedjars	7m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 50s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 27s	the patch passed
+1 💚	compile	0m 55s	the patch passed
+1 💚	javac	0m 55s	the patch passed
+1 💚	shadedjars	7m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 51s	hbase-client in the patch passed.
+1 💚	unit	6m 55s	hbase-shell in the patch passed.
		41m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3908
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 50ce652f2d03 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `d1c68a2`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/1/testReport/
Max. process+thread count	2438 (vs. ulimit of 12500)
modules	C: hbase-client hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-02T23:39:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 31s	branch-2 passed
+1 💚	compile	4m 40s	branch-2 passed
+1 💚	checkstyle	1m 52s	branch-2 passed
+1 💚	spotbugs	3m 14s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 27s	the patch passed
+1 💚	compile	4m 40s	the patch passed
+1 💚	javac	4m 40s	the patch passed
+1 💚	checkstyle	1m 51s	the patch passed
-0 ⚠️	rubocop	0m 19s	The patch generated 23 new + 620 unchanged - 5 fixed = 643 total (was 625)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 29s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	3m 38s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 39s	The patch does not generate ASF License warnings.
		49m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3908
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop
uname	Linux 7e3fad7167a1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `d1c68a2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-03T02:05:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 21s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 52s	branch-2 passed
+1 💚	compile	2m 13s	branch-2 passed
+1 💚	shadedjars	7m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 29s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 27s	the patch passed
+1 💚	compile	2m 7s	the patch passed
+1 💚	javac	2m 7s	the patch passed
+1 💚	shadedjars	7m 47s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 51s	hbase-client in the patch passed.
+1 💚	unit	148m 8s	hbase-server in the patch passed.
+1 💚	unit	8m 34s	hbase-shell in the patch passed.
		195m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3908
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 56cf7b990c31 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `d1c68a2`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/2/testReport/
Max. process+thread count	3500 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-03T03:08:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 9s	branch-2 passed
+1 💚	compile	1m 48s	branch-2 passed
+1 💚	shadedjars	7m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 16s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 52s	the patch passed
+1 💚	compile	1m 51s	the patch passed
+1 💚	javac	1m 51s	the patch passed
+1 💚	shadedjars	7m 5s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 18s	hbase-client in the patch passed.
+1 💚	unit	213m 52s	hbase-server in the patch passed.
+1 💚	unit	9m 9s	hbase-shell in the patch passed.
		258m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3908
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f60154ef0800 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `d1c68a2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/2/testReport/
Max. process+thread count	2652 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

taklwu · 2021-12-06T17:17:31Z

As mentioned in HBASE-26524, this is an incompatible change from the client API of TableDescriptorBuilder#removeCoprocessor (inside the package, only consumer is Constraints#disable when it tries to remove/disable ConstraintProcessor). If we should not have this incompatible change in branch-2, we could remove the IllegalArgumentException here and have a different behavior from master branch.

what do you think?

ndimiduk · 2021-12-08T19:14:57Z

From our guidelines,

Given a version number MAJOR.MINOR.PATCH, increment the:
MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards-compatible manner, and ...

So, this is not appropriate for branch-2 without full backwards-compatibility.

Apache-HBase · 2021-12-08T22:08:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 47s	branch-2 passed
+1 💚	compile	4m 45s	branch-2 passed
+1 💚	checkstyle	1m 52s	branch-2 passed
+1 💚	spotbugs	3m 15s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 31s	the patch passed
-1 ❌	compile	1m 2s	hbase-client in the patch failed.
-0 ⚠️	javac	1m 2s	hbase-client in the patch failed.
+1 💚	checkstyle	1m 51s	the patch passed
-0 ⚠️	rubocop	0m 18s	The patch generated 23 new + 620 unchanged - 5 fixed = 643 total (was 625)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 32s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	3m 37s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 40s	The patch does not generate ASF License warnings.
		50m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3908
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop
uname	Linux 5361db57b686 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `140b5d8`
Default Java	AdoptOpenJDK-1.8.0_282-b08
compile	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/3/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/3/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-09T01:34:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 2s	branch-2 passed
+1 💚	compile	2m 8s	branch-2 passed
+1 💚	shadedjars	8m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 28s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 48s	the patch passed
+1 💚	compile	2m 9s	the patch passed
+1 💚	javac	2m 9s	the patch passed
+1 💚	shadedjars	7m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 56s	hbase-client in the patch passed.
+1 💚	unit	203m 38s	hbase-server in the patch passed.
+1 💚	unit	7m 13s	hbase-shell in the patch passed.
		255m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3908
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 010c05ce9c6f 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `140b5d8`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/3/testReport/
Max. process+thread count	2710 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-09T01:39:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 33s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 59s	branch-2 passed
+1 💚	compile	1m 49s	branch-2 passed
+1 💚	shadedjars	7m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 14s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 54s	the patch passed
+1 💚	compile	1m 52s	the patch passed
+1 💚	javac	1m 52s	the patch passed
+1 💚	shadedjars	7m 5s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 12s	hbase-client in the patch passed.
+1 💚	unit	216m 2s	hbase-server in the patch passed.
+1 💚	unit	9m 32s	hbase-shell in the patch passed.
		260m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3908
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ea14f5b8c00f 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `140b5d8`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/3/testReport/
Max. process+thread count	2821 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-09T02:32:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 44s	branch-2 passed
+1 💚	compile	4m 49s	branch-2 passed
+1 💚	checkstyle	1m 48s	branch-2 passed
+1 💚	spotbugs	3m 16s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 29s	the patch passed
+1 💚	compile	4m 53s	the patch passed
+1 💚	javac	4m 53s	the patch passed
+1 💚	checkstyle	2m 1s	the patch passed
-0 ⚠️	rubocop	0m 21s	The patch generated 23 new + 620 unchanged - 5 fixed = 643 total (was 625)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 31s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	3m 36s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 39s	The patch does not generate ASF License warnings.
		51m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3908
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop
uname	Linux 180edecc5b38 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `b1bc5f3`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-09T05:52:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 1s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 4s	branch-2 passed
+1 💚	compile	2m 10s	branch-2 passed
+1 💚	shadedjars	8m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 26s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 48s	the patch passed
+1 💚	compile	2m 9s	the patch passed
+1 💚	javac	2m 9s	the patch passed
+1 💚	shadedjars	7m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 51s	hbase-client in the patch passed.
+1 💚	unit	203m 48s	hbase-server in the patch passed.
+1 💚	unit	7m 4s	hbase-shell in the patch passed.
		250m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3908
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4d82c954d5e0 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `b1bc5f3`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/4/testReport/
Max. process+thread count	2910 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-09T06:53:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 28s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 44s	branch-2 passed
+1 💚	compile	2m 30s	branch-2 passed
+1 💚	shadedjars	8m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 45s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 14s	the patch passed
+1 💚	compile	2m 26s	the patch passed
+1 💚	javac	2m 26s	the patch passed
+1 💚	shadedjars	8m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 23s	hbase-client in the patch passed.
+1 💚	unit	257m 26s	hbase-server in the patch passed.
+1 💚	unit	7m 29s	hbase-shell in the patch passed.
		310m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3908
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ca1dbbefd313 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `b1bc5f3`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/4/testReport/
Max. process+thread count	2612 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3908/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ankitsinghal

+1, Looks good to me.

…name via alter table command (#3908) Signed-off-by: Ankit Singhal <ankit@apache.org>

…name via alter table command (apache#3908) Signed-off-by: Ankit Singhal <ankit@apache.org> (cherry picked from commit bf6f946) Ref: CDPD-31683 Support remove table coprocessor by java class name Change-Id: If183fe6a5a1b59bfd6f60ad6bda5caf288ee1930

HBASE-26530 Backport HBASE-26524 Support remove coprocessor by class …
72c320d
…name via alter table command we need one line from HBASE-24874 for setting up constant CLASSNAME original commit 19b0b2e

taklwu requested review from ndimiduk and wchevreuil December 2, 2021 00:15

Backport HBASE-26524 Addendum fix TestConstraints
52c68ae

taklwu requested a review from Apache9 December 3, 2021 17:48

taklwu requested review from apurtell, joshelser and petersomogyi December 6, 2021 22:20

ndimiduk reviewed Dec 8, 2021
View reviewed changes

Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java Outdated

keep branch-2 compatible without IllegalArgumentException
6e2bdac

taklwu requested a review from ndimiduk December 8, 2021 21:18

fix a missing@testannotations
e943488

ankitsinghal approved these changes Dec 9, 2021
View reviewed changes

taklwu merged commit bf6f946 into apache:branch-2Dec 10, 2021

asfgit pushed a commit that referenced this pull request Dec 14, 2021
HBASE-26530BackportHBASE-26524Support remove coprocessor by class …
bbdc840
…name via alter table command (#3908) Signed-off-by: Ankit Singhal <ankit@apache.org>

Uh oh!

Conversation

taklwu commented Dec 2, 2021

Uh oh!

Apache-HBase commented Dec 2, 2021

Uh oh!

Apache-HBase commented Dec 2, 2021

Uh oh!

Apache-HBase commented Dec 2, 2021

Uh oh!

Apache-HBase commented Dec 2, 2021

Uh oh!

Apache-HBase commented Dec 3, 2021

Uh oh!

Apache-HBase commented Dec 3, 2021

Uh oh!

taklwu commented Dec 6, 2021

Uh oh!

ndimiduk commented Dec 8, 2021

Uh oh!

Uh oh!

Apache-HBase commented Dec 8, 2021

Uh oh!

Apache-HBase commented Dec 9, 2021

Uh oh!

Apache-HBase commented Dec 9, 2021

Uh oh!

Apache-HBase commented Dec 9, 2021

Uh oh!

Apache-HBase commented Dec 9, 2021

Uh oh!

Apache-HBase commented Dec 9, 2021

Uh oh!

ankitsinghal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants