Skip to content

HBASE-26537: Make HBASE-15676 backwards compatible, using a flag on the proto - #3916

Merged
apurtell merged 2 commits into
apache:branch-1from
HubSpot:HBASE-26537
Dec 13, 2021
Merged

HBASE-26537: Make HBASE-15676 backwards compatible, using a flag on the proto#3916
apurtell merged 2 commits into
apache:branch-1from
HubSpot:HBASE-26537

Conversation

@bbeaudreault

Copy link
Copy Markdown
Contributor

This adds a new proto field to FuzzyRowFilter proto to aid in providing a compatibility path for pre-HBASE-15676 clients. Users would need to roll this out to their server side first, then roll out to their clients. At which point they are safe to upgrade beyond 1.x.

This brings back support for the old v1 mask from pre-15676. If the new isMaskV2 field is empty/false, we use the old mask. If present and true, we use the new mask which is used in later versions of hbase.

I updated all of the tests in TestFuzzyRowFilterEndToEnd to test with both the v1 and v2 masks. You'll note that testAllFixedBits() (the test added in 15676) matches all rows in the table when using the v1 mask. This is the bug that jira fixed.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 31sMaven dependency ordering for branch
+1 💚mvninstall8m 29sbranch-1 passed
+1 💚compile1m 38sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 47sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle5m 22sbranch-1 passed
+1 💚shadedjars3m 34sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 14sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 24sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs2m 57sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs7m 4sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 22sthe patch passed
+1 💚compile1m 35sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚cc1m 35sthe patch passed
+1 💚javac1m 35sthe patch passed
+1 💚compile1m 45sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚cc1m 45sthe patch passed
+1 💚javac1m 45sthe patch passed
-1 ❌checkstyle0m 36shbase-client: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)
-1 ❌checkstyle1m 43shbase-server: The patch generated 3 new + 18 unchanged - 0 fixed = 21 total (was 18)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars3m 22spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 34sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
-1 ❌hbaseprotoc0m 12shbase-protocol in the patch failed.
-1 ❌hbaseprotoc0m 39shbase-server in the patch failed.
+1 💚javadoc1m 2sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 22sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs7m 35sthe patch passed
_ Other Tests _
+1 💚unit0m 30shbase-protocol in the patch passed.
+1 💚unit2m 40shbase-client in the patch passed.
-1 ❌unit154m 35shbase-server in the patch failed.
+1 💚asflicense1m 11sThe patch does not generate ASF License warnings.
229m 29s
ReasonTests
Failed junit testshadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/1/artifact/out/Dockerfile
GITHUB PR#3916
JIRA IssueHBASE-26537
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux a0f4103d165b 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3916/out/precommit/personality/provided.sh
git revisionbranch-1 / 7192423
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/1/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/1/artifact/out/diff-checkstyle-hbase-server.txt
hbaseprotochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/1/artifact/out/patch-hbaseprotoc-hbase-protocol.txt
hbaseprotochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/1/artifact/out/patch-hbaseprotoc-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/1/testReport/
Max. process+thread count4983 (vs. ulimit of 10000)
modulesC: hbase-protocol hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/1/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 15sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 29sMaven dependency ordering for branch
+1 💚mvninstall8m 52sbranch-1 passed
+1 💚compile1m 35sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 45sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle5m 25sbranch-1 passed
+1 💚shadedjars3m 37sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 16sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 23sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs2m 59sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs7m 8sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 19sthe patch passed
+1 💚compile1m 36sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚cc1m 36sthe patch passed
+1 💚javac1m 36sthe patch passed
+1 💚compile1m 46sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚cc1m 46sthe patch passed
+1 💚javac1m 46sthe patch passed
-1 ❌checkstyle0m 38shbase-client: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)
-1 ❌checkstyle1m 41shbase-server: The patch generated 3 new + 18 unchanged - 0 fixed = 21 total (was 18)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars3m 24spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 35sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
-1 ❌hbaseprotoc0m 11shbase-protocol in the patch failed.
-1 ❌hbaseprotoc0m 40shbase-server in the patch failed.
+1 💚javadoc1m 2sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 23sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs7m 30sthe patch passed
_ Other Tests _
+1 💚unit0m 29shbase-protocol in the patch passed.
+1 💚unit2m 41shbase-client in the patch passed.
-1 ❌unit153m 47shbase-server in the patch failed.
+1 💚asflicense1m 12sThe patch does not generate ASF License warnings.
229m 13s
ReasonTests
Failed junit testshadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/2/artifact/out/Dockerfile
GITHUB PR#3916
JIRA IssueHBASE-26537
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 8cc2084aef11 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3916/out/precommit/personality/provided.sh
git revisionbranch-1 / c472329
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/2/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/2/artifact/out/diff-checkstyle-hbase-server.txt
hbaseprotochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/2/artifact/out/patch-hbaseprotoc-hbase-protocol.txt
hbaseprotochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/2/artifact/out/patch-hbaseprotoc-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/2/testReport/
Max. process+thread count5193 (vs. ulimit of 10000)
modulesC: hbase-protocol hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/2/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec8m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 1sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 23sMaven dependency ordering for branch
+1 💚mvninstall8m 26sbranch-1 passed
+1 💚compile1m 33sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 44sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle5m 27sbranch-1 passed
+1 💚shadedjars3m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 13sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 21sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs2m 58sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs7m 5sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 19sthe patch passed
+1 💚compile1m 33sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚cc1m 33sthe patch passed
+1 💚javac1m 33sthe patch passed
+1 💚compile1m 43sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚cc1m 43sthe patch passed
+1 💚javac1m 43sthe patch passed
-1 ❌checkstyle0m 37shbase-client: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)
-1 ❌checkstyle1m 41shbase-server: The patch generated 3 new + 18 unchanged - 0 fixed = 21 total (was 18)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars3m 26spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 30sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
-1 ❌hbaseprotoc0m 11shbase-protocol in the patch failed.
-1 ❌hbaseprotoc0m 40shbase-server in the patch failed.
+1 💚javadoc1m 1sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 22sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs7m 33sthe patch passed
_ Other Tests _
+1 💚unit0m 29shbase-protocol in the patch passed.
+1 💚unit2m 41shbase-client in the patch passed.
-1 ❌unit154m 41shbase-server in the patch failed.
+1 💚asflicense1m 10sThe patch does not generate ASF License warnings.
235m 46s
ReasonTests
Failed junit testshadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/3/artifact/out/Dockerfile
GITHUB PR#3916
JIRA IssueHBASE-26537
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux a907f9db2b25 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3916/out/precommit/personality/provided.sh
git revisionbranch-1 / 8d96fc3
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/3/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/3/artifact/out/diff-checkstyle-hbase-server.txt
hbaseprotochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/3/artifact/out/patch-hbaseprotoc-hbase-protocol.txt
hbaseprotochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/3/artifact/out/patch-hbaseprotoc-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/3/testReport/
Max. process+thread count5021 (vs. ulimit of 10000)
modulesC: hbase-protocol hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/3/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

Test failures look unrelated, maybe timeout related. The hbaseprotoc failures look related to the build environment -- wrong version of protoc available. I pushed a fix for checkstyle errors.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 27sMaven dependency ordering for branch
+1 💚mvninstall8m 33sbranch-1 passed
+1 💚compile1m 33sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 44sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle5m 20sbranch-1 passed
+1 💚shadedjars3m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 12sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 20sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗spotbugs2m 57sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs7m 5sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 18sthe patch passed
+1 💚compile1m 33sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚cc1m 33sthe patch passed
+1 💚javac1m 33sthe patch passed
+1 💚compile1m 44sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚cc1m 44sthe patch passed
+1 💚javac1m 44sthe patch passed
+1 💚checkstyle5m 13sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars3m 24spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 28sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
-1 ❌hbaseprotoc0m 11shbase-protocol in the patch failed.
-1 ❌hbaseprotoc0m 40shbase-server in the patch failed.
+1 💚javadoc1m 1sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 21sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚findbugs7m 29sthe patch passed
_ Other Tests _
+1 💚unit0m 29shbase-protocol in the patch passed.
+1 💚unit2m 42shbase-client in the patch passed.
-1 ❌unit158m 59shbase-server in the patch failed.
+1 💚asflicense1m 3sThe patch does not generate ASF License warnings.
232m 48s
ReasonTests
Failed junit testshadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/4/artifact/out/Dockerfile
GITHUB PR#3916
JIRA IssueHBASE-26537
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 6af5f0572efd 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3916/out/precommit/personality/provided.sh
git revisionbranch-1 / 8d96fc3
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
hbaseprotochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/4/artifact/out/patch-hbaseprotoc-hbase-protocol.txt
hbaseprotochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/4/artifact/out/patch-hbaseprotoc-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/4/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/4/testReport/
Max. process+thread count4964 (vs. ulimit of 10000)
modulesC: hbase-protocol hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3916/4/console
versionsgit=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtellapurtell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened to our precommit environment but for sure the protoc failures are due to the wrong version being supplied by the environment (in PATH) for a 1.x build.

@apurtell

Copy link
Copy Markdown
Contributor

I plan to merge tomorrow unless objection.

@apurtell
apurtell merged commit 1d1b52c into apache:branch-1Dec 13, 2021
@charlesconnell
charlesconnell deleted the HBASE-26537 branch September 19, 2025 15:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bbeaudreault@Apache-HBase@apurtell