Skip to content

HBASE-26537: Make HBASE-15676 backwards compatible, using a flag on the proto - #3931

Merged
apurtell merged 2 commits into
apache:branch-2from
HubSpot:HBASE-26537-2
Dec 13, 2021
Merged

HBASE-26537: Make HBASE-15676 backwards compatible, using a flag on the proto#3931
apurtell merged 2 commits into
apache:branch-2from
HubSpot:HBASE-26537-2

Conversation

@bbeaudreault

@bbeaudreaultbbeaudreault commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Apache-HBase commented Dec 9, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall3m 56sbranch-2 passed
+1 💚compile5m 57sbranch-2 passed
+1 💚checkstyle2m 0sbranch-2 passed
+1 💚spotbugs6m 29sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 34sthe patch passed
+1 💚compile5m 34sthe patch passed
+1 💚cc5m 34sthe patch passed
+1 💚javac5m 34sthe patch passed
-0 ⚠️checkstyle0m 38shbase-client: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)
-0 ⚠️checkstyle1m 12shbase-server: The patch generated 3 new + 13 unchanged - 0 fixed = 16 total (was 13)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 16sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc2m 3sthe patch passed
+1 💚spotbugs7m 7sthe patch passed
_ Other Tests _
+1 💚asflicense0m 42sThe patch does not generate ASF License warnings.
62m 42s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3931
JIRA IssueHBASE-26537
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux a7c275c9ba8f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b1bc5f3
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 10, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 59sbranch-2 passed
+1 💚compile2m 42sbranch-2 passed
+1 💚shadedjars8m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 25sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall4m 44sthe patch passed
+1 💚compile2m 43sthe patch passed
+1 💚javac2m 43sthe patch passed
+1 💚shadedjars7m 59spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 22sthe patch passed
_ Other Tests _
+1 💚unit0m 57shbase-protocol-shaded in the patch passed.
+1 💚unit3m 6shbase-client in the patch passed.
+1 💚unit208m 44shbase-server in the patch passed.
251m 3s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3931
JIRA IssueHBASE-26537
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d61107980e9f 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b1bc5f3
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/1/testReport/
Max. process+thread count3040 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 10, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 3sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for branch
+1 💚mvninstall6m 3sbranch-2 passed
+1 💚compile3m 21sbranch-2 passed
+1 💚shadedjars9m 31sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 5sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall5m 22sthe patch passed
+1 💚compile2m 57sthe patch passed
+1 💚javac2m 57sthe patch passed
+1 💚shadedjars8m 42spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 40sthe patch passed
_ Other Tests _
+1 💚unit0m 54shbase-protocol-shaded in the patch passed.
+1 💚unit3m 8shbase-client in the patch passed.
-1 ❌unit226m 52shbase-server in the patch failed.
276m 15s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3931
JIRA IssueHBASE-26537
Optional Testsjavac javadoc unit shadedjars compile
unameLinux adee66540a83 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b1bc5f3
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/1/testReport/
Max. process+thread count2562 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault

bbeaudreault commented Dec 10, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

The one test failure looks like an unrelated flake/timeout. I just pushed a commit to fix checkstyle

@Apache-HBase

Apache-HBase commented Dec 10, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 23sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 19sbranch-2 passed
+1 💚compile5m 49sbranch-2 passed
+1 💚checkstyle1m 59sbranch-2 passed
+1 💚spotbugs6m 18sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 56sthe patch passed
+1 💚compile5m 43sthe patch passed
+1 💚cc5m 43sthe patch passed
+1 💚javac5m 43sthe patch passed
+1 💚checkstyle1m 58sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 54sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc1m 57sthe patch passed
+1 💚spotbugs6m 50sthe patch passed
_ Other Tests _
+1 💚asflicense0m 34sThe patch does not generate ASF License warnings.
64m 1s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3931
JIRA IssueHBASE-26537
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 7bcd3ac09721 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 26e37bc
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count86 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 10, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 35sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall5m 3sbranch-2 passed
+1 💚compile2m 42sbranch-2 passed
+1 💚shadedjars8m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 24sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 46sthe patch passed
+1 💚compile2m 43sthe patch passed
+1 💚javac2m 43sthe patch passed
+1 💚shadedjars8m 0spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 23sthe patch passed
_ Other Tests _
+1 💚unit0m 58shbase-protocol-shaded in the patch passed.
+1 💚unit3m 10shbase-client in the patch passed.
+1 💚unit205m 0shbase-server in the patch passed.
248m 36s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3931
JIRA IssueHBASE-26537
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b4acc8bc3688 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 26e37bc
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/2/testReport/
Max. process+thread count3009 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 10, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 14sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 8sbranch-2 passed
+1 💚compile2m 9sbranch-2 passed
+1 💚shadedjars7m 5sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 17sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 58sthe patch passed
+1 💚compile2m 10sthe patch passed
+1 💚javac2m 10sthe patch passed
+1 💚shadedjars7m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 13sthe patch passed
_ Other Tests _
+1 💚unit0m 42shbase-protocol-shaded in the patch passed.
+1 💚unit2m 51shbase-client in the patch passed.
+1 💚unit218m 42shbase-server in the patch passed.
260m 7s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3931
JIRA IssueHBASE-26537
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 18c6cb398e28 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 26e37bc
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/2/testReport/
Max. process+thread count2411 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3931/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault

bbeaudreault commented Dec 10, 2021

Copy link
Copy Markdown
ContributorAuthor

All checks are now passing here, and no checkstyle issues. Should be ready for merge whenever.

The branch-1 PR (#3916) is doing a little less better, but all of the remaining failures there seem related to build environment and/or unrelated flakey tests.

@apurtell

apurtell commented Dec 11, 2021

Copy link
Copy Markdown
Contributor

I plan to merge this and #3916 tomorrow unless objection.

@apurtell
apurtell merged commit ef48a69 into apache:branch-2Dec 13, 2021
asfgit pushed a commit that referenced this pull request Dec 13, 2021
@bbeaudreault@apurtell
HBASE-26537: MakeHBASE-15676backwards compatible, using a flag on t…
9cf0af6
…he proto (#3931)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
asfgit pushed a commit that referenced this pull request Mar 14, 2022
@bbeaudreault@apurtell
HBASE-26603Cherry pickHBASE-26537to branch-2.4
cdda96f
HBASE-26537: Make HBASE-15676 backwards compatible, using a flag on the proto (#3931)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@bbeaudreault@apurtell
HBASE-26603 Cherry pick HBASE-26537 to branch-2.4
ba2a734
HBASE-26537: Make HBASE-15676 backwards compatible, using a flag on the proto (apache#3931)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit cdda96f)
Change-Id: I3edc419f10ad2e3d7211710c18c9cca1a07a7587
@charlesconnell
charlesconnell deleted the HBASE-26537-2 branch September 19, 2025 15:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apurtellapurtellapurtell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bbeaudreault@Apache-HBase@apurtell