Skip to content

HBASE-26462 Should persist restoreAcl flag in the procedure state for CloneSnapshotProcedure and RestoreSnapshotProcedure - #3921

Merged
Apache9 merged 2 commits into
apache:masterfrom
2005hithlj:HBASE-26462
Dec 6, 2021
Merged

HBASE-26462 Should persist restoreAcl flag in the procedure state for CloneSnapshotProcedure and RestoreSnapshotProcedure#3921
Apache9 merged 2 commits into
apache:masterfrom
2005hithlj:HBASE-26462

Conversation

@2005hithlj

@2005hithlj2005hithlj commented Dec 5, 2021

Copy link
Copy Markdown
Contributor

heliangjun
HBASE-26462 Should persist restoreAcl flag in the procedure state for…
ff62798
… CloneSnapshotProcedure and RestoreSnapshotProcedure
@Apache-HBase

Apache-HBase commented Dec 5, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 3smaster passed
+1 💚compile4m 42smaster passed
+1 💚checkstyle1m 16smaster passed
+1 💚spotbugs6m 8smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 49sthe patch passed
+1 💚compile4m 41sthe patch passed
+1 💚cc4m 41sthe patch passed
+1 💚javac4m 41sthe patch passed
+1 💚checkstyle1m 15sthe patch passed
-0 ⚠️whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚hadoopcheck19m 31sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚hbaseprotoc1m 43sthe patch passed
+1 💚spotbugs6m 23sthe patch passed
_ Other Tests _
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
63m 24s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3921
Optional Testsdupname asflicense cc hbaseprotoc prototool javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 1bc50771ac77 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dcd622d
Default JavaAdoptOpenJDK-1.8.0_282-b08
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 5, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 55sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 40smaster passed
+1 💚compile2m 13smaster passed
+1 💚shadedjars8m 24sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall4m 28sthe patch passed
+1 💚compile2m 12sthe patch passed
+1 💚javac2m 12sthe patch passed
+1 💚shadedjars8m 15spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 56sthe patch passed
_ Other Tests _
+1 💚unit0m 59shbase-protocol-shaded in the patch passed.
+1 💚unit141m 9shbase-server in the patch passed.
181m 2s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3921
Optional Testsunit javac javadoc shadedjars compile
unameLinux 12485cab12ec 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dcd622d
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/testReport/
Max. process+thread count4634 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 5, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 52sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 29smaster passed
+1 💚compile1m 54smaster passed
+1 💚shadedjars9m 5sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 51smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 38sthe patch passed
+1 💚compile2m 17sthe patch passed
+1 💚javac2m 17sthe patch passed
+1 💚shadedjars10m 9spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 55sthe patch passed
_ Other Tests _
+1 💚unit0m 51shbase-protocol-shaded in the patch passed.
+1 💚unit228m 36shbase-server in the patch passed.
273m 22s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3921
Optional Testsunit javac javadoc shadedjars compile
unameLinux e1db9722097f 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dcd622d
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/testReport/
Max. process+thread count2787 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 reviewed Dec 6, 2021
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Please fix the minor nits and also the whitespace issues.

Thanks.

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloneSnapshotProcedure.java
Comment thread...-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java
@carp84
carp84 self-requested a review December 6, 2021 04:49
carp84
carp84 approved these changes Dec 6, 2021
View reviewed changes

@carp84carp84 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @2005hithlj . The latest changes LGTM. Let's see what the pre-commit robot says.

@Apache-HBase

Apache-HBase commented Dec 6, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 1smaster passed
+1 💚compile4m 46smaster passed
+1 💚checkstyle1m 16smaster passed
+1 💚spotbugs6m 2smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 48sthe patch passed
+1 💚compile4m 37sthe patch passed
+1 💚cc4m 37sthe patch passed
+1 💚javac4m 37sthe patch passed
+1 💚checkstyle1m 13sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck19m 18sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚hbaseprotoc1m 41sthe patch passed
+1 💚spotbugs6m 32sthe patch passed
_ Other Tests _
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
63m 3s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3921
Optional Testsdupname asflicense cc hbaseprotoc prototool javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 9367fec04bb2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dcd622d
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 6, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 11smaster passed
+1 💚compile1m 55smaster passed
+1 💚shadedjars8m 43sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 52smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 0sthe patch passed
+1 💚compile1m 46sthe patch passed
+1 💚javac1m 46sthe patch passed
+1 💚shadedjars8m 33spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 52sthe patch passed
_ Other Tests _
+1 💚unit0m 49shbase-protocol-shaded in the patch passed.
+1 💚unit148m 12shbase-server in the patch passed.
183m 18s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3921
Optional Testsunit javac javadoc shadedjars compile
unameLinux 7751904e3a27 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dcd622d
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/testReport/
Max. process+thread count4488 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 6, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 17sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall5m 14smaster passed
+1 💚compile2m 22smaster passed
+1 💚shadedjars9m 9sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall5m 4sthe patch passed
+1 💚compile2m 22sthe patch passed
+1 💚javac2m 22sthe patch passed
+1 💚shadedjars9m 19spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 56sthe patch passed
_ Other Tests _
+1 💚unit1m 5shbase-protocol-shaded in the patch passed.
-1 ❌unit206m 50shbase-server in the patch failed.
247m 4s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3921
Optional Testsunit javac javadoc shadedjars compile
unameLinux d4b7d2cce171 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / dcd622d
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/testReport/
Max. process+thread count3299 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@2005hithlj

2005hithlj commented Dec 6, 2021

Copy link
Copy Markdown
ContributorAuthor

Hi, @Apache9 , the UT TestProcedureAdmin#testGetProcedure failed. This UT does not seem to have anything to do with my modification, and in my HBase compile environment, it can be executed successfully. Is this an unstable UT?

@Apache9

Apache9 commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

The UT itself passed in the second run, seems the problem is that the JVM crashed, not sure what is the problem, maybe by OOM killer?

Anyway, let's merge this PR.

@Apache9
Apache9 merged commit 9cf224d into apache:masterDec 6, 2021
Apache9 pushed a commit that referenced this pull request Dec 6, 2021
@2005hithlj@Apache9
HBASE-26462Should persist restoreAcl flag in the procedure state for…
e766dd7
… CloneSnapshotProcedure and RestoreSnapshotProcedure (#3921)
Signed-off-by: Yu Li <liyu@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Dec 6, 2021
@2005hithlj@Apache9
HBASE-26462Should persist restoreAcl flag in the procedure state for…
ec52519
… CloneSnapshotProcedure and RestoreSnapshotProcedure (#3921)
Signed-off-by: Yu Li <liyu@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@2005hithlj
2005hithlj deleted the HBASE-26462 branch December 7, 2021 02:08
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@2005hithlj@stoty
HBASE-26462 Should persist restoreAcl flag in the procedure state for…
8251ff7
… CloneSnapshotProcedure and RestoreSnapshotProcedure (apache#3921)
Signed-off-by: Yu Li <liyu@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes
@carp84carp84carp84 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@2005hithlj@Apache-HBase@Apache9@carp84