Skip to content

HBASE-26555 Fix findbugs/spotbugs findings - #3937

Open
apurtell wants to merge 1 commit into
apache:branch-2from
apurtell:HBASE-26555-branch-2
Open

HBASE-26555 Fix findbugs/spotbugs findings#3937
apurtell wants to merge 1 commit into
apache:branch-2from
apurtell:HBASE-26555-branch-2

Conversation

@apurtell

@apurtellapurtell commented Dec 12, 2021

Copy link
Copy Markdown
Contributor

Commits in the PR branch break down changes per module.

@Apache-HBase

Apache-HBase commented Dec 12, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for branch
+1 💚mvninstall5m 3sbranch-2 passed
+1 💚compile12m 13sbranch-2 passed
+1 💚checkstyle5m 33sbranch-2 passed
+1 💚spotbugs10m 37sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 33sthe patch passed
+1 💚compile11m 55sthe patch passed
+1 💚javac0m 52shbase-common in the patch passed.
+1 💚javac0m 23shbase-metrics in the patch passed.
+1 💚javac1m 13shbase-client generated 0 new + 157 unchanged - 1 fixed = 157 total (was 158)
+1 💚javac0m 29shbase-zookeeper in the patch passed.
+1 💚javac0m 26shbase-replication in the patch passed.
+1 💚javac0m 34shbase-http in the patch passed.
+1 💚javac0m 30shbase-asyncfs in the patch passed.
+1 💚javac0m 35shbase-procedure in the patch passed.
+1 💚javac3m 30shbase-server in the patch passed.
-0 ⚠️javac0m 51shbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198)
+1 💚javac0m 58shbase-rsgroup generated 0 new + 190 unchanged - 1 fixed = 190 total (was 191)
-0 ⚠️javac0m 43shbase-it generated 3 new + 100 unchanged - 3 fixed = 103 total (was 103)
-0 ⚠️javac0m 51shbase-rest generated 1 new + 184 unchanged - 4 fixed = 185 total (was 188)
+1 💚checkstyle0m 25sThe patch passed checkstyle in hbase-common
+1 💚checkstyle0m 11sThe patch passed checkstyle in hbase-metrics
+1 💚checkstyle0m 37sThe patch passed checkstyle in hbase-client
+1 💚checkstyle0m 15sThe patch passed checkstyle in hbase-zookeeper
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-replication
+1 💚checkstyle0m 14sThe patch passed checkstyle in hbase-http
+1 💚checkstyle0m 14sThe patch passed checkstyle in hbase-asyncfs
-0 ⚠️checkstyle0m 15shbase-procedure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️checkstyle1m 32shbase-server: The patch generated 2 new + 763 unchanged - 10 fixed = 765 total (was 773)
+1 💚checkstyle0m 20shbase-mapreduce: The patch generated 0 new + 86 unchanged - 1 fixed = 86 total (was 87)
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-rsgroup
+1 💚checkstyle0m 20sThe patch passed checkstyle in hbase-it
+1 💚checkstyle0m 16sThe patch passed checkstyle in hbase-rest
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck15m 25sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs12m 43sthe patch passed
_ Other Tests _
+1 💚asflicense2m 29sThe patch does not generate ASF License warnings.
101m 0s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3937
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 16412fdc97c3 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / bf6f946
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count87 (vs. ulimit of 12500)
modulesC: hbase-common hbase-metrics hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 12, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 54sbranch-2 passed
+1 💚compile6m 29sbranch-2 passed
+1 💚shadedjars7m 49sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 53sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall4m 29sthe patch passed
+1 💚compile6m 32sthe patch passed
+1 💚javac6m 32sthe patch passed
+1 💚shadedjars7m 44spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc5m 9sthe patch passed
_ Other Tests _
+1 💚unit1m 56shbase-common in the patch passed.
+1 💚unit0m 22shbase-metrics in the patch passed.
+1 💚unit2m 52shbase-client in the patch passed.
+1 💚unit0m 44shbase-zookeeper in the patch passed.
+1 💚unit0m 28shbase-replication in the patch passed.
+1 💚unit0m 45shbase-http in the patch passed.
+1 💚unit1m 25shbase-asyncfs in the patch passed.
+1 💚unit1m 38shbase-procedure in the patch passed.
-1 ❌unit136m 9shbase-server in the patch failed.
+1 💚unit11m 46shbase-mapreduce in the patch passed.
+1 💚unit3m 49shbase-rsgroup in the patch passed.
+1 💚unit1m 14shbase-it in the patch passed.
+1 💚unit3m 12shbase-rest in the patch passed.
220m 38s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3937
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5d38b58e3ea6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / bf6f946
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/testReport/
Max. process+thread count3718 (vs. ulimit of 12500)
modulesC: hbase-common hbase-metrics hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 12, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 19sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 17sbranch-2 passed
+1 💚compile5m 24sbranch-2 passed
+1 💚shadedjars7m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 16sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 5sthe patch passed
+1 💚compile5m 23sthe patch passed
+1 💚javac5m 23sthe patch passed
+1 💚shadedjars7m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 5sthe patch passed
_ Other Tests _
+1 💚unit1m 36shbase-common in the patch passed.
+1 💚unit0m 19shbase-metrics in the patch passed.
+1 💚unit2m 50shbase-client in the patch passed.
+1 💚unit0m 46shbase-zookeeper in the patch passed.
+1 💚unit0m 36shbase-replication in the patch passed.
+1 💚unit1m 11shbase-http in the patch passed.
+1 💚unit2m 19shbase-asyncfs in the patch passed.
+1 💚unit2m 2shbase-procedure in the patch passed.
-1 ❌unit219m 51shbase-server in the patch failed.
+1 💚unit16m 12shbase-mapreduce in the patch passed.
+1 💚unit4m 33shbase-rsgroup in the patch passed.
+1 💚unit1m 11shbase-it in the patch passed.
+1 💚unit5m 17shbase-rest in the patch passed.
306m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3937
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6797908d5380 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / bf6f946
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/testReport/
Max. process+thread count2984 (vs. ulimit of 12500)
modulesC: hbase-common hbase-metrics hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell

apurtell commented Dec 12, 2021

Copy link
Copy Markdown
ContributorAuthor

Fix LoadTestKVGenerator related failures.

@Apache-HBase

Apache-HBase commented Dec 12, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 26sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 2sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 38sbranch-2 passed
+1 💚compile12m 14sbranch-2 passed
+1 💚checkstyle4m 55sbranch-2 passed
+1 💚spotbugs11m 15sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 19sthe patch passed
+1 💚compile12m 18sthe patch passed
+1 💚javac0m 52shbase-common in the patch passed.
+1 💚javac0m 22shbase-metrics in the patch passed.
+1 💚javac1m 12shbase-client generated 0 new + 157 unchanged - 1 fixed = 157 total (was 158)
+1 💚javac0m 31shbase-zookeeper in the patch passed.
+1 💚javac0m 26shbase-replication in the patch passed.
+1 💚javac0m 32shbase-http in the patch passed.
+1 💚javac0m 30shbase-asyncfs in the patch passed.
+1 💚javac0m 33shbase-procedure in the patch passed.
+1 💚javac3m 41shbase-server in the patch passed.
-0 ⚠️javac0m 55shbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198)
+1 💚javac1m 4shbase-rsgroup generated 0 new + 190 unchanged - 1 fixed = 190 total (was 191)
-0 ⚠️javac0m 44shbase-it generated 3 new + 100 unchanged - 3 fixed = 103 total (was 103)
-0 ⚠️javac0m 56shbase-rest generated 1 new + 184 unchanged - 4 fixed = 185 total (was 188)
+1 💚checkstyle0m 27sThe patch passed checkstyle in hbase-common
+1 💚checkstyle0m 12sThe patch passed checkstyle in hbase-metrics
+1 💚checkstyle0m 37sThe patch passed checkstyle in hbase-client
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-zookeeper
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-replication
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-http
+1 💚checkstyle0m 12sThe patch passed checkstyle in hbase-asyncfs
-0 ⚠️checkstyle0m 15shbase-procedure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️checkstyle1m 32shbase-server: The patch generated 2 new + 763 unchanged - 10 fixed = 765 total (was 773)
+1 💚checkstyle0m 22shbase-mapreduce: The patch generated 0 new + 86 unchanged - 1 fixed = 86 total (was 87)
+1 💚checkstyle0m 15sThe patch passed checkstyle in hbase-rsgroup
+1 💚checkstyle0m 18sThe patch passed checkstyle in hbase-it
+1 💚checkstyle0m 17sThe patch passed checkstyle in hbase-rest
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck14m 53sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs14m 9sthe patch passed
_ Other Tests _
+1 💚asflicense2m 32sThe patch does not generate ASF License warnings.
102m 41s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3937
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 2a25e9c8f626 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / bf6f946
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count86 (vs. ulimit of 12500)
modulesC: hbase-common hbase-metrics hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 12, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall3m 44sbranch-2 passed
+1 💚compile5m 36sbranch-2 passed
+1 💚shadedjars6m 34sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 26sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 31sthe patch passed
+1 💚compile5m 36sthe patch passed
+1 💚javac5m 36sthe patch passed
+1 💚shadedjars6m 31spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 25sthe patch passed
_ Other Tests _
+1 💚unit1m 35shbase-common in the patch passed.
+1 💚unit0m 21shbase-metrics in the patch passed.
+1 💚unit2m 49shbase-client in the patch passed.
+1 💚unit0m 46shbase-zookeeper in the patch passed.
+1 💚unit0m 26shbase-replication in the patch passed.
+1 💚unit0m 52shbase-http in the patch passed.
+1 💚unit1m 44shbase-asyncfs in the patch passed.
+1 💚unit1m 48shbase-procedure in the patch passed.
+1 💚unit145m 39shbase-server in the patch passed.
+1 💚unit11m 38shbase-mapreduce in the patch passed.
+1 💚unit3m 24shbase-rsgroup in the patch passed.
+1 💚unit1m 17shbase-it in the patch passed.
+1 💚unit4m 8shbase-rest in the patch passed.
223m 0s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3937
Optional Testsjavac javadoc unit shadedjars compile
unameLinux cfc03fbefea5 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / bf6f946
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/testReport/
Max. process+thread count3997 (vs. ulimit of 12500)
modulesC: hbase-common hbase-metrics hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 12, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 30sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 44sbranch-2 passed
+1 💚compile6m 25sbranch-2 passed
+1 💚shadedjars7m 23sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc5m 9sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall4m 25sthe patch passed
+1 💚compile6m 32sthe patch passed
+1 💚javac6m 32sthe patch passed
+1 💚shadedjars7m 14spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 56sthe patch passed
_ Other Tests _
+1 💚unit1m 49shbase-common in the patch passed.
+1 💚unit0m 25shbase-metrics in the patch passed.
+1 💚unit3m 0shbase-client in the patch passed.
+1 💚unit0m 45shbase-zookeeper in the patch passed.
+1 💚unit0m 41shbase-replication in the patch passed.
+1 💚unit0m 47shbase-http in the patch passed.
+1 💚unit1m 35shbase-asyncfs in the patch passed.
+1 💚unit1m 36shbase-procedure in the patch passed.
+1 💚unit160m 43shbase-server in the patch passed.
+1 💚unit13m 56shbase-mapreduce in the patch passed.
+1 💚unit4m 36shbase-rsgroup in the patch passed.
+1 💚unit1m 18shbase-it in the patch passed.
+1 💚unit3m 28shbase-rest in the patch passed.
248m 41s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3937
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 40850b82a80f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / bf6f946
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/testReport/
Max. process+thread count4472 (vs. ulimit of 12500)
modulesC: hbase-common hbase-metrics hbase-client hbase-zookeeper hbase-replication hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

sunhelly
sunhelly reviewed Dec 13, 2021
View reviewed changes

@sunhellysunhelly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Please fix the check style issues.

@apurtell

apurtell commented Dec 15, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I am going to split the Random changes into a separate JIRA and PR because that part has taken on a life of its own.

Edit: It is HBASE-26582

@Apache-HBase

Apache-HBase commented Dec 15, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec8m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 9sbranch-2 passed
+1 💚compile9m 44sbranch-2 passed
+1 💚checkstyle3m 46sbranch-2 passed
+1 💚spotbugs8m 23sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
-1 ❌mvninstall3m 33sroot in the patch failed.
-1 ❌compile0m 34shbase-it in the patch failed.
+1 💚javac0m 49shbase-common in the patch passed.
+1 💚javac1m 6shbase-client generated 0 new + 158 unchanged - 1 fixed = 158 total (was 159)
+1 💚javac0m 32shbase-http in the patch passed.
+1 💚javac0m 31shbase-procedure in the patch passed.
+1 💚javac3m 12shbase-server in the patch passed.
-0 ⚠️javac0m 51shbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198)
+1 💚javac0m 56shbase-rsgroup in the patch passed.
-0 ⚠️javac0m 34shbase-it in the patch failed.
-0 ⚠️javac0m 51shbase-rest generated 1 new + 184 unchanged - 4 fixed = 185 total (was 188)
+1 💚checkstyle0m 25sThe patch passed checkstyle in hbase-common
+1 💚checkstyle0m 38shbase-client: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚checkstyle0m 15sThe patch passed checkstyle in hbase-http
-0 ⚠️checkstyle0m 15shbase-procedure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚checkstyle1m 18sThe patch passed checkstyle in hbase-server
+1 💚checkstyle0m 18sThe patch passed checkstyle in hbase-mapreduce
+1 💚checkstyle0m 15sThe patch passed checkstyle in hbase-rsgroup
+1 💚checkstyle0m 18sThe patch passed checkstyle in hbase-it
+1 💚checkstyle0m 16sThe patch passed checkstyle in hbase-rest
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌hadoopcheck3m 30sThe patch causes 24 errors with Hadoop v3.1.2.
-1 ❌hadoopcheck7m 29sThe patch causes 24 errors with Hadoop v3.2.1.
-1 ❌spotbugs0m 31shbase-it in the patch failed.
_ Other Tests _
+1 💚asflicense1m 51sThe patch does not generate ASF License warnings.
77m 30s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3937
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 7e006f948c4d 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / c7a8e42
Default JavaAdoptOpenJDK-1.8.0_282-b08
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/patch-compile-hbase-it.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/patch-compile-hbase-it.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-it.txt
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 15, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec9m 34sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 3sbranch-2 passed
+1 💚compile4m 32sbranch-2 passed
+1 💚shadedjars6m 42sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 23sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
-1 ❌mvninstall3m 31sroot in the patch failed.
-1 ❌compile0m 26shbase-it in the patch failed.
-0 ⚠️javac0m 26shbase-it in the patch failed.
+1 💚shadedjars6m 52spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 23sthe patch passed
_ Other Tests _
+1 💚unit1m 38shbase-common in the patch passed.
+1 💚unit2m 38shbase-client in the patch passed.
+1 💚unit1m 6shbase-http in the patch passed.
+1 💚unit1m 45shbase-procedure in the patch passed.
+1 💚unit154m 1shbase-server in the patch passed.
+1 💚unit13m 28shbase-mapreduce in the patch passed.
+1 💚unit4m 42shbase-rsgroup in the patch passed.
-1 ❌unit0m 46shbase-it in the patch failed.
+1 💚unit4m 26shbase-rest in the patch passed.
235m 45s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3937
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6daacbf06b36 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / c7a8e42
Default JavaAdoptOpenJDK-1.8.0_282-b08
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-it.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-it.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-it.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/testReport/
Max. process+thread count3718 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 15, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 31sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 42sMaven dependency ordering for branch
+1 💚mvninstall5m 35sbranch-2 passed
+1 💚compile5m 13sbranch-2 passed
+1 💚shadedjars8m 16sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 36sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
-1 ❌mvninstall4m 44sroot in the patch failed.
-1 ❌compile0m 35shbase-it in the patch failed.
-0 ⚠️javac0m 35shbase-it in the patch failed.
+1 💚shadedjars8m 30spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 2sthe patch passed
_ Other Tests _
+1 💚unit2m 10shbase-common in the patch passed.
+1 💚unit3m 7shbase-client in the patch passed.
+1 💚unit0m 56shbase-http in the patch passed.
+1 💚unit2m 8shbase-procedure in the patch passed.
+1 💚unit209m 41shbase-server in the patch passed.
+1 💚unit15m 5shbase-mapreduce in the patch passed.
+1 💚unit4m 20shbase-rsgroup in the patch passed.
-1 ❌unit0m 43shbase-it in the patch failed.
+1 💚unit4m 23shbase-rest in the patch passed.
294m 38s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3937
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 45c35bea82e8 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / c7a8e42
Default JavaAdoptOpenJDK-11.0.10+9
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-it.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-it.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-it.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/testReport/
Max. process+thread count3080 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-rsgroup hbase-it hbase-rest U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3937/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser
joshelser approved these changes Jan 4, 2022
View reviewed changes

@joshelserjoshelser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshelser

joshelser commented Jan 4, 2022

Copy link
Copy Markdown
Member

Oh bother, now I see #3936 has the same changes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunhellysunhellysunhelly left review comments
@joshelserjoshelserjoshelser approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@apurtell@Apache-HBase@joshelser@sunhelly