Skip to content

HBASE-26623 Report CallDroppedException in exception metrics - #3980

Merged
Apache9 merged 3 commits into
apache:masterfrom
HubSpot:HBASE-26623
Dec 29, 2021
Merged

HBASE-26623 Report CallDroppedException in exception metrics#3980
Apache9 merged 3 commits into
apache:masterfrom
HubSpot:HBASE-26623

Conversation

@rmarsch

@rmarschrmarsch commented Dec 23, 2021

Copy link
Copy Markdown
Contributor

CallDroppedException can be thrown with CallRunner.drop() by queue implementations that decide to drop calls to groom the RPC call backlog. The LifoCoDel queue does this I believe and with Pluggable queue it's possible for 3rd party queue implementations to be using drop() for similar reasons. It would be nice for the server to be tracking these exceptions in metrics since otherwise you might have to do some extra lifting on the client side.

https://issues.apache.org/jira/browse/HBASE-26623

Richard Marscher
HBASE-26623 Report CallDroppedException in exception metrics
dba8780
`CallDroppedException` can be thrown with `CallRunner.drop()` by queue implementations that decide to drop calls to groom the RPC call backlog. The LifoCoDel queue does this I believe and with Pluggable queue it's possible for 3rd party queue implementations to be using `drop()` for similar reasons. It would be nice for the server to be tracking these exceptions in metrics since otherwise you might have to do some extra lifting on the client side.
bbeaudreault
bbeaudreault approved these changes Dec 23, 2021
View reviewed changes

@bbeaudreaultbbeaudreault left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@Apache-HBase

Apache-HBase commented Dec 23, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 0sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 36sMaven dependency ordering for branch
+1 💚mvninstall5m 11smaster passed
+1 💚compile2m 21smaster passed
+1 💚shadedjars9m 12sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 4smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall5m 5sthe patch passed
+1 💚compile2m 19sthe patch passed
+1 💚javac2m 19sthe patch passed
+1 💚shadedjars9m 12spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 1sthe patch passed
_ Other Tests _
+1 💚unit0m 45shbase-hadoop-compat in the patch passed.
-1 ❌unit12m 19shbase-server in the patch failed.
-1 ❌unit8m 38shbase-thrift in the patch failed.
62m 40s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3980
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2f010185cc58 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 70703ca
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-thrift.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/1/testReport/
Max. process+thread count1504 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server hbase-thrift U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 23, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 46sMaven dependency ordering for branch
+1 💚mvninstall4m 31smaster passed
+1 💚compile2m 4smaster passed
+1 💚shadedjars10m 55sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 12smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall5m 24sthe patch passed
+1 💚compile2m 47sthe patch passed
+1 💚javac2m 47sthe patch passed
+1 💚shadedjars11m 32spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 1sthe patch passed
_ Other Tests _
+1 💚unit0m 52shbase-hadoop-compat in the patch passed.
-1 ❌unit11m 32shbase-server in the patch failed.
-1 ❌unit6m 51shbase-thrift in the patch failed.
64m 28s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3980
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6449b0e09502 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 70703ca
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-thrift.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/1/testReport/
Max. process+thread count2061 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server hbase-thrift U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 23, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 39sMaven dependency ordering for branch
+1 💚mvninstall4m 22smaster passed
+1 💚compile4m 53smaster passed
+1 💚checkstyle2m 11smaster passed
+1 💚spotbugs4m 15smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 13sthe patch passed
+1 💚compile4m 51sthe patch passed
+1 💚javac4m 51sthe patch passed
+1 💚checkstyle2m 8sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck21m 26sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs4m 45sthe patch passed
_ Other Tests _
+1 💚asflicense0m 34sThe patch does not generate ASF License warnings.
65m 3s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3980
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux ce0a28ef5aa5 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 70703ca
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server hbase-thrift U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 23, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 13smaster passed
+1 💚compile4m 49smaster passed
+1 💚checkstyle2m 8smaster passed
+1 💚spotbugs4m 8smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 16sthe patch passed
+1 💚compile4m 51sthe patch passed
+1 💚javac4m 51sthe patch passed
+1 💚checkstyle2m 8sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck21m 17sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs4m 51sthe patch passed
_ Other Tests _
+1 💚asflicense0m 32sThe patch does not generate ASF License warnings.
63m 57s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3980
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 0773bbba61d6 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 70703ca
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server hbase-thrift U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 24, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall5m 15smaster passed
+1 💚compile2m 56smaster passed
+1 💚shadedjars11m 29sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 57smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall5m 54sthe patch passed
+1 💚compile2m 45sthe patch passed
+1 💚javac2m 45sthe patch passed
+1 💚shadedjars11m 51spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 59sthe patch passed
_ Other Tests _
+1 💚unit0m 50shbase-hadoop-compat in the patch passed.
+1 💚unit172m 41shbase-server in the patch passed.
-1 ❌unit7m 16shbase-thrift in the patch failed.
228m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3980
Optional Testsjavac javadoc unit shadedjars compile
unameLinux eeebb55026b8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 70703ca
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-thrift.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/2/testReport/
Max. process+thread count3782 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server hbase-thrift U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 24, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall5m 3smaster passed
+1 💚compile2m 17smaster passed
+1 💚shadedjars9m 6sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 3smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall5m 3sthe patch passed
+1 💚compile2m 21sthe patch passed
+1 💚javac2m 21sthe patch passed
+1 💚shadedjars9m 10spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 3sthe patch passed
_ Other Tests _
+1 💚unit0m 45shbase-hadoop-compat in the patch passed.
+1 💚unit205m 34shbase-server in the patch passed.
-1 ❌unit8m 42shbase-thrift in the patch failed.
255m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3980
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3254d2457b2a 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 70703ca
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-thrift.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/2/testReport/
Max. process+thread count2578 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server hbase-thrift U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 24, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 41sMaven dependency ordering for branch
+1 💚mvninstall4m 23smaster passed
+1 💚compile4m 52smaster passed
+1 💚checkstyle2m 10smaster passed
+1 💚spotbugs4m 14smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 18sthe patch passed
+1 💚compile4m 50sthe patch passed
+1 💚javac4m 50sthe patch passed
+1 💚checkstyle2m 9sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck21m 48sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs4m 47sthe patch passed
_ Other Tests _
+1 💚asflicense0m 33sThe patch does not generate ASF License warnings.
65m 15s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3980
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux ddccab216a7d 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 70703ca
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server hbase-thrift U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 24, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall5m 26smaster passed
+1 💚compile3m 10smaster passed
+1 💚shadedjars12m 44sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 7smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall6m 2sthe patch passed
+1 💚compile2m 35sthe patch passed
+1 💚javac2m 35sthe patch passed
+1 💚shadedjars9m 16spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 39sthe patch passed
_ Other Tests _
+1 💚unit0m 43shbase-hadoop-compat in the patch passed.
+1 💚unit162m 54shbase-server in the patch passed.
+1 💚unit6m 45shbase-thrift in the patch passed.
217m 25s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3980
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1db1c6719581 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 70703ca
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/3/testReport/
Max. process+thread count3639 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server hbase-thrift U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 24, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 40sMaven dependency ordering for branch
+1 💚mvninstall5m 13smaster passed
+1 💚compile2m 19smaster passed
+1 💚shadedjars9m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 5smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall5m 4sthe patch passed
+1 💚compile2m 21sthe patch passed
+1 💚javac2m 21sthe patch passed
+1 💚shadedjars9m 7spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 5sthe patch passed
_ Other Tests _
+1 💚unit0m 46shbase-hadoop-compat in the patch passed.
+1 💚unit206m 20shbase-server in the patch passed.
+1 💚unit9m 12shbase-thrift in the patch passed.
257m 45s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3980
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f04e2653f4c9 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 70703ca
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/3/testReport/
Max. process+thread count2756 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server hbase-thrift U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3980/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit c8b0148 into apache:masterDec 29, 2021
Apache9 pushed a commit that referenced this pull request Dec 29, 2021
@rmarsch@Apache9
HBASE-26623Report CallDroppedException in exception metrics (#3980)
0001ad6
`CallDroppedException` can be thrown with `CallRunner.drop()` by queue implementations that decide to drop calls to groom the RPC call backlog. The LifoCoDel queue does this I believe and with Pluggable queue it's possible for 3rd party queue implementations to be using `drop()` for similar reasons. It would be nice for the server to be tracking these exceptions in metrics since otherwise you might have to do some extra lifting on the client side.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Bryan Beaudreault <bbeaudreault@hubspot.com>
Apache9 pushed a commit that referenced this pull request Dec 29, 2021
@rmarsch@Apache9
HBASE-26623Report CallDroppedException in exception metrics (#3980)
9890ac9
`CallDroppedException` can be thrown with `CallRunner.drop()` by queue implementations that decide to drop calls to groom the RPC call backlog. The LifoCoDel queue does this I believe and with Pluggable queue it's possible for 3rd party queue implementations to be using `drop()` for similar reasons. It would be nice for the server to be tracking these exceptions in metrics since otherwise you might have to do some extra lifting on the client side.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Bryan Beaudreault <bbeaudreault@hubspot.com>
bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Jan 27, 2022
@rmarsch@bbeaudreault
HubSpot Backport: HBASE-26623 Report CallDroppedException in exceptio…
2450ffc
…n metrics (apache#3980)
`CallDroppedException` can be thrown with `CallRunner.drop()` by queue implementations that decide to drop calls to groom the RPC call backlog. The LifoCoDel queue does this I believe and with Pluggable queue it's possible for 3rd party queue implementations to be using `drop()` for similar reasons. It would be nice for the server to be tracking these exceptions in metrics since otherwise you might have to do some extra lifting on the client side.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Bryan Beaudreault <bbeaudreault@hubspot.com>
bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Jan 28, 2022
@rmarsch@bbeaudreault
HubSpot Backport: HBASE-26623 Report CallDroppedException in exceptio…
973492a
…n metrics (apache#3980)
`CallDroppedException` can be thrown with `CallRunner.drop()` by queue implementations that decide to drop calls to groom the RPC call backlog. The LifoCoDel queue does this I believe and with Pluggable queue it's possible for 3rd party queue implementations to be using `drop()` for similar reasons. It would be nice for the server to be tracking these exceptions in metrics since otherwise you might have to do some extra lifting on the client side.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Bryan Beaudreault <bbeaudreault@hubspot.com>
@charlesconnell
charlesconnell deleted the HBASE-26623 branch September 19, 2025 15:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbeaudreaultbbeaudreaultbbeaudreault approved these changes
@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rmarsch@Apache-HBase@bbeaudreault@Apache9