Skip to content

HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re… - #399

Merged
Apache9 merged 1 commit into
apache:HBASE-22514from
Apache9:HBASE-22676
Jul 23, 2019
Merged

HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re…#399
Apache9 merged 1 commit into
apache:HBASE-22514from
Apache9:HBASE-22676

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

…move hbase-rsgroup module

@openinxopeninx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, seems no java files change, just movement. Let's wait the hadoop QA (exspecially hbase-shell module or something), will approve if it says OK.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec57Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 30 new or modified test files.
_ HBASE-22514 Compile Tests _
0mvndep13Maven dependency ordering for branch
-1mvninstall11root in HBASE-22514 failed.
+1compile161HBASE-22514 passed
+1checkstyle143HBASE-22514 passed
+1shadedjars270branch has no errors when building our shaded downstream artifacts.
+1javadoc250HBASE-22514 passed
0spotbugs843Used deprecated FindBugs config; considering switching to SpotBugs.
-1findbugs36hbase-server in HBASE-22514 failed.
-1findbugs18hbase-rsgroup in HBASE-22514 failed.
0findbugs29branch/hbase-assembly no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
0mvndep12Maven dependency ordering for patch
-1mvninstall11root in the patch failed.
+1compile163the patch passed
+1javac163the patch passed
+1checkstyle136the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml7The patch has no ill-formed XML file.
+1shadedjars271patch has no errors when building our shaded downstream artifacts.
-1hadoopcheck11The patch causes 10 errors with Hadoop v2.8.5.
-1hadoopcheck20The patch causes 10 errors with Hadoop v2.9.2.
-1hadoopcheck31The patch causes 10 errors with Hadoop v3.1.2.
-1javadoc33hbase-server generated 63 new + 4 unchanged - 1 fixed = 67 total (was 5)
-1javadoc151root generated 63 new + 17 unchanged - 72 fixed = 80 total (was 89)
-1findbugs35hbase-server in the patch failed.
0findbugs23hbase-assembly has no data from findbugs
_ Other Tests _
+1unit21078root in the patch passed.
+1asflicense187The patch does not generate ASF License warnings.
24992
SubsystemReport/Notes
DockerClient=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-399/2/artifact/out/Dockerfile
GITHUB PR#399
Optional Testsdupname asflicense javac javadoc unit xml shadedjars hadoopcheck compile spotbugs findbugs hbaseanti checkstyle
unameLinux dc47ea7822a9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-399/out/precommit/personality/provided.sh
git revisionHBASE-22514 / bf2055a
Default Java1.8.0_181
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-399/2/artifact/out/branch-mvninstall-root.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-399/2/artifact/out/branch-findbugs-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-399/2/artifact/out/branch-findbugs-hbase-rsgroup.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-399/2/artifact/out/patch-mvninstall-root.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-399/2/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-399/2/artifact/out/patch-javac-2.9.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-399/2/artifact/out/patch-javac-3.1.2.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-399/2/artifact/out/diff-javadoc-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-399/2/artifact/out/diff-javadoc-javadoc-root.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-399/2/artifact/out/patch-findbugs-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-399/2/testReport/
Max. process+thread count5548 (vs. ulimit of 10000)
modulesC: hbase-server hbase-shell hbase-it hbase-assembly . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-399/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

The result is a bit strange... Tried locally, mvn install is fine. Let me trigger a build again...

And on the spotbugs, I think the problem is that we switch to yetus 0.10.0. Let me check how to fix it.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

Not sure what's the problem but at least the mvn install failed also for the base branch...

Anyway, the UTs are all passed, and tried locally, the mvn install also passed.

Let me merge it back as this is on a feature branch.

@openinx

Copy link
Copy Markdown
Member

Let me have a check on my host...

@Apache9
Apache9 merged commit 2b2bcbe into apache:HBASE-22514Jul 23, 2019
asfgit pushed a commit that referenced this pull request Jul 23, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Jul 25, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Jul 28, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Jul 30, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 1, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 2, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 7, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 8, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 15, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 16, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 18, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 22, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 24, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 25, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Aug 27, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 1, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 2, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 2, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 4, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 7, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 9, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 10, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 10, 2019
…r and remove hbase-rsgroup module (#399)"
This reverts commit f7bbdde.
asfgit pushed a commit that referenced this pull request Sep 10, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 11, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 11, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 16, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 17, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 18, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 20, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Sep 24, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Oct 5, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Oct 28, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Nov 5, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Nov 10, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Nov 13, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Dec 24, 2019
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Feb 2, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Feb 3, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Feb 4, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Feb 6, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Feb 7, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Feb 8, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Feb 9, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Feb 12, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Feb 20, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Feb 22, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Feb 25, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Feb 26, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Feb 29, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
Apache9 added a commit that referenced this pull request Mar 2, 2020
…move hbase-rsgroup module (#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
…move hbase-rsgroup module (apache#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
…move hbase-rsgroup module (apache#399)
Signed-off-by: Zheng Hu <openinx@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@openinx