Skip to content

HBASE-22721 Refactor HBaseFsck: move the inner class out - #401

Merged
infraio merged 1 commit into
apache:masterfrom
infraio:HBASE-22721
Jul 24, 2019
Merged

HBASE-22721 Refactor HBaseFsck: move the inner class out#401
infraio merged 1 commit into
apache:masterfrom
infraio:HBASE-22721

Conversation

@infraio

@infraioinfraio commented Jul 23, 2019

Copy link
Copy Markdown
Contributor

No description provided.

saintstack
saintstack approved these changes Jul 23, 2019
View reviewed changes

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. You moving it out for UI reporting @infraio ?

@Apache-HBase

Apache-HBase commented Jul 23, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec37Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 4 new or modified test files.
_ master Compile Tests _
+1mvninstall271master passed
+1compile60master passed
+1checkstyle85master passed
+1shadedjars276branch has no errors when building our shaded downstream artifacts.
+1javadoc34master passed
0spotbugs227Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs225master passed
_ Patch Compile Tests _
+1mvninstall249the patch passed
+1compile53the patch passed
+1javac53the patch passed
-1checkstyle80hbase-server: The patch generated 34 new + 174 unchanged - 23 fixed = 208 total (was 197)
+1whitespace1The patch has no whitespace issues.
+1shadedjars256patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck730Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc32the patch passed
-1findbugs245hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit7857hbase-server in the patch passed.
+1asflicense20The patch does not generate ASF License warnings.
10827
ReasonTests
FindBugsmodule:hbase-server
Should org.apache.hadoop.hbase.util.HbckRegionInfo$OnlineEntry be a static inner class? At HbckRegionInfo.java:inner class? At HbckRegionInfo.java:[lines 346-361]
SubsystemReport/Notes
DockerClient=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/artifact/out/Dockerfile
GITHUB PR#401
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 83f69176d395 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401/out/precommit/personality/provided.sh
git revisionmaster / 9615c64
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/artifact/out/new-findbugs-hbase-server.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/testReport/
Max. process+thread count4775 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 23, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec63Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 4 new or modified test files.
_ master Compile Tests _
+1mvninstall244master passed
+1compile54master passed
+1checkstyle75master passed
+1shadedjars261branch has no errors when building our shaded downstream artifacts.
+1javadoc32master passed
0spotbugs242Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs241master passed
_ Patch Compile Tests _
+1mvninstall247the patch passed
+1compile55the patch passed
+1javac55the patch passed
-1checkstyle74hbase-server: The patch generated 34 new + 174 unchanged - 23 fixed = 208 total (was 197)
+1whitespace0The patch has no whitespace issues.
+1shadedjars279patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck735Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc31the patch passed
-1findbugs247hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
-1unit1571hbase-server in the patch failed.
+1asflicense11The patch does not generate ASF License warnings.
4523
ReasonTests
FindBugsmodule:hbase-server
Should org.apache.hadoop.hbase.util.HbckRegionInfo$OnlineEntry be a static inner class? At HbckRegionInfo.java:inner class? At HbckRegionInfo.java:[lines 346-361]
Failed junit testshadoop.hbase.filter.TestFilter
hadoop.hbase.client.TestAsyncAccessControlAdminApi
hadoop.hbase.filter.TestColumnPrefixFilter
hadoop.hbase.filter.TestFilterFromRegionSide
SubsystemReport/Notes
DockerClient=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/artifact/out/Dockerfile
GITHUB PR#401
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux e8d5e8453b19 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401/out/precommit/personality/provided.sh
git revisionmaster / 06f5c43
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/testReport/
Max. process+thread count699 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 23, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 4 new or modified test files.
_ master Compile Tests _
+1mvninstall244master passed
+1compile53master passed
+1checkstyle77master passed
+1shadedjars275branch has no errors when building our shaded downstream artifacts.
+1javadoc33master passed
0spotbugs241Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs239master passed
_ Patch Compile Tests _
+1mvninstall253the patch passed
+1compile54the patch passed
+1javac54the patch passed
-1checkstyle75hbase-server: The patch generated 34 new + 174 unchanged - 23 fixed = 208 total (was 197)
+1whitespace0The patch has no whitespace issues.
+1shadedjars271patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck741Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc33the patch passed
-1findbugs242hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1unit7594hbase-server in the patch passed.
+1asflicense29The patch does not generate ASF License warnings.
10583
ReasonTests
FindBugsmodule:hbase-server
Should org.apache.hadoop.hbase.util.HbckRegionInfo$OnlineEntry be a static inner class? At HbckRegionInfo.java:inner class? At HbckRegionInfo.java:[lines 346-361]
SubsystemReport/Notes
DockerClient=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/artifact/out/Dockerfile
GITHUB PR#401
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 9e46ed7ed251 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401/out/precommit/personality/provided.sh
git revisionmaster / fe450b5
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/artifact/out/new-findbugs-hbase-server.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/testReport/
Max. process+thread count4267 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 23, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec57Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 4 new or modified test files.
_ master Compile Tests _
+1mvninstall231master passed
+1compile48master passed
+1checkstyle72master passed
+1shadedjars256branch has no errors when building our shaded downstream artifacts.
+1javadoc33master passed
0spotbugs232Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs231master passed
_ Patch Compile Tests _
+1mvninstall237the patch passed
+1compile51the patch passed
+1javac51the patch passed
-1checkstyle71hbase-server: The patch generated 34 new + 174 unchanged - 23 fixed = 208 total (was 197)
+1whitespace0The patch has no whitespace issues.
+1shadedjars259patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck729Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc31the patch passed
-1findbugs240hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
-1unit16568hbase-server in the patch failed.
+1asflicense42The patch does not generate ASF License warnings.
19470
ReasonTests
FindBugsmodule:hbase-server
Should org.apache.hadoop.hbase.util.HbckRegionInfo$OnlineEntry be a static inner class? At HbckRegionInfo.java:inner class? At HbckRegionInfo.java:[lines 346-361]
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.replication.TestReplicationEndpoint
hadoop.hbase.regionserver.TestSplitTransactionOnCluster
SubsystemReport/Notes
DockerClient=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/4/artifact/out/Dockerfile
GITHUB PR#401
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 386de8bdfcfc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401@2/out/precommit/personality/provided.sh
git revisionmaster / 06f5c43
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/4/artifact/out/diff-checkstyle-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/4/artifact/out/new-findbugs-hbase-server.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/4/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/4/testReport/
Max. process+thread count4706 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/4/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 23, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec118Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 4 new or modified test files.
_ master Compile Tests _
+1mvninstall356master passed
+1compile80master passed
+1checkstyle133master passed
+1shadedjars366branch has no errors when building our shaded downstream artifacts.
+1javadoc45master passed
0spotbugs291Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs287master passed
_ Patch Compile Tests _
+1mvninstall359the patch passed
+1compile76the patch passed
+1javac76the patch passed
-1checkstyle107hbase-server: The patch generated 2 new + 172 unchanged - 25 fixed = 174 total (was 197)
+1whitespace0The patch has no whitespace issues.
+1shadedjars376patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1054Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc51the patch passed
+1findbugs321the patch passed
_ Other Tests _
-1unit13665hbase-server in the patch failed.
+1asflicense26The patch does not generate ASF License warnings.
17877
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/6/artifact/out/Dockerfile
GITHUB PR#401
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 42a4575e49ac 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401/out/precommit/personality/provided.sh
git revisionmaster / 06f5c43
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/6/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/6/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/6/testReport/
Max. process+thread count4587 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/6/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@infraio
infraio merged commit 6705d4f into apache:masterJul 24, 2019
@infraio
infraio deleted the HBASE-22721 branch July 24, 2019 00:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstacksaintstacksaintstack approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@infraio@Apache-HBase@saintstack