Skip to content

Backport "HBASE-26616 Refactor code related to ZooKeeper authentication (#3973)" to branch-2.4 - #4021

Merged
ndimiduk merged 1 commit into
apache:branch-2.4from
ndimiduk:26616-refactor-zk-auth-branch-2.4
Jan 11, 2022
Merged

Backport "HBASE-26616 Refactor code related to ZooKeeper authentication (#3973)" to branch-2.4#4021
ndimiduk merged 1 commit into
apache:branch-2.4from
ndimiduk:26616-refactor-zk-auth-branch-2.4

Conversation

@ndimiduk

@ndimidukndimiduk commented Jan 10, 2022

Copy link
Copy Markdown
Member

This refactor reduces the size and scope of the ZKUtil class. The core of this refactor is
moving the login* methods from ZKUtil into their own class, ZKAuthentication. The class
JaasConfiguration is also moved along with them.

Signed-off-by: Andrew Purtell apurtell@apache.org
Signed-off-by: Duo Zhang zhangduo@apache.org

@ndimiduk
HBASE-26616 Refactor code related to ZooKeeper authentication (apache…
31629dd
…#3973)
This refactor reduces the size and scope of the `ZKUtil` class. The core of this refactor is
moving the `login*` methods from `ZKUtil` into their own class, `ZKAuthentication`. The class
`JaasConfiguration` is also moved along with them.
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Jan 10, 2022
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@ndimiduk

ndimiduk commented Jan 11, 2022

Copy link
Copy Markdown
MemberAuthor

Test failures look like resource starvation, not related to this change. Running pre-commit suite again.

@Apache-HBase

Apache-HBase commented Jan 11, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 43sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall3m 24sbranch-2.4 passed
+1 💚compile3m 46sbranch-2.4 passed
+1 💚checkstyle1m 16sbranch-2.4 passed
+1 💚spotbugs2m 40sbranch-2.4 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 27sthe patch passed
+1 💚compile3m 43sthe patch passed
+1 💚javac0m 29shbase-zookeeper generated 0 new + 113 unchanged - 1 fixed = 113 total (was 114)
+1 💚javac3m 14shbase-server in the patch passed.
+1 💚checkstyle0m 12shbase-zookeeper: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
+1 💚checkstyle1m 8sThe patch passed checkstyle in hbase-server
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck20m 24sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚spotbugs4m 3sthe patch passed
_ Other Tests _
+1 💚asflicense0m 25sThe patch does not generate ASF License warnings.
56m 5s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4021/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4021
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 49de06892263 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 3f68399
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-zookeeper hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4021/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 11, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall4m 5sbranch-2.4 passed
+1 💚compile1m 32sbranch-2.4 passed
+1 💚shadedjars7m 0sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 58sbranch-2.4 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 11sthe patch passed
+1 💚compile1m 29sthe patch passed
+1 💚javac1m 29sthe patch passed
+1 💚shadedjars6m 50spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 59sthe patch passed
_ Other Tests _
+1 💚unit0m 42shbase-zookeeper in the patch passed.
+1 💚unit136m 55shbase-server in the patch passed.
168m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4021/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4021
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f5cb622a8eaf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 3f68399
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4021/2/testReport/
Max. process+thread count4314 (vs. ulimit of 12500)
modulesC: hbase-zookeeper hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4021/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 11, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall3m 39sbranch-2.4 passed
+1 💚compile1m 16sbranch-2.4 passed
+1 💚shadedjars6m 35sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 50sbranch-2.4 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 40sthe patch passed
+1 💚compile1m 16sthe patch passed
+1 💚javac1m 16sthe patch passed
+1 💚shadedjars6m 32spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 50sthe patch passed
_ Other Tests _
+1 💚unit0m 43shbase-zookeeper in the patch passed.
+1 💚unit209m 51shbase-server in the patch passed.
239m 19s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4021/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4021
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c400a2533f14 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 3f68399
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4021/2/testReport/
Max. process+thread count2633 (vs. ulimit of 12500)
modulesC: hbase-zookeeper hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4021/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit 87e0554 into apache:branch-2.4Jan 11, 2022
@ndimiduk
ndimiduk deleted the 26616-refactor-zk-auth-branch-2.4 branch January 11, 2022 23:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndimiduk@Apache-HBase