Uh oh!
There was an error while loading. Please reload this page.
HBASE-22709 Add a chore thread in master to do hbck checking - #404
Merged
Conversation
Apache-HBase
commented
Jul 24, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 24, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 25, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 25, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 25, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 25, 2019
🎊 +1 overall
This message was automatically generated. |
saintstack
left a comment
Contributor
There was a problem hiding this comment.
This is excellent.
Some comments. See what you think.
Lets get this in. I want to add the findings over in HBASE-22723 to your new hbck.jsp.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| private final Map<String, ServerName> orphanRegionsOnRSSnapshot = new HashMap<>(); | ||
| private final List<String> orphanRegionsOnFSSnapshot = new LinkedList<>(); | ||
| private final Map<String, Pair<ServerName, List<ServerName>>> inconsistentRegionsSnapshot = | ||
| new HashMap<>(); |
| try { | ||
| loadRegionsFromFS(); | ||
| } catch (IOException e) { | ||
| LOG.warn("Faile to load the regions from filesystem", e); |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| if (hbckChecker != null) { | ||
| inconsistentRegions = hbckChecker.getInconsistentRegions(); | ||
| orphanRegionsOnRS = hbckChecker.getOrphanRegionsOnRS(); | ||
| orphanRegionsOnFS = hbckChecker.getOrphanRegionsOnFS(); |
Contributor
There was a problem hiding this comment.
Yeah, so this stuff could be an hour old?
Contributor
There was a problem hiding this comment.
Date it? See patch in HBASE-22741. It dates the CJ run Report.
ContributorAuthor
There was a problem hiding this comment.
There are a date in the latest code.
Uh oh!
There was an error while loading. Please reload this page.
saintstack
left a comment
Contributor
There was a problem hiding this comment.
One other thought, is if there is overlap with existing chores?
Maybe the clusterstatuspublisher?
saintstack
left a comment
Contributor
There was a problem hiding this comment.
Oh, also as a follow-on, should make it so user can trigger this chore to run... or perhaps a new shell command which is called hbck_report that runs this chore and the catalogjanitor, etc., to produce all hbck.
Apache-HBase
commented
Jul 25, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 26, 2019
💔 -1 overall
This message was automatically generated. |
infraio
commented
Jul 26, 2019
ContributorAuthor
Let me check this. |
infraio
commented
Jul 26, 2019
ContributorAuthor
This can be done by a new issue. |
infraio
commented
Jul 26, 2019
ContributorAuthor
The ClusterStatusPublisher only publish version, master and deadservers. Didn't have overlap with this. |
Apache-HBase
commented
Jul 26, 2019
💔 -1 overall
This message was automatically generated. |
saintstack
commented
Jul 26, 2019
Contributor
Ok on all of the above. Can do aggregation as a follow-on if opportunity. |
Apache-HBase
commented
Jul 26, 2019
💔 -1 overall
This message was automatically generated. |
saintstack
approved these changes
Jul 26, 2019
saintstack
left a comment
Contributor
There was a problem hiding this comment.
There are a few other comments that could be addressed. Missing is dating the Report but can do later I suppose?
This is great.
| if (hbckChecker != null) { | ||
| inconsistentRegions = hbckChecker.getInconsistentRegions(); | ||
| orphanRegionsOnRS = hbckChecker.getOrphanRegionsOnRS(); | ||
| orphanRegionsOnFS = hbckChecker.getOrphanRegionsOnFS(); |
Contributor
There was a problem hiding this comment.
Date it? See patch in HBASE-22741. It dates the CJ run Report.
Apache-HBase
commented
Jul 27, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 27, 2019
🎊 +1 overall
This message was automatically generated. |
asfgit pushed a commit
that referenced
this pull request
Jul 27, 2019
Signed-off-by: stack <stack@apache.org>
asfgit pushed a commit
that referenced
this pull request
Jul 27, 2019
Signed-off-by: stack <stack@apache.org>
asfgit pushed a commit
that referenced
this pull request
Jul 27, 2019
Signed-off-by: stack <stack@apache.org>
asfgit pushed a commit
that referenced
this pull request
Jul 27, 2019
Signed-off-by: stack <stack@apache.org>
symat pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
) Signed-off-by: stack <stack@apache.org> (cherry picked from commit 50e27e2) Change-Id: I1b5d8bfd183147f51f4503e4331d2de23d1656e1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.