Skip to content

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down. - #4048

Merged
Apache9 merged 2 commits into
apache:masterfrom
YutSean:HBASE-26688
Jan 25, 2022
Merged

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down.#4048
Apache9 merged 2 commits into
apache:masterfrom
YutSean:HBASE-26688

Conversation

@YutSean

@YutSeanYutSean commented Jan 20, 2022

Copy link
Copy Markdown
Contributor

@YutSean
HBASE-26688 Result#advance, current are not thread safe. But the pre-…
6a1fba9
…created EMPTY_RESULT like objects can be shared by multi client threads.
@Apache-HBase

Apache-HBase commented Jan 20, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 49smaster passed
+1 💚compile0m 30smaster passed
+1 💚shadedjars8m 30sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 30smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 33sthe patch passed
+1 💚compile0m 31sthe patch passed
+1 💚javac0m 31sthe patch passed
+1 💚shadedjars8m 19spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 26sthe patch passed
_ Other Tests _
+1 💚unit1m 28shbase-client in the patch passed.
31m 26s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4048
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 10d28e3acb91 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1d2b8a0
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/testReport/
Max. process+thread count308 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 20, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 39smaster passed
+1 💚compile0m 30smaster passed
+1 💚shadedjars10m 8sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 29smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 43sthe patch passed
+1 💚compile0m 31sthe patch passed
+1 💚javac0m 31sthe patch passed
+1 💚shadedjars9m 56spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22sthe patch passed
_ Other Tests _
+1 💚unit1m 30shbase-client in the patch passed.
34m 49s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4048
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 40862aacdfb6 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1d2b8a0
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/testReport/
Max. process+thread count348 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 20, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 2sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall4m 14smaster passed
+1 💚compile1m 1smaster passed
+1 💚checkstyle0m 30smaster passed
+1 💚spotbugs1m 5smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 53sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
-0 ⚠️checkstyle0m 29shbase-client: The patch generated 2 new + 11 unchanged - 2 fixed = 13 total (was 13)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck19m 45sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs1m 12sthe patch passed
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
42m 45s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4048
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 643bf89ca07b 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1d2b8a0
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count95 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 20, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 11smaster passed
+1 💚compile0m 27smaster passed
+1 💚shadedjars8m 19sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 26smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 56sthe patch passed
+1 💚compile0m 27sthe patch passed
+1 💚javac0m 27sthe patch passed
+1 💚shadedjars8m 16spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
+1 💚unit1m 19shbase-client in the patch passed.
29m 19s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4048
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 872c58e2a6ca 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1d2b8a0
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/testReport/
Max. process+thread count341 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 20, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 52smaster passed
+1 💚compile0m 31smaster passed
+1 💚shadedjars8m 24sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 29smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 37sthe patch passed
+1 💚compile0m 31sthe patch passed
+1 💚javac0m 31sthe patch passed
+1 💚shadedjars8m 22spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 27sthe patch passed
_ Other Tests _
+1 💚unit1m 23shbase-client in the patch passed.
31m 9s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4048
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6c9f8f7b8a60 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1d2b8a0
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/testReport/
Max. process+thread count301 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 20, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 2sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 50smaster passed
+1 💚compile0m 58smaster passed
+1 💚checkstyle0m 28smaster passed
+1 💚spotbugs1m 1smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 53sthe patch passed
+1 💚compile0m 57sthe patch passed
+1 💚javac0m 57sthe patch passed
+1 💚checkstyle0m 28shbase-client: The patch generated 0 new + 11 unchanged - 2 fixed = 11 total (was 13)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck19m 29sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs1m 12sthe patch passed
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
41m 37s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4048
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 8261bf61cd2c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1d2b8a0
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count95 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Jan 24, 2022

Copy link
Copy Markdown
Contributor

Better use a new title for the issue? The actual change seems not related to the title...

@YutSeanYutSean changed the title HBASE-26688 Result#advance, current are not thread safe. But the precreated EMPTY_RESULT like objects can be shared by multi client threads.HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down.Jan 24, 2022
@YutSean

YutSean commented Jan 24, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Yeah...... The previous description is a little bit imprecise. Has fixed. @Apache9

@Apache9
Apache9 merged commit d77ede4 into apache:masterJan 25, 2022
Apache9 pushed a commit that referenced this pull request Jan 25, 2022
@YutSean@Apache9
HBASE-26688Threads shared EMPTY_RESULT may lead to unexpected client…
087bb13
… job down. (#4048)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Jan 25, 2022
@YutSean@Apache9
HBASE-26688Threads shared EMPTY_RESULT may lead to unexpected client…
0771c04
… job down. (#4048)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Jan 25, 2022
@YutSean@Apache9
HBASE-26688Threads shared EMPTY_RESULT may lead to unexpected client…
fbd22f0
… job down. (#4048)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@bbeaudreault

bbeaudreault commented Jan 25, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

It's weird that this build succeeded. I'm seeing failures in master in TestResult#testAdvanceTwiceOnEmptyCell which look legit. The test expects to catch a NoSuchElementException, but that will never be thrown now that the new isEmpty() check short circuits advance().

Apache9 added a commit that referenced this pull request Jan 26, 2022
@Apache9
Revert "HBASE-26688Threads shared EMPTY_RESULT may lead to unexpecte…
c33fa3a
…d client job down. (#4048)"
This reverts commit d77ede4.
Apache9 added a commit that referenced this pull request Jan 26, 2022
@Apache9
Revert "HBASE-26688Threads shared EMPTY_RESULT may lead to unexpecte…
0ca2307
…d client job down. (#4048)"
This reverts commit 087bb13.
Apache9 added a commit that referenced this pull request Jan 26, 2022
@Apache9
Revert "HBASE-26688Threads shared EMPTY_RESULT may lead to unexpecte…
7e84223
…d client job down. (#4048)"
This reverts commit 0771c04.
Apache9 added a commit that referenced this pull request Jan 26, 2022
@Apache9
Revert "HBASE-26688Threads shared EMPTY_RESULT may lead to unexpecte…
0af543c
…d client job down. (#4048)"
This reverts commit fbd22f0.
asfgit pushed a commit that referenced this pull request Mar 11, 2022
@YutSean@apurtell
HBASE-26688Threads shared EMPTY_RESULT may lead to unexpected client…
44cae8f
… job down. (#4048)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@YutSean@Apache9
HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client…
51005ad
… job down. (apache#4048)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit fbd22f0)
Change-Id: I89bb6e991178b65e503988d8675eb0a19d9ee39f
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@Apache9
Revert "HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpecte…
742c5ef
…d client job down. (apache#4048)"
This reverts commit fbd22f0.
(cherry picked from commit 0af543c)
Change-Id: Ibd551e46e0bb88aca8f40d71fbb0cabacd2ab735
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YutSean@Apache-HBase@Apache9@bbeaudreault