Skip to content

Backport "HBASE-26614 Refactor code related to "dump"ing ZK nodes (#3969)" to branch-2.5 - #4062

Merged
ndimiduk merged 1 commit into
apache:branch-2.5from
ndimiduk:26614-refector-zkdump-branch-2.5
Jan 26, 2022
Merged

Backport "HBASE-26614 Refactor code related to "dump"ing ZK nodes (#3969)" to branch-2.5#4062
ndimiduk merged 1 commit into
apache:branch-2.5from
ndimiduk:26614-refector-zkdump-branch-2.5

Conversation

@ndimiduk

@ndimidukndimiduk commented Jan 25, 2022

Copy link
Copy Markdown
Member

The code starting at ZKUtil.dump(ZKWatcher) is a small mess – it has cyclic dependencies woven
through itself, ZKWatcher and RecoverableZooKeeper. It also initializes a static variable in
ZKUtil through the factory for RecoverableZooKeeper instances. Let's decouple and clean it
up.

Signed-off-by: Duo Zhang zhangduo@apache.org
Signed-off-by: Josh Elser elserj@apache.org

@ndimiduk
HBASE-26614 Refactor code related to "dump"ing ZK nodes (apache#3969)
f3252ba
The code starting at `ZKUtil.dump(ZKWatcher)` is a small mess – it has cyclic dependencies woven
through itself, `ZKWatcher` and `RecoverableZooKeeper`. It also initializes a static variable in
`ZKUtil` through the factory for `RecoverableZooKeeper` instances. Let's decouple and clean it
up.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Jan 25, 2022
@Apache-HBase

Apache-HBase commented Jan 25, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 29sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 59sbranch-2.5 passed
+1 💚compile2m 12sbranch-2.5 passed
+1 💚shadedjars6m 44sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 26sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall3m 45sthe patch passed
+1 💚compile2m 12sthe patch passed
+1 💚javac2m 12sthe patch passed
+1 💚shadedjars6m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 23sthe patch passed
_ Other Tests _
+1 💚unit0m 46shbase-zookeeper in the patch passed.
-1 ❌unit8m 10shbase-server in the patch failed.
+1 💚unit8m 7shbase-shell in the patch passed.
+1 💚unit0m 59shbase-it in the patch passed.
50m 29s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4062
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fb7c49267f10 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 0771c04
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/testReport/
Max. process+thread count2519 (vs. ulimit of 12500)
modulesC: hbase-zookeeper hbase-server hbase-shell hbase-it U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 25, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 31sbranch-2.5 passed
+1 💚compile2m 24sbranch-2.5 passed
+1 💚shadedjars7m 15sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 35sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall4m 14sthe patch passed
+1 💚compile2m 25sthe patch passed
+1 💚javac2m 25sthe patch passed
+1 💚shadedjars7m 15spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 32sthe patch passed
_ Other Tests _
+1 💚unit0m 46shbase-zookeeper in the patch passed.
-1 ❌unit7m 49shbase-server in the patch failed.
+1 💚unit6m 57shbase-shell in the patch passed.
+1 💚unit0m 55shbase-it in the patch passed.
51m 9s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4062
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 800f4c5145e7 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 0771c04
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/testReport/
Max. process+thread count2591 (vs. ulimit of 12500)
modulesC: hbase-zookeeper hbase-server hbase-shell hbase-it U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 25, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 26sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 54sbranch-2.5 passed
+1 💚compile5m 1sbranch-2.5 passed
+1 💚checkstyle1m 48sbranch-2.5 passed
+1 💚spotbugs3m 23sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 36sthe patch passed
+1 💚compile4m 51sthe patch passed
-0 ⚠️javac0m 29shbase-zookeeper generated 5 new + 105 unchanged - 6 fixed = 110 total (was 111)
+1 💚checkstyle1m 46sthe patch passed
+1 💚rubocop0m 8sThere were no new rubocop issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck21m 35sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚spotbugs3m 40sthe patch passed
_ Other Tests _
+1 💚asflicense0m 52sThe patch does not generate ASF License warnings.
61m 27s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4062
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop
unameLinux 9d232ea9fafa 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 0771c04
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
Max. process+thread count97 (vs. ulimit of 12500)
modulesC: hbase-zookeeper hbase-server hbase-shell hbase-it U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit 4d86d3b into apache:branch-2.5Jan 26, 2022
@ndimiduk
ndimiduk deleted the 26614-refector-zkdump-branch-2.5 branch January 26, 2022 17:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndimiduk@Apache-HBase