Skip to content

HBASE-26709 Ban the usage of junit 3 TestCase - #4065

Merged
Apache9 merged 2 commits into
apache:masterfrom
Apache9:HBASE-26709
Jan 27, 2022
Merged

HBASE-26709 Ban the usage of junit 3 TestCase#4065
Apache9 merged 2 commits into
apache:masterfrom
Apache9:HBASE-26709

Conversation

@Apache9

@Apache9Apache9 commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this Jan 26, 2022
@Apache-HBase

Apache-HBase commented Jan 26, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall4m 13smaster passed
+1 💚compile9m 32smaster passed
+1 💚checkstyle2m 1smaster passed
+1 💚spotbugs14m 24smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 53sthe patch passed
+1 💚compile8m 59sthe patch passed
-0 ⚠️javac8m 59sroot generated 3 new + 1622 unchanged - 4 fixed = 1625 total (was 1626)
+1 💚checkstyle1m 58sroot: The patch generated 0 new + 11 unchanged - 5 fixed = 11 total (was 16)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚hadoopcheck19m 51sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs14m 35sthe patch passed
_ Other Tests _
+1 💚asflicense0m 57sThe patch does not generate ASF License warnings.
90m 41s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4065
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
unameLinux 09d86f2b08d6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c33fa3a
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count141 (vs. ulimit of 30000)
modulesC: hbase-common hbase-http hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 26, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 53sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall5m 16smaster passed
+1 💚compile3m 54smaster passed
+1 💚shadedjars9m 45sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 52smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall5m 13sthe patch passed
+1 💚compile3m 51sthe patch passed
+1 💚javac3m 51sthe patch passed
+1 💚shadedjars8m 47spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 49sthe patch passed
_ Other Tests _
-1 ❌unit172m 48sroot in the patch failed.
224m 33s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4065
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4c0907688c62 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c33fa3a
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/testReport/
Max. process+thread count4010 (vs. ulimit of 30000)
modulesC: hbase-common hbase-http hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 26, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 52sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall4m 23smaster passed
+1 💚compile2m 54smaster passed
+1 💚shadedjars9m 39sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 39smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile3m 9sthe patch passed
+1 💚javac3m 9sthe patch passed
+1 💚shadedjars9m 3spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 33sthe patch passed
_ Other Tests _
-1 ❌unit365m 23sroot in the patch failed.
413m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4065
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 56c5be32d960 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c33fa3a
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/testReport/
Max. process+thread count4841 (vs. ulimit of 30000)
modulesC: hbase-common hbase-http hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 26, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for branch
+1 💚mvninstall5m 19smaster passed
+1 💚compile11m 26smaster passed
+1 💚checkstyle2m 32smaster passed
+1 💚spotbugs17m 44smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for patch
+1 💚mvninstall5m 9sthe patch passed
+1 💚compile11m 5sthe patch passed
+1 💚javac11m 5sroot generated 0 new + 1625 unchanged - 1 fixed = 1625 total (was 1626)
+1 💚checkstyle2m 32sroot: The patch generated 0 new + 11 unchanged - 5 fixed = 11 total (was 16)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚hadoopcheck24m 55sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs14m 37sthe patch passed
_ Other Tests _
+1 💚asflicense0m 57sThe patch does not generate ASF License warnings.
107m 24s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4065
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
unameLinux 608682791e0a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c33fa3a
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count141 (vs. ulimit of 30000)
modulesC: hbase-common hbase-http hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 26, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 56sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall5m 17smaster passed
+1 💚compile3m 37smaster passed
+1 💚shadedjars9m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 35smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall5m 6sthe patch passed
+1 💚compile3m 36sthe patch passed
+1 💚javac3m 36sthe patch passed
+1 💚shadedjars9m 12spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 35sthe patch passed
_ Other Tests _
+1 💚unit270m 21sroot in the patch passed.
319m 39s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4065
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 63a305e71dc8 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c33fa3a
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/testReport/
Max. process+thread count4443 (vs. ulimit of 30000)
modulesC: hbase-common hbase-http hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 26, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall3m 50smaster passed
+1 💚compile2m 44smaster passed
+1 💚shadedjars8m 16sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 28smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 55sthe patch passed
+1 💚compile2m 46sthe patch passed
+1 💚javac2m 46sthe patch passed
+1 💚shadedjars8m 25spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 27sthe patch passed
_ Other Tests _
-1 ❌unit361m 21sroot in the patch failed.
402m 24s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4065
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9b384fe8ca44 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c33fa3a
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/testReport/
Max. process+thread count4835 (vs. ulimit of 30000)
modulesC: hbase-common hbase-http hbase-server . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit f6348d4 into apache:masterJan 27, 2022
Apache9 added a commit that referenced this pull request Feb 9, 2022
@Apache9
HBASE-26709Ban the usage of junit 3 TestCase (#4065)
b64a507
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Apache9 added a commit that referenced this pull request Feb 9, 2022
@Apache9
HBASE-26709Ban the usage of junit 3 TestCase (#4065)
d747da6
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndimidukndimidukndimiduk approved these changes

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@ndimiduk