HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append by bbeaudreault · Pull Request #4074 · apache/hbase

bbeaudreault · 2022-01-27T14:37:26Z

Delete properly checked hasTimestamp, but I unified it under the new cellTimestampOrLatest method.

Note: I don't think Append is affected by this bug, because it used a version of toMutation which properly passes along timestamp even in old 1.x clients. But both Append/Increment are converted from proto using the same toDelta method, so I added the test case for both.

@apurtell

I think branch-2 will need a separate PR due to the changes in shaded ProtobufUtils, will get started on that.

apurtell · 2022-01-27T22:02:11Z

Changes look good, approved, waiting for precommit results before committing.

Apache-HBase · 2022-01-28T00:04:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 25s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	shadedjars	8m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 59s	the patch passed
+1 💚	compile	0m 28s	the patch passed
+1 💚	javac	0m 28s	the patch passed
+1 💚	shadedjars	8m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 20s	hbase-client in the patch passed.
		30m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4074
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 193a241bcc9c 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6348d4`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/2/testReport/
Max. process+thread count	345 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-28T00:23:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 18s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 42s	master passed
+1 💚	compile	0m 33s	master passed
+1 💚	shadedjars	9m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 34s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 32s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	shadedjars	9m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 2s	hbase-client in the patch passed.
		37m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4074
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1294e5edec5c 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6348d4`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/2/testReport/
Max. process+thread count	211 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-28T00:37:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 22s	master passed
+1 💚	compile	1m 14s	master passed
+1 💚	checkstyle	0m 43s	master passed
+1 💚	spotbugs	1m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 38s	the patch passed
+1 💚	compile	1m 8s	the patch passed
+1 💚	javac	1m 8s	the patch passed
-0 ⚠️	checkstyle	0m 38s	hbase-client: The patch generated 1 new + 181 unchanged - 0 fixed = 182 total (was 181)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	26m 1s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 29s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		55m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4074
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 54f0a7ac50a9 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6348d4`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

… Increment/Append

bbeaudreault · 2022-01-28T13:41:18Z

Force push just to rebase on latest master, which should fix the StackOverflowErrors and clear build here.

Apache-HBase · 2022-01-28T14:10:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 12s	master passed
+1 💚	compile	0m 29s	master passed
+1 💚	shadedjars	8m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 57s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	shadedjars	8m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 18s	hbase-client in the patch passed.
		29m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4074
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d636996c2152 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `056e8fb`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/3/testReport/
Max. process+thread count	347 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-28T14:12:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 49s	master passed
+1 💚	compile	0m 31s	master passed
+1 💚	shadedjars	8m 28s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 34s	the patch passed
+1 💚	compile	0m 31s	the patch passed
+1 💚	javac	0m 31s	the patch passed
+1 💚	shadedjars	8m 25s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 23s	hbase-client in the patch passed.
		31m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4074
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 00070f8af440 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `056e8fb`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/3/testReport/
Max. process+thread count	309 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-28T14:28:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 47s	master passed
+1 💚	compile	1m 1s	master passed
+1 💚	checkstyle	0m 34s	master passed
+1 💚	spotbugs	1m 8s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 23s	the patch passed
+1 💚	compile	0m 57s	the patch passed
+1 💚	javac	0m 57s	the patch passed
-0 ⚠️	checkstyle	0m 31s	hbase-client: The patch generated 1 new + 181 unchanged - 0 fixed = 182 total (was 181)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	22m 2s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 14s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		47m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4074
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux d061f5ca67c0 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `056e8fb`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4074/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault force-pushed the HBASE-26713 branch from 05ff78b to aedbb01Compare January 27, 2022 15:21

bbeaudreault mentioned this pull request Jan 27, 2022
HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append #4075
Merged

apurtell approved these changes Jan 27, 2022
View reviewed changes

virajjasani approved these changes Jan 28, 2022
View reviewed changes

HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on…
eb2862e
… Increment/Append

bbeaudreault force-pushed the HBASE-26713 branch from aedbb01 to eb2862eCompare January 28, 2022 13:40

apurtell merged commit 99b61f3 into apache:masterJan 28, 2022

charlesconnell deleted the HBASE-26713 branch September 19, 2025 15:18

Navigation Menu

Uh oh!

HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append - #4074

HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append#4074
apurtell merged 1 commit into
apache:masterfrom
HubSpot:HBASE-26713

bbeaudreault commented Jan 27, 2022•
edited
Loading

Uh oh!

apurtell commented Jan 27, 2022

Uh oh!

Apache-HBase commented Jan 28, 2022

Uh oh!

Apache-HBase commented Jan 28, 2022

Uh oh!

Apache-HBase commented Jan 28, 2022

Uh oh!

bbeaudreault commented Jan 28, 2022

Uh oh!

Apache-HBase commented Jan 28, 2022

Uh oh!

Apache-HBase commented Jan 28, 2022

Uh oh!

Apache-HBase commented Jan 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

bbeaudreault commented Jan 27, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

apurtell commented Jan 27, 2022

Uh oh!

Apache-HBase commented Jan 28, 2022

Uh oh!

Apache-HBase commented Jan 28, 2022

Uh oh!

Apache-HBase commented Jan 28, 2022

Uh oh!

bbeaudreault commented Jan 28, 2022

Uh oh!

Apache-HBase commented Jan 28, 2022

Uh oh!

Apache-HBase commented Jan 28, 2022

Uh oh!

Apache-HBase commented Jan 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bbeaudreault commented Jan 27, 2022•
edited
Loading