Skip to content

HBASE-26717 [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes - #4091

Open
apurtell wants to merge 1 commit into
apache:masterfrom
apurtell:HBASE-26717
Open

HBASE-26717 [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes#4091
apurtell wants to merge 1 commit into
apache:masterfrom
apurtell:HBASE-26717

Conversation

@apurtell

@apurtellapurtell commented Feb 2, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This is the hbase-http module side changes.
For hbase-thirdparty changes, see apache/hbase-thirdparty#73

@apurtell

apurtell commented Feb 2, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Update fixes assembly failures (LICENSE.vm update). We mention the EDL 1.0 (it's in category A) elsewhere but it's missing from non_aggregate_fine.

@Apache-HBase

Apache-HBase commented Feb 2, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for branch
+1 💚mvninstall4m 21smaster passed
+1 💚compile9m 44smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for patch
-1 ❌mvninstall3m 58sroot in the patch failed.
-1 ❌compile9m 36sroot in the patch failed.
-0 ⚠️javac9m 36sroot in the patch failed.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 7sThe patch has no ill-formed XML file.
-1 ❌hadoopcheck5m 16sThe patch causes 10 errors with Hadoop v3.1.2.
-1 ❌hadoopcheck10m 34sThe patch causes 10 errors with Hadoop v3.2.2.
-1 ❌hadoopcheck16m 5sThe patch causes 10 errors with Hadoop v3.3.1.
_ Other Tests _
+1 💚asflicense1m 10sThe patch does not generate ASF License warnings.
48m 32s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4091
Optional Testsdupname asflicense javac hadoopcheck xml compile
unameLinux 61559e1b35eb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3da23c2
Default JavaAdoptOpenJDK-1.8.0_282-b08
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/patch-compile-root.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/patch-compile-root.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/patch-javac-3.2.2.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/patch-javac-3.3.1.txt
Max. process+thread count141 (vs. ulimit of 30000)
modulesC: hbase-http hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 2, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall4m 46smaster passed
+1 💚compile3m 16smaster passed
+1 💚shadedjars8m 29sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
-1 ❌mvninstall3m 37sroot in the patch failed.
-1 ❌compile2m 45sroot in the patch failed.
-0 ⚠️javac2m 45sroot in the patch failed.
-1 ❌shadedjars7m 44spatch has 10 errors when building our shaded downstream artifacts.
+1 💚javadoc3m 53sthe patch passed
_ Other Tests _
-1 ❌unit163m 49sroot in the patch failed.
207m 5s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4091
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d28667a1f3a4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3da23c2
Default JavaAdoptOpenJDK-11.0.10+9
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/testReport/
Max. process+thread count3843 (vs. ulimit of 30000)
modulesC: hbase-http hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

Let's use another jira issue to commit this change?

@Apache-HBase

Apache-HBase commented Feb 2, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall4m 6smaster passed
+1 💚compile2m 47smaster passed
+1 💚shadedjars8m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 7smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
-1 ❌mvninstall3m 49sroot in the patch failed.
-1 ❌compile2m 48sroot in the patch failed.
-0 ⚠️javac2m 48sroot in the patch failed.
+1 💚shadedjars8m 18spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 12sthe patch passed
_ Other Tests _
-1 ❌unit374m 32sroot in the patch failed.
415m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4091
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 821c697dbf44 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3da23c2
Default JavaAdoptOpenJDK-1.8.0_282-b08
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/testReport/
Max. process+thread count5217 (vs. ulimit of 30000)
modulesC: hbase-http hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 2, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 6sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall4m 9smaster passed
+1 💚compile9m 2smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall3m 52sthe patch passed
+1 💚compile8m 58sthe patch passed
+1 💚javac8m 58sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 7sThe patch has no ill-formed XML file.
+1 💚hadoopcheck19m 35sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
_ Other Tests _
+1 💚asflicense1m 22sThe patch does not generate ASF License warnings.
60m 27s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4091
Optional Testsdupname asflicense javac hadoopcheck xml compile
unameLinux c3d22220521b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3da23c2
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count141 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-http hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 2, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 47sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 28sMaven dependency ordering for branch
+1 💚mvninstall5m 56smaster passed
+1 💚compile3m 58smaster passed
+1 💚shadedjars10m 55sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 55smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for patch
+1 💚mvninstall5m 47sthe patch passed
+1 💚compile3m 30sthe patch passed
+1 💚javac3m 30sthe patch passed
+1 💚shadedjars8m 24spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 11sthe patch passed
_ Other Tests _
+1 💚unit189m 55sroot in the patch passed.
247m 14s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4091
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1030e1d7ce10 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3da23c2
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/testReport/
Max. process+thread count6586 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-http hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 2, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 6sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall3m 52smaster passed
+1 💚compile2m 48smaster passed
+1 💚shadedjars9m 53sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 41smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall4m 6sthe patch passed
+1 💚compile2m 50sthe patch passed
+1 💚javac2m 50sthe patch passed
+1 💚shadedjars8m 31spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 31sthe patch passed
_ Other Tests _
-1 ❌unit370m 1sroot in the patch failed.
417m 18s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4091
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1e54732c5bbe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3da23c2
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/testReport/
Max. process+thread count5400 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-http hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Feb 19, 2022

Copy link
Copy Markdown
Contributor

Oh, I think the content is good, but I think think we'd better have another jira issue for landing this PR.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes
@busbeybusbeyAwaiting requested review from busbey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apurtell@Apache-HBase@Apache9