Skip to content

HBASE-26729 Backport "HBASE-26714 Introduce path configuration for sy… - #4093

Merged
taklwu merged 1 commit into
apache:branch-2from
taklwu:HBASE-26729
Feb 4, 2022
Merged

HBASE-26729 Backport "HBASE-26714 Introduce path configuration for sy…#4093
taklwu merged 1 commit into
apache:branch-2from
taklwu:HBASE-26729

Conversation

@taklwu

@taklwutaklwu commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

…stem coprocessors" to branch-2

  • rename from HBaseCommonTestingUtil to HBaseCommonTestingUtility

@taklwu
HBASE-26729 Backport "HBASE-26714 Introduce path configuration for sy…
1322eda
…stem coprocessors" to branch-2
- rename from HBaseCommonTestingUtil to HBaseCommonTestingUtility
taklwu
taklwu commented Feb 3, 2022
View reviewed changes
Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorHost.java
public static final HBaseClassTestRule CLASS_RULE =
HBaseClassTestRule.forClass(TestCoprocessorHost.class);

private static final HBaseCommonTestingUtility TEST_UTIL = new HBaseCommonTestingUtility();

@taklwutaklwuFeb 3, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this two lines related to HBaseCommonTestingUtility are the only changes from #4069

ankitsinghal
ankitsinghal approved these changes Feb 3, 2022
View reviewed changes

@ankitsinghalankitsinghal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Please commit once HBASE-26714 is already in.

@Apache-HBase

Apache-HBase commented Feb 3, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 10sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 15sbranch-2 passed
+1 💚compile4m 10sbranch-2 passed
+1 💚checkstyle1m 40sbranch-2 passed
+1 💚spotbugs3m 2sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 55sthe patch passed
+1 💚compile4m 8sthe patch passed
+1 💚javac4m 8sthe patch passed
+1 💚checkstyle1m 39sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck14m 4sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs3m 22sthe patch passed
_ Other Tests _
+1 💚asflicense0m 23sThe patch does not generate ASF License warnings.
56m 11s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4093
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 43657af407b0 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 08c2c65
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count86 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 4, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 10sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall5m 33sbranch-2 passed
+1 💚compile1m 58sbranch-2 passed
+1 💚shadedjars8m 26sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 17sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall5m 8sthe patch passed
+1 💚compile1m 53sthe patch passed
+1 💚javac1m 53sthe patch passed
+1 💚shadedjars8m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 26sthe patch passed
_ Other Tests _
+1 💚unit2m 41shbase-common in the patch passed.
+1 💚unit235m 14shbase-server in the patch passed.
277m 39s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4093
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8d7b2f4a904a 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 08c2c65
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/1/testReport/
Max. process+thread count2636 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 4, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 10sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 39sbranch-2 passed
+1 💚compile1m 36sbranch-2 passed
+1 💚shadedjars7m 24sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 2sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 19sthe patch passed
+1 💚compile1m 32sthe patch passed
+1 💚javac1m 32sthe patch passed
+1 💚shadedjars7m 33spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 0sthe patch passed
_ Other Tests _
+1 💚unit1m 55shbase-common in the patch passed.
+1 💚unit251m 25shbase-server in the patch passed.
287m 46s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4093
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0b5a5aad37e9 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 08c2c65
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/1/testReport/
Max. process+thread count2554 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@taklwu

taklwu commented Feb 4, 2022

Copy link
Copy Markdown
ContributorAuthor

everything comes back as +1s but the overall report said failed, I'm rerunning it and see if it will pass

@Apache-HBase

Apache-HBase commented Feb 4, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall4m 57sbranch-2 passed
+1 💚compile5m 5sbranch-2 passed
+1 💚checkstyle1m 57sbranch-2 passed
+1 💚spotbugs3m 44sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 54sthe patch passed
+1 💚compile5m 17sthe patch passed
+1 💚javac5m 17sthe patch passed
+1 💚checkstyle1m 50sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck17m 47sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs4m 7sthe patch passed
_ Other Tests _
+1 💚asflicense0m 27sThe patch does not generate ASF License warnings.
61m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4093
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 83efd3bd8ed5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 08c2c65
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 4, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 2sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall5m 3sbranch-2 passed
+1 💚compile1m 40sbranch-2 passed
+1 💚shadedjars8m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 8sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall4m 45sthe patch passed
+1 💚compile1m 43sthe patch passed
+1 💚javac1m 43sthe patch passed
+1 💚shadedjars8m 9spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 6sthe patch passed
_ Other Tests _
+1 💚unit1m 56shbase-common in the patch passed.
+1 💚unit206m 34shbase-server in the patch passed.
243m 56s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4093
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b382bde434b8 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 08c2c65
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/2/testReport/
Max. process+thread count2749 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 4, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 24sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for branch
+1 💚mvninstall3m 52sbranch-2 passed
+1 💚compile1m 25sbranch-2 passed
+1 💚shadedjars7m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 1sthe patch passed
+1 💚compile1m 24sthe patch passed
+1 💚javac1m 24sthe patch passed
+1 💚shadedjars7m 10spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57sthe patch passed
_ Other Tests _
+1 💚unit1m 50shbase-common in the patch passed.
+1 💚unit222m 40shbase-server in the patch passed.
255m 34s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4093
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0ba440f74496 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 08c2c65
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/2/testReport/
Max. process+thread count2668 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4093/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@taklwu
taklwu merged commit f637a60 into apache:branch-2Feb 4, 2022
taklwu added a commit that referenced this pull request Feb 4, 2022
@taklwu
HBASE-26729Backport "HBASE-26714Introduce path configuration for sy…
b8db5ac
…stem coprocessors" to branch-2 (#4093)
- rename from HBaseCommonTestingUtil to HBaseCommonTestingUtility
Signed-off-by: Ankit Singhal <ankit@apache.org>
@taklwu
taklwu deleted the HBASE-26729 branch February 4, 2022 15:05
asfgit pushed a commit that referenced this pull request Mar 11, 2022
@taklwu@apurtell
HBASE-26729Backport "HBASE-26714Introduce path configuration for sy…
b08321c
…stem coprocessors" to branch-2 (#4093)
- rename from HBaseCommonTestingUtil to HBaseCommonTestingUtility
Signed-off-by: Ankit Singhal <ankit@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@taklwuStephen Wu
HBASE-26729 Backport "HBASE-26714 Introduce path configuration for sy…
7374c7f
…stem coprocessors" to branch-2 (apache#4093)
- rename from HBaseCommonTestingUtil to HBaseCommonTestingUtility
Ref: CDPD-34102
Signed-off-by: Ankit Singhal <ankit@apache.org>
(cherry picked from commit b8db5ac)
Change-Id: Ib6e40aeb1d85951754c5b68f4373ab91130ea0e7
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitsinghalankitsinghalankitsinghal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taklwu@Apache-HBase@ankitsinghal