Uh oh!
There was an error while loading. Please reload this page.
HBASE-26730 Extend hbase shell 'status' command to support an option 'tasks' - #4094
Merged
Conversation
apurtellforce-pushed
the
HBASE-26730-branch-2
branch
from
February 4, 2022 02:30
7b187aa to
cfd925eCompareApache-HBase
commented
Feb 4, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 4, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 4, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 4, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 4, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 4, 2022
💔 -1 overall
This message was automatically generated. |
ContributorAuthor
Unit test failures are not related. Looks like it is about time to do a unit test cleanup on branch-2. |
| serverMetricsMap = new HashMap<>(); | ||
| } | ||
| final Map<ServerName, ServerMetrics> map = serverMetricsMap; | ||
| serverManager.getOnlineServers().entrySet() |
Contributor
There was a problem hiding this comment.
nit: could we factor out the common code into a helper rather than duplicating?
ContributorAuthor
There was a problem hiding this comment.
I suppose it is possible to collapse this into a single code block, would that be better? E.g.
boolean doTasks = false;
....
case TASKS: doTasks = true;
// fall through
case LIVE_SERVERS: {
...
// do stuff
if (doTasks) {
// do tasks stuff too, like the master monitoredtask collection
...
}
ContributorAuthor
There was a problem hiding this comment.
I did take up your suggestion to D.R.Y this and was able to remove some lines, it looks good @gjacoby126
Uh oh!
There was an error while loading. Please reload this page.
apurtellforce-pushed
the
HBASE-26730-branch-2
branch
from
February 10, 2022 18:30
cfd925e to
86ee7b4Compareapurtell
commented
Feb 10, 2022
ContributorAuthor
Rebased and addresses @gjacoby126 's feedback |
Apache-HBase
commented
Feb 10, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 10, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 10, 2022
🎊 +1 overall
This message was automatically generated. |
virajjasani
approved these changes
Feb 15, 2022
apurtell
commented
Feb 16, 2022
ContributorAuthor
As with the master PR will take care of the checkstyle issues before merge. |
…'tasks' Expose monitored tasks state in ClusterStatus API via new option in ServerLoad. Add shell support for interrogating monitored tasks state in ServerLoad.
…sks in 'tasks' view
apurtellforce-pushed
the
HBASE-26730-branch-2
branch
from
February 16, 2022 02:37
86ee7b4 to
716dad9Compareasfgit pushed a commit
that referenced
this pull request
Feb 16, 2022
…'tasks' (#4094) Signed-off-by: Geoffrey Jacoby <gjacoby@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose monitored tasks state in ClusterStatus API via new option in ServerLoad.
Add shell support for interrogating monitored tasks state in ServerLoad.
Here's a prototype running on a branch-2 fork:
: