Skip to content

HBASE-22739 check bound where removeRegion - #411

Closed
casuallc wants to merge 1 commit into
apache:branch-2.1from
casuallc:branch-2.1
Closed

HBASE-22739 check bound where removeRegion#411
casuallc wants to merge 1 commit into
apache:branch-2.1from
casuallc:branch-2.1

Conversation

@casuallc

@casuallccasuallc commented Jul 26, 2019

Copy link
Copy Markdown

@Apache-HBase

Apache-HBase commented Jul 26, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec76Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1mvninstall319branch-2.1 passed
+1compile57branch-2.1 passed
+1checkstyle88branch-2.1 passed
+1shadedjars281branch has no errors when building our shaded downstream artifacts.
+1javadoc42branch-2.1 passed
0spotbugs180Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs178branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall296the patch passed
+1compile58the patch passed
+1javac58the patch passed
-1checkstyle84hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1whitespace0The patch has no whitespace issues.
+1shadedjars273patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1326Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1javadoc35the patch passed
+1findbugs184the patch passed
_ Other Tests _
-1unit14933hbase-server in the patch failed.
+1asflicense22The patch does not generate ASF License warnings.
18651
ReasonTests
Failed junit testshadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
hadoop.hbase.client.TestAsyncClusterAdminApi2
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/1/artifact/out/Dockerfile
GITHUB PR#411
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux f81f0839677e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revisionbranch-2.1 / 100a625
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/1/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/1/testReport/
Max. process+thread count4546 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 27, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec105Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1mvninstall348branch-2.1 passed
+1compile53branch-2.1 passed
+1checkstyle78branch-2.1 passed
+1shadedjars244branch has no errors when building our shaded downstream artifacts.
+1javadoc34branch-2.1 passed
0spotbugs184Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs182branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall290the patch passed
+1compile56the patch passed
+1javac56the patch passed
-1checkstyle79hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1whitespace0The patch has no whitespace issues.
+1shadedjars236patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1346Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1javadoc33the patch passed
+1findbugs177the patch passed
_ Other Tests _
-1unit13645hbase-server in the patch failed.
+1asflicense30The patch does not generate ASF License warnings.
17316
ReasonTests
Failed junit testshadoop.hbase.replication.TestMasterReplication
hadoop.hbase.client.TestAdmin1
hadoop.hbase.replication.TestReplicationSmallTests
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/2/artifact/out/Dockerfile
GITHUB PR#411
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 77f4d2966b17 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revisionbranch-2.1 / fd26716
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/2/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/2/testReport/
Max. process+thread count5071 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 27, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec100Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1mvninstall356branch-2.1 passed
+1compile62branch-2.1 passed
+1checkstyle103branch-2.1 passed
+1shadedjars283branch has no errors when building our shaded downstream artifacts.
+1javadoc37branch-2.1 passed
0spotbugs195Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs193branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall322the patch passed
+1compile62the patch passed
+1javac62the patch passed
-1checkstyle94hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1whitespace0The patch has no whitespace issues.
+1shadedjars278patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1347Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1javadoc34the patch passed
+1findbugs186the patch passed
_ Other Tests _
-1unit13923hbase-server in the patch failed.
+1asflicense26The patch does not generate ASF License warnings.
17813
ReasonTests
Failed junit testshadoop.hbase.replication.regionserver.TestReplicationSource
hadoop.hbase.client.TestAdmin1
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/4/artifact/out/Dockerfile
GITHUB PR#411
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 10eb93d7d328 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revisionbranch-2.1 / f8b592e
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/4/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/4/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/4/testReport/
Max. process+thread count4344 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/4/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 27, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec67Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1mvninstall288branch-2.1 passed
+1compile50branch-2.1 passed
+1checkstyle73branch-2.1 passed
+1shadedjars237branch has no errors when building our shaded downstream artifacts.
+1javadoc36branch-2.1 passed
0spotbugs172Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs170branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall273the patch passed
+1compile57the patch passed
+1javac57the patch passed
-1checkstyle79hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1whitespace0The patch has no whitespace issues.
+1shadedjars234patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1164Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1javadoc33the patch passed
+1findbugs194the patch passed
_ Other Tests _
-1unit16861hbase-server in the patch failed.
+1asflicense95The patch does not generate ASF License warnings.
20282
ReasonTests
Failed junit testshadoop.hbase.quotas.TestSpaceQuotas
hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs
hadoop.hbase.replication.TestReplicationSmallTests
hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.replication.TestMasterReplication
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.client.TestAdmin1
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/3/artifact/out/Dockerfile
GITHUB PR#411
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux aee43a4b4871 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revisionbranch-2.1 / f8b592e
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/3/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/3/testReport/
Max. process+thread count4986 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 27, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec197Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1mvninstall466branch-2.1 passed
+1compile57branch-2.1 passed
+1checkstyle86branch-2.1 passed
+1shadedjars257branch has no errors when building our shaded downstream artifacts.
+1javadoc39branch-2.1 passed
0spotbugs181Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs178branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall329the patch passed
+1compile59the patch passed
+1javac59the patch passed
-1checkstyle72hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1whitespace0The patch has no whitespace issues.
+1shadedjars240patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1260Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1javadoc32the patch passed
+1findbugs165the patch passed
_ Other Tests _
-1unit15573hbase-server in the patch failed.
+1asflicense61The patch does not generate ASF License warnings.
19558
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/5/artifact/out/Dockerfile
GITHUB PR#411
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 89d4f7176330 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revisionbranch-2.1 / e54c401
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/5/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/5/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/5/testReport/
Max. process+thread count5148 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/5/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 28, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec64Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1mvninstall361branch-2.1 passed
+1compile70branch-2.1 passed
+1checkstyle104branch-2.1 passed
+1shadedjars322branch has no errors when building our shaded downstream artifacts.
+1javadoc43branch-2.1 passed
0spotbugs205Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs202branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall361the patch passed
+1compile67the patch passed
+1javac67the patch passed
-1checkstyle86hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1whitespace0The patch has no whitespace issues.
+1shadedjars291patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1483Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1javadoc40the patch passed
+1findbugs225the patch passed
_ Other Tests _
-1unit13890hbase-server in the patch failed.
+1asflicense33The patch does not generate ASF License warnings.
18105
ReasonTests
Failed junit testshadoop.hbase.client.TestAsyncTableGetMultiThreaded
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/6/artifact/out/Dockerfile
GITHUB PR#411
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 5856f5837720 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revisionbranch-2.1 / 31c99ff
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/6/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/6/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/6/testReport/
Max. process+thread count5208 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/6/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 29, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec78Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti1Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
-1mvninstall133root in branch-2.1 failed.
-1compile38hbase-server in branch-2.1 failed.
+1checkstyle73branch-2.1 passed
-1shadedjars166branch has 24 errors when building our shaded downstream artifacts.
+1javadoc29branch-2.1 passed
0spotbugs231Used deprecated FindBugs config; considering switching to SpotBugs.
-1findbugs35hbase-server in branch-2.1 failed.
_ Patch Compile Tests _
-1mvninstall134root in the patch failed.
-1compile37hbase-server in the patch failed.
-1javac37hbase-server in the patch failed.
-1checkstyle71hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1whitespace0The patch has no whitespace issues.
-1shadedjars166patch has 24 errors when building our shaded downstream artifacts.
-1hadoopcheck95The patch causes 24 errors with Hadoop v2.7.7.
-1hadoopcheck194The patch causes 24 errors with Hadoop v2.8.5.
-1hadoopcheck293The patch causes 24 errors with Hadoop v3.0.3.
-1hadoopcheck395The patch causes 24 errors with Hadoop v3.1.2.
+1javadoc29the patch passed
-1findbugs35hbase-server in the patch failed.
_ Other Tests _
-1unit36hbase-server in the patch failed.
+1asflicense10The patch does not generate ASF License warnings.
1526
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/Dockerfile
GITHUB PR#411
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 66bc47482314 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revisionbranch-2.1 / d45b2d4
Default Java1.8.0_181
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/branch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/branch-compile-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/branch-shadedjars.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/branch-findbugs-hbase-server.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-compile-hbase-server.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-compile-hbase-server.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-javac-2.7.7.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-javac-3.0.3.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-javac-3.1.2.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-findbugs-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/testReport/
Max. process+thread count96 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 30, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec63Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
-1mvninstall134root in branch-2.1 failed.
-1compile33hbase-server in branch-2.1 failed.
+1checkstyle69branch-2.1 passed
-1shadedjars159branch has 36 errors when building our shaded downstream artifacts.
+1javadoc29branch-2.1 passed
0spotbugs222Used deprecated FindBugs config; considering switching to SpotBugs.
-1findbugs33hbase-server in branch-2.1 failed.
_ Patch Compile Tests _
-1mvninstall131root in the patch failed.
-1compile34hbase-server in the patch failed.
-1javac34hbase-server in the patch failed.
-1checkstyle71hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1whitespace0The patch has no whitespace issues.
-1shadedjars160patch has 36 errors when building our shaded downstream artifacts.
-1hadoopcheck89The patch causes 36 errors with Hadoop v2.7.7.
-1hadoopcheck186The patch causes 36 errors with Hadoop v2.8.5.
-1hadoopcheck284The patch causes 36 errors with Hadoop v3.0.3.
-1hadoopcheck378The patch causes 36 errors with Hadoop v3.1.2.
+1javadoc29the patch passed
-1findbugs33hbase-server in the patch failed.
_ Other Tests _
-1unit33hbase-server in the patch failed.
+1asflicense9The patch does not generate ASF License warnings.
1453
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/Dockerfile
GITHUB PR#411
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 2f7040e2a26e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revisionbranch-2.1 / 65a6b27
Default Java1.8.0_181
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/branch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/branch-compile-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/branch-shadedjars.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/branch-findbugs-hbase-server.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-compile-hbase-server.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-compile-hbase-server.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-javac-2.7.7.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-javac-3.0.3.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-javac-3.1.2.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-findbugs-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/testReport/
Max. process+thread count87 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 30, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec40Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1mvninstall272branch-2.1 passed
+1compile49branch-2.1 passed
+1checkstyle74branch-2.1 passed
+1shadedjars233branch has no errors when building our shaded downstream artifacts.
+1javadoc31branch-2.1 passed
0spotbugs158Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs155branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall271the patch passed
+1compile51the patch passed
+1javac51the patch passed
-1checkstyle74hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1whitespace0The patch has no whitespace issues.
+1shadedjars228patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1134Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1javadoc36the patch passed
+1findbugs182the patch passed
_ Other Tests _
+1unit8339hbase-server in the patch passed.
+1asflicense26The patch does not generate ASF License warnings.
11536
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/9/artifact/out/Dockerfile
GITHUB PR#411
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 6a99de151a68 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revisionbranch-2.1 / 11b647b
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/9/artifact/out/diff-checkstyle-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/9/testReport/
Max. process+thread count4423 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/9/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 30, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec93Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1mvninstall320branch-2.1 passed
+1compile57branch-2.1 passed
+1checkstyle92branch-2.1 passed
+1shadedjars260branch has no errors when building our shaded downstream artifacts.
+1javadoc33branch-2.1 passed
0spotbugs187Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs185branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall321the patch passed
+1compile58the patch passed
+1javac58the patch passed
-1checkstyle92hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1whitespace0The patch has no whitespace issues.
+1shadedjars283patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1761Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1javadoc48the patch passed
+1findbugs220the patch passed
_ Other Tests _
-1unit14170hbase-server in the patch failed.
+1asflicense30The patch does not generate ASF License warnings.
18526
ReasonTests
Failed junit testshadoop.hbase.client.TestFromClientSide
hadoop.hbase.client.TestAdmin1
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/10/artifact/out/Dockerfile
GITHUB PR#411
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux b3f38f685855 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revisionbranch-2.1 / 29f8e19
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/10/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/10/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/10/testReport/
Max. process+thread count4828 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/10/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 30, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec121Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1mvninstall468branch-2.1 passed
+1compile52branch-2.1 passed
+1checkstyle78branch-2.1 passed
+1shadedjars256branch has no errors when building our shaded downstream artifacts.
+1javadoc31branch-2.1 passed
0spotbugs170Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs167branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall299the patch passed
+1compile50the patch passed
+1javac50the patch passed
-1checkstyle73hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1whitespace0The patch has no whitespace issues.
+1shadedjars228patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1227Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1javadoc31the patch passed
+1findbugs162the patch passed
_ Other Tests _
+1unit12696hbase-server in the patch passed.
+1asflicense33The patch does not generate ASF License warnings.
16328
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/11/artifact/out/Dockerfile
GITHUB PR#411
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 0a0ec76dff95 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revisionbranch-2.1 / 29f8e19
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/11/artifact/out/diff-checkstyle-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/11/testReport/
Max. process+thread count4992 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/11/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 30, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec66Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1mvninstall364branch-2.1 passed
+1compile66branch-2.1 passed
+1checkstyle91branch-2.1 passed
+1shadedjars299branch has no errors when building our shaded downstream artifacts.
+1javadoc42branch-2.1 passed
0spotbugs205Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs202branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall351the patch passed
+1compile66the patch passed
+1javac66the patch passed
-1checkstyle96hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1whitespace0The patch has no whitespace issues.
+1shadedjars301patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1446Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1javadoc43the patch passed
+1findbugs205the patch passed
_ Other Tests _
-1unit13960hbase-server in the patch failed.
+1asflicense30The patch does not generate ASF License warnings.
18058
ReasonTests
Failed junit testshadoop.hbase.client.TestAsyncTableGetMultiThreaded
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/12/artifact/out/Dockerfile
GITHUB PR#411
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 88412f50d540 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revisionbranch-2.1 / 29f8e19
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/12/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/12/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/12/testReport/
Max. process+thread count5031 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/12/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 31, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec363Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1mvninstall329branch-2.1 passed
+1compile57branch-2.1 passed
+1checkstyle93branch-2.1 passed
+1shadedjars256branch has no errors when building our shaded downstream artifacts.
+1javadoc34branch-2.1 passed
0spotbugs176Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs174branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall311the patch passed
+1compile55the patch passed
+1javac55the patch passed
-1checkstyle91hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1whitespace0The patch has no whitespace issues.
+1shadedjars268patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1416Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1javadoc36the patch passed
+1findbugs184the patch passed
_ Other Tests _
-1unit11592hbase-server in the patch failed.
+1asflicense28The patch does not generate ASF License warnings.
15718
ReasonTests
Failed junit testshadoop.hbase.client.TestFromClientSide3
hadoop.hbase.TestRegionRebalancing
hadoop.hbase.master.TestCatalogJanitorCluster
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/15/artifact/out/Dockerfile
GITHUB PR#411
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux e0ba864c4955 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revisionbranch-2.1 / 9799e0b
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/15/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/15/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/15/testReport/
Max. process+thread count4627 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/15/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Reidddddd
Reidddddd reviewed Jul 31, 2019
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
break;
}
if (i == regions.length - 1) {
return Arrays.copyOf(regions, regions.length);

@ReiddddddReiddddddJul 31, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here i think we can just return regions. No need to copy the entire array, unless you have a strong reason.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ReiddddddReiddddddReidddddd left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@casuallc@Apache-HBase@Reidddddd