Skip to content

HBASE-26762: Un-Deprecate and improve documentation for Scan#setRowPrefixFilter - #4119

Merged
Apache9 merged 5 commits into
apache:masterfrom
nielsbasjes:HBASE-26762-setRowPrefixFilter
Mar 2, 2022
Merged

HBASE-26762: Un-Deprecate and improve documentation for Scan#setRowPrefixFilter#4119
Apache9 merged 5 commits into
apache:masterfrom
nielsbasjes:HBASE-26762-setRowPrefixFilter

Conversation

@nielsbasjes

@nielsbasjesnielsbasjes commented Feb 19, 2022

Copy link
Copy Markdown
Contributor

Issue https://issues.apache.org/jira/browse/HBASE-26762

I found today that with ticket https://issues.apache.org/jira/browse/HBASE-25299 the intended effects of Scan#setRowPrefixFilter were unclear (hence the report of unexpected effects) and instead of just improving the documentation the method was marked as deprecated.

Quote:

@deprecated since 3.0.0. The scan result might be unexpected in some cases.

Yes, if you use this very valuable method incorrectly it will yield incorrect results.

I strongly disagree with this deprecation because it is one of the most used methods of Scan in many of my applications.

I do agree the documentation should more clearly indicate these combinations do not work.

This pull request does only 2 things:

  • Remove the deprecation
  • Improve the documentation.

@nielsbasjes

nielsbasjes commented Feb 19, 2022

Copy link
Copy Markdown
ContributorAuthor

I'm in doubt about the test that was added testRowPrefixFilterAndStartRow :
https://github.com/apache/hbase/blob/master/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestScanRowPrefix.java#L234

This is effectively showing that if you use these functions incorrectly you get unexpected results.

@nielsbasjes
nielsbasjesforce-pushed the HBASE-26762-setRowPrefixFilter branch from fe6c4b9 to d35632fCompareFebruary 19, 2022 16:35
@nielsbasjes

nielsbasjes commented Feb 20, 2022

Copy link
Copy Markdown
ContributorAuthor

As discussed with Duo Zhang I'm re-deprecating the old name and providing a replacement with a better (non-confusing) name: setStartStopRowForPrefixScan

In addition to the Scan related method I found that both of these classes also have a method with the same name "setRowPrefixFilter"

./hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
This seems to be only used by this class: so I'm not going to change it.

./hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
Here it is a private method that actually uses the PrefixFilter class: so I'm not going to change it.

@Apache-HBase

Apache-HBase commented Feb 23, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall3m 9smaster passed
+1 💚compile8m 10smaster passed
+1 💚checkstyle1m 14smaster passed
+0 🆗refguide3m 1sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs12m 57smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 15sthe patch passed
+1 💚compile7m 9sthe patch passed
-0 ⚠️javac7m 9sroot generated 3 new + 1622 unchanged - 3 fixed = 1625 total (was 1625)
-0 ⚠️checkstyle1m 17sroot: The patch generated 2 new + 7 unchanged - 1 fixed = 9 total (was 8)
+1 💚rubocop0m 3sThere were no new rubocop issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+0 🆗refguide1m 39spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck12m 32sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs12m 18sthe patch passed
_ Other Tests _
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
80m 19s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4119
JIRA IssueHBASE-26762
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop refguide
unameLinux 086d259057a6 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cd45cad
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4119/1/yetus-general-check/output/branch-site/book.html
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4119/1/yetus-general-check/output/patch-site/book.html
Max. process+thread count87 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 23, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 58sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 59smaster passed
+1 💚compile2m 39smaster passed
+1 💚shadedjars5m 47sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 17smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 33sthe patch passed
+1 💚compile2m 32sthe patch passed
+1 💚javac2m 32sthe patch passed
+1 💚shadedjars5m 53spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 41sthe patch passed
_ Other Tests _
+1 💚unit431m 19sroot in the patch passed.
467m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4119
JIRA IssueHBASE-26762
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8403d238be9f 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cd45cad
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/1/testReport/
Max. process+thread count2477 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 23, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 29sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 11smaster passed
+1 💚compile2m 7smaster passed
+1 💚shadedjars5m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 55smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 0sthe patch passed
+1 💚compile1m 59sthe patch passed
+1 💚javac1m 59sthe patch passed
+1 💚shadedjars5m 33spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 47sthe patch passed
_ Other Tests _
-1 ❌unit552m 26sroot in the patch failed.
585m 11s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4119
JIRA IssueHBASE-26762
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8cca2496482d 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cd45cad
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/1/testReport/
Max. process+thread count1625 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@nielsbasjes
HBASE-26762: Un-Deprecate and improve documentation for Scan#setRowPr…
b45a805
…efixFilter
Signed-off-by: Niels Basjes <nielsbasjes@apache.org>
@nielsbasjes
HBASE-26762: Remove test that proves incorrect usage yields unexpecte…
a064359
…d results
Signed-off-by: Niels Basjes <nielsbasjes@apache.org>
@nielsbasjes
HBASE-26762: Rename and deprecate setRowPrefixFilter to setStartStopR…
3129b5f
…owForPrefixScan
Signed-off-by: Niels Basjes <nielsbasjes@apache.org>
@nielsbasjes
nielsbasjesforce-pushed the HBASE-26762-setRowPrefixFilter branch from 20500dd to 3129b5fCompareFebruary 23, 2022 20:50
@Apache-HBase

Apache-HBase commented Feb 23, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 38smaster passed
+1 💚compile5m 39smaster passed
+1 💚checkstyle1m 7smaster passed
+0 🆗refguide2m 2sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs8m 53smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall2m 22sthe patch passed
+1 💚compile5m 28sthe patch passed
+1 💚javac5m 28sthe patch passed
-0 ⚠️checkstyle1m 7sroot: The patch generated 2 new + 7 unchanged - 1 fixed = 9 total (was 8)
+1 💚rubocop0m 3sThere were no new rubocop issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+0 🆗refguide1m 36spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck11m 50sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs9m 7sthe patch passed
_ Other Tests _
+1 💚asflicense0m 30sThe patch does not generate ASF License warnings.
58m 52s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4119
JIRA IssueHBASE-26762
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop refguide
unameLinux bb3bbea1b2ca 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cd45cad
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4119/2/yetus-general-check/output/branch-site/book.html
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4119/2/yetus-general-check/output/patch-site/book.html
Max. process+thread count87 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 24, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 37sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 45sMaven dependency ordering for branch
+1 💚mvninstall3m 14smaster passed
+1 💚compile1m 59smaster passed
+1 💚shadedjars5m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 34smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 54sthe patch passed
+1 💚compile1m 58sthe patch passed
+1 💚javac1m 58sthe patch passed
+1 💚shadedjars5m 18spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 33sthe patch passed
_ Other Tests _
+1 💚unit395m 43sroot in the patch passed.
428m 43s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4119
JIRA IssueHBASE-26762
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 301cfdf2f82f 5.4.0-1047-aws #49~18.04.1-Ubuntu SMP Wed Apr 28 23:08:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cd45cad
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/2/testReport/
Max. process+thread count2570 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 24, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 1sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 44smaster passed
+1 💚compile1m 44smaster passed
+1 💚shadedjars4m 43sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 18smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 24sthe patch passed
+1 💚compile1m 46sthe patch passed
+1 💚javac1m 46sthe patch passed
+1 💚shadedjars4m 40spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 20sthe patch passed
_ Other Tests _
+1 💚unit557m 1sroot in the patch passed.
583m 1s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4119
JIRA IssueHBASE-26762
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 06f18fe96a79 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cd45cad
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/2/testReport/
Max. process+thread count2330 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Feb 26, 2022

Copy link
Copy Markdown
Contributor

Oh, one minor thing, I think we could also cherry-pick this change to branch-2 and branch-2.5, so let's change the javadoc from 'since 3.0.0' to 'since 2.5.0'?

Thanks.

@nielsbasjes
HBASE-26762: Deprecate setRowPrefixFilter since 2.5.0
2f04027
Signed-off-by: Niels Basjes <nielsbasjes@apache.org>
@nielsbasjes

nielsbasjes commented Feb 26, 2022

Copy link
Copy Markdown
ContributorAuthor

I've pushed it with since 2.5.0 now.
I assume

  • you guys will squash and rewrite the commits the way you want them.
  • the old method will be removed from 3.0.0 after this has been merged.

Just let me know if I have to do something from here.

@Apache9

Apache9 commented Feb 26, 2022

Copy link
Copy Markdown
Contributor

Our guideline is to remove a method which has been marked as deprecated for a whole major release, so usually, if a method is deprecated in 2.5.0, we will remove it in 4.0.0. Unless we found that this is a mistake, or the behavior is really confusing, we will remove it more aggressively.

For this method, since it has been there for a long time, I tend to keep it there and only remove it in 4.0.0, so you could modify the javadoc to 'since 3.0.0, will be removed in 4.0.0'.

And please fix the checkstyle issues? They are both line length issue, a simple format is enough to fix them.

Thanks.

@Apache-HBase

Apache-HBase commented Feb 26, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 18sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 40smaster passed
+1 💚compile5m 44smaster passed
+1 💚checkstyle1m 10smaster passed
+0 🆗refguide2m 12sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs8m 59smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 21sthe patch passed
+1 💚compile5m 47sthe patch passed
+1 💚javac5m 47sthe patch passed
-0 ⚠️checkstyle1m 10sroot: The patch generated 2 new + 7 unchanged - 1 fixed = 9 total (was 8)
+1 💚rubocop0m 3sThere were no new rubocop issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+0 🆗refguide1m 47spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck11m 23sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs9m 24sthe patch passed
_ Other Tests _
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
59m 14s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4119
JIRA IssueHBASE-26762
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop refguide
unameLinux fc6e00ffc8b5 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5dc663e
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4119/3/yetus-general-check/output/branch-site/book.html
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4119/3/yetus-general-check/output/patch-site/book.html
Max. process+thread count87 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@nielsbasjes
HBASE-26762: Update javadoc and fix checkstyle issues
e8f9a0b
Signed-off-by: Niels Basjes <nielsbasjes@apache.org>
@nielsbasjes

nielsbasjes commented Feb 26, 2022

Copy link
Copy Markdown
ContributorAuthor

@Apache9

For this method, since it has been there for a long time, I tend to keep it there
and only remove it in 4.0.0, so you could modify the javadoc to
'since 3.0.0, will be removed in 4.0.0'.

I think this should be 'since 2.5.0, will be removed in 4.0.0' ?

And please fix the checkstyle issues? They are both line length issue, a simple format is enough to fix them.

Done.

@Apache-HBase

Apache-HBase commented Feb 26, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 15smaster passed
+1 💚compile2m 3smaster passed
+1 💚shadedjars5m 27sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 37smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall2m 56sthe patch passed
+1 💚compile2m 0sthe patch passed
+1 💚javac2m 0sthe patch passed
+1 💚shadedjars5m 21spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 36sthe patch passed
_ Other Tests _
+1 💚unit402m 23sroot in the patch passed.
432m 3s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4119
JIRA IssueHBASE-26762
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a0576043e401 5.4.0-1047-aws #49~18.04.1-Ubuntu SMP Wed Apr 28 23:08:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5dc663e
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/3/testReport/
Max. process+thread count2537 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 27, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 27smaster passed
+1 💚compile1m 45smaster passed
+1 💚shadedjars4m 41sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 19smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 26sthe patch passed
+1 💚compile1m 41sthe patch passed
+1 💚javac1m 41sthe patch passed
+1 💚shadedjars4m 42spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 17sthe patch passed
_ Other Tests _
+1 💚unit557m 31sroot in the patch passed.
583m 37s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4119
JIRA IssueHBASE-26762
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f0250ae02710 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5dc663e
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/3/testReport/
Max. process+thread count2352 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 27, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 17sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 37smaster passed
+1 💚compile5m 45smaster passed
+1 💚checkstyle1m 9smaster passed
+0 🆗refguide2m 9sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs9m 10smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 21sthe patch passed
+1 💚compile5m 44sthe patch passed
+1 💚javac5m 44sthe patch passed
+1 💚checkstyle1m 8sroot: The patch generated 0 new + 7 unchanged - 1 fixed = 7 total (was 8)
+1 💚rubocop0m 3sThere were no new rubocop issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+0 🆗refguide1m 50spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck11m 17sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs9m 33sthe patch passed
_ Other Tests _
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
59m 12s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4119
JIRA IssueHBASE-26762
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop refguide
unameLinux 6c2c9c5878ad 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5dc663e
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4119/4/yetus-general-check/output/branch-site/book.html
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4119/4/yetus-general-check/output/patch-site/book.html
Max. process+thread count87 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/4/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 27, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for branch
+1 💚mvninstall2m 58smaster passed
+1 💚compile2m 0smaster passed
+1 💚shadedjars5m 20sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 35smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 52sthe patch passed
+1 💚compile2m 0sthe patch passed
+1 💚javac2m 0sthe patch passed
+1 💚shadedjars5m 22spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 35sthe patch passed
_ Other Tests _
+1 💚unit399m 21sroot in the patch passed.
428m 1s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4119
JIRA IssueHBASE-26762
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4c731463491a 5.4.0-1047-aws #49~18.04.1-Ubuntu SMP Wed Apr 28 23:08:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5dc663e
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/4/testReport/
Max. process+thread count2578 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Feb 27, 2022

Copy link
Copy Markdown
Contributor

@Apache9

For this method, since it has been there for a long time, I tend to keep it there
and only remove it in 4.0.0, so you could modify the javadoc to
'since 3.0.0, will be removed in 4.0.0'.

I think this should be 'since 2.5.0, will be removed in 4.0.0' ?
Ah, yes... Thank you!

And please fix the checkstyle issues? They are both line length issue, a simple format is enough to fix them.

Done.

@Apache-HBase

Apache-HBase commented Feb 27, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 12sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 36smaster passed
+1 💚compile1m 43smaster passed
+1 💚shadedjars4m 42sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 14smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 23sthe patch passed
+1 💚compile1m 44sthe patch passed
+1 💚javac1m 44sthe patch passed
+1 💚shadedjars4m 41spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 15sthe patch passed
_ Other Tests _
+1 💚unit555m 15sroot in the patch passed.
580m 56s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4119
JIRA IssueHBASE-26762
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f2dc6ab78b49 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5dc663e
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/4/testReport/
Max. process+thread count2347 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4119/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@nielsbasjes

nielsbasjes commented Feb 28, 2022

Copy link
Copy Markdown
ContributorAuthor

Is there anything I can do to fix this last error?

https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4119/4/pipeline#step-152-log-2

[2022-02-27T10:35:26.002Z] Recording test results
[2022-02-27T10:35:27.986Z] [Checks API] No suitable checks publisher found.

@Apache9
Apache9 merged commit f6b74b3 into apache:masterMar 2, 2022
@nielsbasjes
nielsbasjes deleted the HBASE-26762-setRowPrefixFilter branch March 2, 2022 12:19
Apache9 pushed a commit that referenced this pull request Mar 2, 2022
@nielsbasjes@Apache9
HBASE-26762Un-Deprecate and improve documentation for Scan#setRowPre…
4858b25
…fixFilter (#4119)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Mar 2, 2022
@nielsbasjes@Apache9
HBASE-26762Un-Deprecate and improve documentation for Scan#setRowPre…
c5f6355
…fixFilter (#4119)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apurtellapurtellapurtell approved these changes
@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nielsbasjes@Apache-HBase@Apache9@apurtell