a bug of checking if restoreDir is subDir of rootDir

[VincentChoiCN]

The restoreDir shouldn't be a sub directory of rootDir. The code check it with a prefix check "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it goes error in some reasonable cases.

eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I think it's more reasonable to chang the code to "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )".

jira:https://issues.apache.org/jira/browse/HBASE-22070

[VincentChoiCN]

@Apache9 , Could you take a look at it, Please?

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	28	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.0 Compile Tests _
+1	mvninstall	191	branch-2.0 passed
+1	compile	120	branch-2.0 passed
+1	checkstyle	70	branch-2.0 passed
+1	shadedjars	250	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	142	branch-2.0 passed
+1	javadoc	32	branch-2.0 passed
		_ Patch Compile Tests _
+1	mvninstall	173	the patch passed
+1	compile	118	the patch passed
+1	javac	118	the patch passed
-1	checkstyle	68	hbase-server: The patch generated 1 new + 17 unchanged - 0 fixed = 18 total (was 17)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	247	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	533	Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
+1	findbugs	154	the patch passed
+1	javadoc	31	the patch passed
		_ Other Tests _
+1	unit	7719	hbase-server in the patch passed.
+1	asflicense	22	The patch does not generate ASF License warnings.
		9984

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-109/1/artifact/out/Dockerfile
GITHUB PR	#109
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 5b810723f00c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.0 / 381a0d5
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.0-RC3
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-109/1/artifact/out/diff-checkstyle-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-109/1/testReport/
Max. process+thread count	4487 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-109/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

[petersomogyi]

Merged patch from Jira.