Skip to content

HBASE-26784 Addendum: Close scanner request should properly inherit original timeout and priority - #4183

Merged
apurtell merged 1 commit into
apache:branch-2from
HubSpot:HBASE-26784-2-addendum
Mar 8, 2022
Merged

HBASE-26784 Addendum: Close scanner request should properly inherit original timeout and priority#4183
apurtell merged 1 commit into
apache:branch-2from
HubSpot:HBASE-26784-2-addendum

Conversation

@bbeaudreault

Copy link
Copy Markdown
Contributor

Fixes a bug in the original implementation in #4163, wherein we attempted to inherit the original controller priority/timeout but accidentally was using the same HBaseRpcController for both reading and writing the fields.

Improves tests to ensure that we are properly inheriting these fields.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 0sbranch-2 passed
+1 💚compile0m 22sbranch-2 passed
+1 💚shadedjars3m 31sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 47sthe patch passed
+1 💚compile0m 21sthe patch passed
+1 💚javac0m 21sthe patch passed
+1 💚shadedjars3m 29spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 19sthe patch passed
_ Other Tests _
+1 💚unit3m 24shbase-client in the patch passed.
19m 13s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4183/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4183
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1f89d90ca5eb 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5bae04e
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4183/1/testReport/
Max. process+thread count157 (vs. ulimit of 12500)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4183/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault
bbeaudreaultforce-pushed the HBASE-26784-2-addendum branch from 53402aa to aa6f13eCompareMarch 8, 2022 15:46
@bbeaudreault

bbeaudreault commented Mar 8, 2022

Copy link
Copy Markdown
ContributorAuthor

Build failed due to "no space left on device". Force pushed to re-run build, hopefully I'll get a different host.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 39sbranch-2 passed
+1 💚compile0m 22sbranch-2 passed
+1 💚shadedjars3m 29sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 19sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 49sthe patch passed
+1 💚compile0m 21sthe patch passed
+1 💚javac0m 21sthe patch passed
+1 💚shadedjars3m 29spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 19sthe patch passed
_ Other Tests _
+1 💚unit3m 27shbase-client in the patch passed.
18m 54s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4183/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4183
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a230ca7c0e87 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5bae04e
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4183/2/testReport/
Max. process+thread count157 (vs. ulimit of 12500)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4183/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
apurtell merged commit 98836fb into apache:branch-2Mar 8, 2022
asfgit pushed a commit that referenced this pull request Mar 8, 2022
…riginal timeout and priority (#4183)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
@charlesconnell
charlesconnell deleted the HBASE-26784-2-addendum branch September 19, 2025 15:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bbeaudreault@Apache-HBase@apurtell