HBASE-26791 Memstore flush fencing issue for SFT by Apache9 · Pull Request #4202 · apache/hbase

Apache9 · 2022-03-10T16:21:04Z

No description provided.

Apache-HBase · 2022-03-10T18:51:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 34s	master passed
+1 💚	compile	2m 51s	master passed
+1 💚	checkstyle	0m 42s	master passed
+1 💚	spotbugs	1m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 12s	the patch passed
+1 💚	compile	2m 45s	the patch passed
+1 💚	javac	2m 45s	the patch passed
+1 💚	checkstyle	0m 44s	the patch passed
-0 ⚠️	whitespace	0m 0s	The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	hadoopcheck	14m 52s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 51s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		39m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4202
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux b99e2cbd859b 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4da53ef`
Default Java	AdoptOpenJDK-1.8.0_282-b08
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/1/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-11T00:01:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 3s	master passed
+1 💚	compile	0m 59s	master passed
+1 💚	shadedjars	4m 26s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	0m 53s	the patch passed
+1 💚	javac	0m 53s	the patch passed
+1 💚	shadedjars	4m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	the patch passed
		_ Other Tests _
+1 💚	unit	328m 26s	hbase-server in the patch passed.
		350m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4202
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8880cb371498 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4da53ef`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/1/testReport/
Max. process+thread count	2295 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser

Maybe I'm missing it, but I think there's still a chance for race condition here. Let me try to summarize how I think you're solving this and you can correct me.

We add a sequence id (the current timestamp or one more than the previous ID if we have a clock skew) for each store's tracker. This sequence id is included in the filename for uniqueness. When we write a new tracker out, we increment the id. When we go to load a store, we find the largest ID and pick that seqID's tracker file to load. After we pick the biggest seqId tracker, we delete any trackers older than the one we picked.

RS1 makes a tracker for storeA with seq=1
RS1 goes zombie
RS2 gets assignment for storeA opens seq=2
RS1 wakes up and tries to memstore flush

I'm confused because I feel like we will call load(false) which would just write a new tracker file with the newer time (or seqId + 1). I will totally admit I am probably just getting it by reading the code.

joshelser · 2022-03-12T15:56:01Z

+ // since read only is true, we should not delete the old track file
+ // the deletion is in background, so sleep a bit then assert
+ Thread.sleep(2000);
+ assertTrue(fs.exists(trackFileStatus.getPath()));


Use the HTU.Waiter to check a few times please.

joshelser · 2022-03-12T16:24:44Z

Bump the timestamp/sequenceid, to a value greater than the loaded timestamp/sequenceid, and we will use this timestamp/sequenceid as new track file names.
In this way, the old rs will only overwrite the track files with old timestamp/sequenceid, so it will not effect the new track files. So the problem can be solved.

Ah, so is it that we use the sequenceId only when opening the Region (store). After the region is open, choosing whether to use f1 or f2 is then based on what getTimestamp() returns for those two files? That makes more sense.

Sorry I missed your explanation on Jira.

joshelser · 2022-03-12T16:30:43Z

Some general thinking about this (not specific to your changes)

Could we use the RS start code instead of a new timestamp/seqId? Those should already be unique across RS and that might help in debugging after the fact.
Do we still need the f1 and f2 files? Could we do away with having two per RS?

Apache9 · 2022-03-13T13:14:10Z

Maybe I'm missing it, but I think there's still a chance for race condition here. Let me try to summarize how I think you're solving this and you can correct me.
We add a sequence id (the current timestamp or one more than the previous ID if we have a clock skew) for each store's tracker. This sequence id is included in the filename for uniqueness. When we write a new tracker out, we increment the id. When we go to load a store, we find the largest ID and pick that seqID's tracker file to load. After we pick the biggest seqId tracker, we delete any trackers older than the one we picked.
RS1 makes a tracker for storeA with seq=1
RS1 goes zombie
RS2 gets assignment for storeA opens seq=2
RS1 wakes up and tries to memstore flush
I'm confused because I feel like we will call load(false) which would just write a new tracker file with the newer time (or seqId + 1). I will totally admit I am probably just getting it by reading the code.

Ah you have missed a very important point... We will only bump the sequence id when loading at the primary replica(i.e, readOnly = false), this means we will only bump the sequence id when opening a region, so the scenario you described above has no problem. RS1 will only write the files with old sequence id while RS2 will write the files with new(greater) sequence id. This is the key trick here to solve the problem.

Apache9 · 2022-03-13T13:26:09Z

Some general thinking about this (not specific to your changes)
Could we use the RS start code instead of a new timestamp/seqId? Those should already be unique across RS and that might help in debugging after the fact.
Do we still need the f1 and f2 files? Could we do away with having two per RS?

As explained above, the key here is to make sure that the sequence id of the SFT files written by the new RS is greater than the ones written by the old RS. So the answer of these two questions are pretty easy:

No, we can not. The start code of the 'new' RS may be less than the 'old' RS, as here, 'new' and 'old' just mean we reassigned a region from the 'old' to 'new', does not mean the 'new' RS is started after the 'old' RS.
To preventing the 'old' RS write SFT files with greater sequence id, we'd better not increase the sequence id when writing them on the same RS, so we'd better still use the old mechanism when writing, i.e, switch between the two SFT files.

wchevreuil

Overall, LGTM. Had made some nit comments on the subject of logging/supportability.

Test wise, could we add a test that mimics the issue, by instantiate two StoreFileListFile instances, update both with different store files, then check these updates don't reflect on each other lists of store files?

Apache-HBase · 2022-03-19T03:39:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 20s	master passed
+1 💚	compile	2m 14s	master passed
+1 💚	checkstyle	0m 36s	master passed
+1 💚	spotbugs	1m 18s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 10s	the patch passed
+1 💚	compile	2m 14s	the patch passed
+1 💚	javac	2m 14s	the patch passed
+1 💚	checkstyle	0m 36s	the patch passed
-0 ⚠️	whitespace	0m 0s	The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	hadoopcheck	11m 26s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 22s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		29m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4202
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 1f07300b113d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1d38db9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/2/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-19T06:15:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 24s	master passed
+1 💚	compile	0m 37s	master passed
+1 💚	shadedjars	3m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 10s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	shadedjars	3m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	168m 42s	hbase-server in the patch passed.
		185m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4202
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux dcfc6e9240f2 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1d38db9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/2/testReport/
Max. process+thread count	2696 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-19T06:18:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 55s	master passed
+1 💚	compile	0m 43s	master passed
+1 💚	shadedjars	4m 4s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	0m 43s	the patch passed
+1 💚	javac	0m 43s	the patch passed
+1 💚	shadedjars	4m 2s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	169m 24s	hbase-server in the patch passed.
		188m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4202
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0e5a2acee584 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1d38db9`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/2/testReport/
Max. process+thread count	2673 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-19T06:52:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 45s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 1s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 36s	master passed
+1 💚	compile	2m 22s	master passed
+1 💚	checkstyle	0m 38s	master passed
+1 💚	spotbugs	1m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 22s	the patch passed
+1 💚	compile	2m 25s	the patch passed
+1 💚	javac	2m 25s	the patch passed
+1 💚	checkstyle	0m 35s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 15s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 35s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		32m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4202
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 9cf8e7718462 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1d38db9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-19T09:25:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 6s	master passed
+1 💚	compile	0m 33s	master passed
+1 💚	shadedjars	3m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 4s	the patch passed
+1 💚	compile	0m 34s	the patch passed
+1 💚	javac	0m 34s	the patch passed
+1 💚	shadedjars	3m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	169m 7s	hbase-server in the patch passed.
		185m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4202
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8b57ea8f6523 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1d38db9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/3/testReport/
Max. process+thread count	3288 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-19T09:28:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 40s	master passed
+1 💚	compile	0m 45s	master passed
+1 💚	shadedjars	4m 4s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	0m 44s	the patch passed
+1 💚	javac	0m 44s	the patch passed
+1 💚	shadedjars	3m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	170m 7s	hbase-server in the patch passed.
		187m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4202
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 27af23268b99 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1d38db9`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/3/testReport/
Max. process+thread count	2866 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4202/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-03-20T14:13:43Z

Any other concerns? @wchevreuil @joshelser

joshelser · 2022-03-20T20:05:45Z

The start code of the 'new' RS may be less than the 'old' RS, as here, 'new' and 'old' just mean we reassigned a region from the 'old' to 'new', does not mean the 'new' RS is started after the 'old' RS.

Oh that's tricky. I didn't even think about that case. 👍🏼

joshelser

LGTM

Signed-off-by: Josh Elser <elserj@apache.org> Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit e56ed40)

Signed-off-by: Josh Elser <elserj@apache.org> Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit e56ed40) Change-Id: If8773e1fd5147fb339a084bfd6b6a34dbd6f4950

Apache9 requested review from joshelser and wchevreuil March 10, 2022 16:21

Apache9 self-assigned this Mar 10, 2022

joshelser reviewed Mar 12, 2022
View reviewed changes

wchevreuil reviewed Mar 17, 2022
View reviewed changes

Apache9 force-pushed the HBASE-26791 branch from 17aaa26 to ec2ea83Compare March 19, 2022 03:05

HBASE-26791 Memstore flush fencing issue for SFT
686caa8

Apache9 force-pushed the HBASE-26791 branch from ec2ea83 to 686caa8Compare March 19, 2022 03:08

fix whitespace
a0125fa

joshelser approved these changes Mar 20, 2022
View reviewed changes

wchevreuil approved these changes Mar 21, 2022
View reviewed changes

Apache9 merged commit e56ed40 into apache:masterMar 21, 2022

Apache9 added a commit that referenced this pull request Mar 22, 2022
HBASE-26791Memstore flush fencing issue for SFT (#4202)
68f3fbe
Signed-off-by: Josh Elser <elserj@apache.org> Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit e56ed40)

Uh oh!

Conversation

Apache9 commented Mar 10, 2022

Uh oh!

Apache-HBase commented Mar 10, 2022

Uh oh!

Apache-HBase commented Mar 11, 2022

Uh oh!

joshelser left a comment

Choose a reason for hiding this comment

Uh oh!

joshelserMar 12, 2022

Choose a reason for hiding this comment

Uh oh!

joshelser commented Mar 12, 2022

Uh oh!

joshelser commented Mar 12, 2022

Uh oh!

Apache9 commented Mar 13, 2022

Uh oh!

Apache9 commented Mar 13, 2022

Uh oh!

wchevreuil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Mar 19, 2022

Uh oh!

Apache-HBase commented Mar 19, 2022

Uh oh!

Apache-HBase commented Mar 19, 2022

Uh oh!

Apache-HBase commented Mar 19, 2022

Uh oh!

Apache-HBase commented Mar 19, 2022

Uh oh!

Apache-HBase commented Mar 19, 2022

Uh oh!

Apache9 commented Mar 20, 2022

Uh oh!

joshelser commented Mar 20, 2022

Uh oh!

joshelser left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants