Hbase 26275, update error message when executing deleteall with ROWPREFIXFILTER in meta table by xicm · Pull Request #4205 · apache/hbase

xicm · 2022-03-11T07:51:23Z

I'm not sure if it's reasonable and safe for allowing ROWPREFIXFILTER in deleteAll;
If not, we should raise a clear error message.

merge apache/hbase

… table hbase:meta

Apache-HBase · 2022-03-11T08:14:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 58s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 43s	the patch passed
-0 ⚠️	rubocop	0m 19s	The patch generated 11 new + 362 unchanged - 0 fixed = 373 total (was 362)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		9m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4205
Optional Tests	dupname asflicense javac rubocop
uname	Linux d67966175fcf 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `71ff3ec`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	39 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/1/console
versions	git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-11T08:21:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 9s	master passed
+1 💚	javadoc	0m 10s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 25s	the patch passed
+1 💚	javadoc	0m 7s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 55s	hbase-shell in the patch passed.
		16m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4205
Optional Tests	javac javadoc unit
uname	Linux e28d657226c4 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `71ff3ec`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/1/testReport/
Max. process+thread count	807 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-11T08:25:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 30s	master passed
+1 💚	javadoc	0m 19s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 59s	the patch passed
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	10m 2s	hbase-shell in the patch passed.
		20m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4205
Optional Tests	javac javadoc unit
uname	Linux d5309127a885 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `71ff3ec`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/1/testReport/
Max. process+thread count	830 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

sunhelly · 2022-03-16T03:18:20Z

 # delete operation doesn't need read permission. Retaining the read check for
 # meta table as a part of HBASE-5837.
- if is_meta_table?
+ if is_meta_table? and !(row.is_a?(Hash) and row.key?('ROWPREFIXFILTER'))


It's dangerous to delete rows in meta table by 'ROWPREFIXFILTER', right? If the rowPrefix matches some rows unexpected, the meta data will be deleted unexpected. I think maybe this is why the origin design seperated meta table here.

Yes, I have this concen too. Let me fix the error message?

Of course, you can try to make the descriptions more clearly.

Apache-HBase · 2022-03-16T06:55:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --quick-hadoopcheck --exclude-tests-url --asf-nightlies-general-check-base --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 2s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 13s	the patch passed
-0 ⚠️	rubocop	0m 6s	The patch generated 9 new + 362 unchanged - 0 fixed = 371 total (was 362)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		5m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4205
Optional Tests	dupname asflicense javac rubocop
uname	Linux 21d2db88b8b5 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c4ec523`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	41 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/2/console
versions	git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

sunhelly · 2022-03-16T06:56:31Z

Hi, @xicm , you can make a proper title for the issue, thanks.

Apache-HBase · 2022-03-16T06:57:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 18s	master passed
+1 💚	javadoc	0m 9s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 14s	the patch passed
+1 💚	javadoc	0m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 3s	hbase-shell in the patch passed.
		7m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4205
Optional Tests	javac javadoc unit
uname	Linux 6b8debac1f87 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c4ec523`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/2/testReport/
Max. process+thread count	334 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-16T07:02:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 53s	master passed
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 26s	the patch passed
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 34s	hbase-shell in the patch passed.
		11m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4205
Optional Tests	javac javadoc unit
uname	Linux ba7f2755148a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c4ec523`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/2/testReport/
Max. process+thread count	357 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4205/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…FIXFILTER in meta table (#4205) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>

…FIXFILTER in meta table (apache#4205) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org> (cherry picked from commit 8d161e4) Change-Id: I11d1ab3da521cb11b99813ab752a4a7a6be6bc0d

xicmand others added 6 commits November 16, 2021 16:05

Merge pull request#1from apache/master
f6c46cf
merge apache/hbase

Merge branch 'apache:master' into master
13e75fa

Merge branch 'apache:master' into master
b22f86f

Merge branch 'apache:master' into master
e497ed1

Merge branch 'apache:master' into master
f3485e5

HBASE-26275, ROWPREFIXFILTER doesn't work when execute deleteall with…
e0c3fca
… table hbase:meta

sunhelly reviewed Mar 16, 2022
View reviewed changes

HBASE-26275, update error message of deleteall
9479ab6

sunhelly approved these changes Mar 16, 2022
View reviewed changes

xicm changed the title ~~Hbase 26275, ROWPREFIXFILTER doesn't work when execute deleteall with table hbase:meta~~Hbase 26275, update error message when executing deleteall with ROWPREFIXFILTER in meta tableMar 16, 2022

sunhelly merged commit b9c5943 into apache:masterMar 16, 2022

asfgit pushed a commit that referenced this pull request Mar 16, 2022
Hbase 26275 update error message when executing deleteall with ROWPRE…
8d161e4
…FIXFILTER in meta table (#4205) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>

asfgit pushed a commit that referenced this pull request Mar 16, 2022
Hbase 26275 update error message when executing deleteall with ROWPRE…
4ff63f6
…FIXFILTER in meta table (#4205) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>

asfgit pushed a commit that referenced this pull request Mar 16, 2022
Hbase 26275 update error message when executing deleteall with ROWPRE…
50757ef
…FIXFILTER in meta table (#4205) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>

Navigation Menu

Uh oh!

Hbase 26275, update error message when executing deleteall with ROWPREFIXFILTER in meta table - #4205

Hbase 26275, update error message when executing deleteall with ROWPREFIXFILTER in meta table#4205
sunhelly merged 7 commits into
apache:masterfrom
xicm:HBASE-26275

xicm commented Mar 11, 2022

Uh oh!

Apache-HBase commented Mar 11, 2022

Uh oh!

Apache-HBase commented Mar 11, 2022

Uh oh!

Apache-HBase commented Mar 11, 2022

Uh oh!

sunhellyMar 16, 2022

Uh oh!

xicmMar 16, 2022

Uh oh!

sunhellyMar 16, 2022

Uh oh!

Apache-HBase commented Mar 16, 2022

Uh oh!

sunhelly commented Mar 16, 2022

Uh oh!

Apache-HBase commented Mar 16, 2022

Uh oh!

Apache-HBase commented Mar 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

xicm commented Mar 11, 2022

Uh oh!

Apache-HBase commented Mar 11, 2022

Uh oh!

Apache-HBase commented Mar 11, 2022

Uh oh!

Apache-HBase commented Mar 11, 2022

Uh oh!

sunhellyMar 16, 2022

Choose a reason for hiding this comment

Uh oh!

xicmMar 16, 2022

Choose a reason for hiding this comment

Uh oh!

sunhellyMar 16, 2022

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Mar 16, 2022

Uh oh!

sunhelly commented Mar 16, 2022

Uh oh!

Apache-HBase commented Mar 16, 2022

Uh oh!

Apache-HBase commented Mar 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants