Uh oh!
There was an error while loading. Please reload this page.
HBASE-22758 Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta - #424
Merged
Merged
Conversation
openinx
requested review from
Apache9, apurtell and saintstack
and removed request for
apurtellJuly 28, 2019 06:06
Apache-HBase
commented
Jul 28, 2019
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
Jul 28, 2019
Apache9
left a comment
Contributor
There was a problem hiding this comment.
And I think the intention here is that, after the deletion, typically there should be no remaining rows, so the scan will return immediately?
| * @throws IOException | ||
| */ | ||
| public static void deleteRegion(Connection connection, RegionInfo regionInfo) throws IOException { | ||
| public static void deleteRegionInfo(Connection connection, RegionInfo regionInfo) |
MemberAuthor
There was a problem hiding this comment.
Because the method only delete the info column family (will keep other cf), so name it deleteRegionInfo will be better.
| * @param regionsInfo list of regions to be deleted from META | ||
| */ | ||
| public static void deleteRegions(Connection connection, List<RegionInfo> regionsInfo) | ||
| public static void deleteRegionsInfo(Connection connection, List<RegionInfo> regionsInfo) |
Contributor
There was a problem hiding this comment.
And this should be deleteRegionInfos?
Apache-HBase
commented
Jul 29, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 29, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 29, 2019
💔 -1 overall
This message was automatically generated. |
saintstack
approved these changes
Jul 29, 2019
saintstack
left a comment
Contributor
There was a problem hiding this comment.
Seems good to me (after fixing tests...)
Apache-HBase
commented
Jul 30, 2019
💔 -1 overall
This message was automatically generated. |
openinx
commented
Jul 30, 2019
MemberAuthor
OK, the new introduced TestCatalogJanitorCluster is depending on the deleteRegions now, it will broke the compiling. Let me update the patch. |
…cedure#deleteFromMeta
Apache-HBase
commented
Jul 30, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 30, 2019
🎊 +1 overall
This message was automatically generated. |
infraio pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…cedure#deleteFromMeta (apache#424)
symat pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…cedure#deleteFromMeta (apache#424) (cherry picked from commit 09751f6) Change-Id: I2a9eb0f89c018d66e70dd5d3904c848b53cb6e3f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.