Uh oh!
There was an error while loading. Please reload this page.
HBASE-22737 Add a new admin method and shell cmd to trigger the hbck … - #425
Conversation
Apache9
commented
Jul 29, 2019
Should this be in Admin? Or in Hbck? |
Apache-HBase
commented
Jul 29, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 29, 2019
💔 -1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| throws ServiceException { | ||
| rpcPreCheck("runHbckChore"); | ||
| HbckChore hbckChore = master.getHbckChore(); | ||
| if (!hbckChore.isRunning()) { |
There was a problem hiding this comment.
If already running, should result of this call be 'false' for did not run?//
There was a problem hiding this comment.
Ok. Return false if the HBCK chore already running.
| #---------------------------------------------------------------------------------------------- | ||
| # Request HBCK chore to run | ||
| def hbck_chore_run | ||
| @admin.runHbckChore |
There was a problem hiding this comment.
Yeah, good question by @duo regards whether it should be in hbcksevice or not. It probably should?
| def help | ||
| <<-EOF | ||
| Request HBCK chore to run at master side. | ||
There was a problem hiding this comment.
Perhaps say what the chore does? One sentence?
There was a problem hiding this comment.
Missing 'm' on Filesystem. Fix on commit.
Apache-HBase
commented
Jul 29, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 30, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 30, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 30, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 30, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 30, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 30, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 30, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 31, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 31, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 31, 2019
💔 -1 overall
This message was automatically generated. |
saintstack
left a comment
There was a problem hiding this comment.
Minor item to fix on commit.
| def help | ||
| <<-EOF | ||
| Request HBCK chore to run at master side. | ||
There was a problem hiding this comment.
Missing 'm' on Filesystem. Fix on commit.
Apache-HBase
commented
Jul 31, 2019
💔 -1 overall
This message was automatically generated. |
…chore to run (#425) Signed-off-by: stack <stack@apache.org>
Apache-HBase
commented
Aug 1, 2019
💔 -1 overall
This message was automatically generated. |
…chore to run (#425) Signed-off-by: stack <stack@apache.org>
…chore to run (#425) Signed-off-by: stack <stack@apache.org>
…chore to run (#425) Signed-off-by: stack <stack@apache.org>
…chore to run (apache#425) Signed-off-by: stack <stack@apache.org>
…chore to run (apache#425) Signed-off-by: stack <stack@apache.org> (cherry picked from commit 5ec1fed) Change-Id: I1d4fa998b1f167bf292b819fc42f935cd2fc3ca0
…chore to run