Uh oh!
There was an error while loading. Please reload this page.
HBASE-26982 Add index and bloom filter statistics of LruBlockCache on… - #4376
Conversation
liangxs
commented
Apr 27, 2022
Apache-HBase
commented
Apr 27, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 27, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 27, 2022
🎊 +1 overall
This message was automatically generated. |
apurtell
left a comment
There was a problem hiding this comment.
lgtm and this looks like it is still mergable
| <%if lru %> | ||
| <tr> | ||
| <td>Size of Index Blocks</td> | ||
| <td><% String.format("%,d", ((LruBlockCache)bc).getCurrentIndexSize()) %></td> |
There was a problem hiding this comment.
I think the only improvement that needs be done here is these should also be formatted with TraditionalBinaryPrefix.long2String().
Apache-HBase
commented
Jul 14, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 14, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 14, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 27, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 27, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 27, 2022
💔 -1 overall
This message was automatically generated. |
comnetwork
commented
Jul 27, 2022
@liangxs ,would you please fix the spotless error? |
huaxiangsun
commented
Aug 12, 2022
Since it is approved, let me fix the spotless error and merge. |
huaxiangsun
commented
Aug 12, 2022
Oh, I do not have access to your git repo. @liangxs, can you fix spotless error? Otherwise, it will be moved out of 2.5.0 and goes to 2.5.1, thanks. |
Apache-HBase
commented
Aug 15, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 15, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 15, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 15, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 15, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 15, 2022
🎊 +1 overall
This message was automatically generated. |
saintstack
left a comment
There was a problem hiding this comment.
Nice patch. Intend to merge later....
#4376) Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: stack <stack@apache.org>
#4376) Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: stack <stack@apache.org>

… rs web UI
HBASE JIRA HBASE-26982