Skip to content

HBASE-22153 Fix the flaky TestRestartCluster - #123

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22153
Apr 8, 2019
Merged

HBASE-22153 Fix the flaky TestRestartCluster#123
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22153

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

Remove the the non-null assertion, use a waitFor to wait until it is not null instead.
Increase the waiting time to make the test more stable.

@Apache9Apache9 self-assigned this Apr 8, 2019
@Apache9
Apache9 requested a review from tianjy1990April 8, 2019 02:29
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec236Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall268master passed
+1compile57master passed
+1checkstyle68master passed
+1shadedjars269branch has no errors when building our shaded downstream artifacts.
+1findbugs147master passed
+1javadoc32master passed
_ Patch Compile Tests _
+1mvninstall235the patch passed
+1compile50the patch passed
+1javac50the patch passed
+1checkstyle67the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars257patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck532Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs155the patch passed
+1javadoc33the patch passed
_ Other Tests _
-1unit15274hbase-server in the patch failed.
+1asflicense32The patch does not generate ASF License warnings.
17787
ReasonTests
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.master.procedure.TestSCPWithReplicas
hadoop.hbase.client.TestAdmin1
hadoop.hbase.TestSplitMerge
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.client.TestFromClientSideWithCoprocessor
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-123/1/artifact/out/Dockerfile
GITHUB PR#123
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux f0eeb73cb1b5 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / b2587c8
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-123/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-123/1/testReport/
Max. process+thread count5177 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-123/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit a871d31 into apache:masterApr 8, 2019
@Apache9

Copy link
Copy Markdown
ContributorAuthor

Thanks @infraio . Merged it to master first. Let's wait for a while to see if it works, and then cherry-pick to other branches.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@infraio