Uh oh!
There was an error while loading. Please reload this page.
HBASE-22776 Rename config names in user scan snapshot feature - #440
Conversation
Apache-HBase
commented
Aug 2, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 2, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 4, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 6, 2019
💔 -1 overall
This message was automatically generated. |
| boolean isTableUserScanSnapshotEnabled(TableDescriptor tableDescriptor) { | ||
| public static boolean isAclSyncToHdfsEnabled(Configuration conf) { | ||
| String masterCoprocessors = conf.get(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY); |
There was a problem hiding this comment.
Use conf.getStrings to parse the masterCoprocessors ? and then use the HashSet to check the existence of SnapshotScannerHDFSAclController & AccessController ... that would be better...
| public void postCompletedTruncateTableAction(ObserverContext<MasterCoprocessorEnvironment> c, | ||
| TableName tableName) throws IOException { | ||
| if (needHandleTableHdfsAcl(tableName, "truncateTable " + tableName)) { | ||
| hdfsAclHelper.createTableDirectories(tableName); |
There was a problem hiding this comment.
Why create the table directories here ? I guess the TruncateTableProcedure will create the dir ?
There was a problem hiding this comment.
The tmp table dir is deleted after truncate table, so recreate this directory.
There was a problem hiding this comment.
So please add the comment to say : it's mainly used for creating tmp table dir here because ...
| public static final String USER_SCAN_SNAPSHOT_ENABLE = "hbase.user.scan.snapshot.enable"; | ||
| public static final String USER_SCAN_SNAPSHOT_THREAD_NUMBER = | ||
| "hbase.user.scan.snapshot.thread.number"; | ||
| public static final String ACL_SYNC_TO_HDFS_ENABLE = "hbase.acl.sync.to.hdfs.enable"; |
There was a problem hiding this comment.
better to name it as 'hbase.table.acl.sync.to.hdfs.enable' ?
There was a problem hiding this comment.
The steps to config this feature is as followings:
- Check HDFS configuration
- Add master coprocessor:
hbase.coprocessor.master.classes =
“org.apache.hadoop.hbase.security.access.AccessController
,org.apache.hadoop.hbase.security.access.SnapshotScannerHDFSAclController” - Enable this feature:
hbase.acl.sync.to.hdfs.enable=true - Modify table scheme to enable this feature:
alter 't1', CONFIGURATION => {'hbase.acl.sync.to.hdfs.enable' => 'true'}
So this config has two usages in both step 3 and 4.
If step3 is set, the acl will aync to HDFS if grant namespace or global.
Maybe 'hbase.table.acl.sync.to.hdfs.enable' is confused because global and namespace acls are also synced?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
Aug 6, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 6, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 6, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 6, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 6, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 6, 2019
💔 -1 overall
This message was automatically generated. |
openinx
left a comment
There was a problem hiding this comment.
LGTM overall, please address the minor issues when commting. Thanks.
| public void postCompletedTruncateTableAction(ObserverContext<MasterCoprocessorEnvironment> c, | ||
| TableName tableName) throws IOException { | ||
| if (needHandleTableHdfsAcl(tableName, "truncateTable " + tableName)) { | ||
| hdfsAclHelper.createTableDirectories(tableName); |
There was a problem hiding this comment.
So please add the comment to say : it's mainly used for creating tmp table dir here because ...
| public static final String USER_SCAN_SNAPSHOT_ENABLE = "hbase.user.scan.snapshot.enable"; | ||
| public static final String USER_SCAN_SNAPSHOT_THREAD_NUMBER = | ||
| "hbase.user.scan.snapshot.thread.number"; | ||
| public static final String ACL_SYNC_TO_HDFS_ENABLE = "hbase.acl.sync.to.hdfs.enable"; |
Apache-HBase
commented
Aug 7, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 7, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 7, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 7, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2019
💔 -1 overall
This message was automatically generated. |
No description provided.