HBASE-27028 Add a shell command for flushing master local region by 2005hithlj · Pull Request #4457 · apache/hbase

2005hithlj · 2022-05-21T15:42:51Z

https://issues.apache.org/jira/browse/HBASE-27028

Apache-HBase · 2022-05-21T16:30:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 24s	master passed
+1 💚	compile	3m 38s	master passed
+1 💚	checkstyle	1m 7s	master passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 26s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 13s	the patch passed
+1 💚	compile	3m 39s	the patch passed
-0 ⚠️	javac	0m 31s	hbase-common generated 1 new + 150 unchanged - 1 fixed = 151 total (was 151)
+1 💚	checkstyle	1m 6s	the patch passed
+1 💚	rubocop	0m 3s	There were no new rubocop issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 49s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 42s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 36s	The patch does not generate ASF License warnings.
		40m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile rubocop
uname	Linux 05683c051ce2 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1aa07d5`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
Max. process+thread count	69 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-21T19:39:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 47s	master passed
+1 💚	compile	1m 39s	master passed
+1 💚	shadedjars	3m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 12s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	1m 40s	the patch passed
+1 💚	javac	1m 40s	the patch passed
+1 💚	shadedjars	3m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 45s	hbase-common in the patch passed.
+1 💚	unit	1m 18s	hbase-client in the patch passed.
+1 💚	unit	196m 59s	hbase-server in the patch passed.
+1 💚	unit	7m 9s	hbase-shell in the patch passed.
		229m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f905f09eb585 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1aa07d5`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/1/testReport/
Max. process+thread count	2574 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-21T20:23:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 56s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 58s	master passed
+1 💚	compile	1m 38s	master passed
+1 💚	shadedjars	4m 20s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	1m 31s	the patch passed
+1 💚	javac	1m 31s	the patch passed
+1 💚	shadedjars	4m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 2s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 33s	hbase-common in the patch passed.
+1 💚	unit	1m 13s	hbase-client in the patch passed.
-1 ❌	unit	237m 35s	hbase-server in the patch failed.
+1 💚	unit	8m 14s	hbase-shell in the patch passed.
		273m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0f1201877bf3 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1aa07d5`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/1/testReport/
Max. process+thread count	2340 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-22T03:03:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	3m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	4m 12s	master passed
+1 💚	checkstyle	1m 11s	master passed
+1 💚	spotless	0m 46s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 52s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	4m 13s	the patch passed
-0 ⚠️	javac	0m 36s	hbase-common generated 1 new + 150 unchanged - 1 fixed = 151 total (was 151)
+1 💚	checkstyle	1m 8s	the patch passed
+1 💚	rubocop	0m 2s	There were no new rubocop issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 16s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 45s	patch has no errors when running spotless:check.
+1 💚	spotbugs	3m 7s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		48m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile rubocop
uname	Linux 61d451a46a3e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cec35b6`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-22T06:05:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	1m 6s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 21s	master passed
+1 💚	compile	1m 15s	master passed
+1 💚	shadedjars	3m 55s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 9s	the patch passed
+1 💚	compile	1m 20s	the patch passed
+1 💚	javac	1m 20s	the patch passed
+1 💚	shadedjars	3m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 23s	hbase-common in the patch passed.
+1 💚	unit	1m 7s	hbase-client in the patch passed.
+1 💚	unit	196m 11s	hbase-server in the patch passed.
+1 💚	unit	7m 46s	hbase-shell in the patch passed.
		230m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 03b52147379c 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cec35b6`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/2/testReport/
Max. process+thread count	2710 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-22T06:08:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	3m 38s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 40s	master passed
+1 💚	compile	1m 39s	master passed
+1 💚	shadedjars	3m 44s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	1m 38s	the patch passed
+1 💚	javac	1m 38s	the patch passed
+1 💚	shadedjars	3m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 46s	hbase-common in the patch passed.
+1 💚	unit	1m 16s	hbase-client in the patch passed.
+1 💚	unit	197m 40s	hbase-server in the patch passed.
+1 💚	unit	7m 7s	hbase-shell in the patch passed.
		233m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fbbaf8459494 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cec35b6`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/2/testReport/
Max. process+thread count	2469 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

I prefer we add an extra rpc method and a shell command to do this, like flush_master_store, or something else.

We do not expose the name of master local region to upper layer, it is OK for a user to have a table with the same name.

2005hithlj · 2022-05-22T09:00:38Z

I prefer we add an extra rpc method and a shell command to do this, like flush_master_store, or something else.
We do not expose the name of master local region to upper layer, it is OK for a user to have a table with the same name.

Thanks for the review @Apache9. You are right, it may conflict with the user's 'master: store' table.
Let me modify the implementation.

Apache-HBase · 2022-05-24T03:17:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 13s	master passed
+1 💚	compile	4m 42s	master passed
+1 💚	checkstyle	1m 25s	master passed
-1 ❌	spotless	0m 36s	branch has 22 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	6m 7s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 46s	the patch passed
+1 💚	compile	5m 54s	the patch passed
+1 💚	cc	5m 54s	the patch passed
+1 💚	javac	5m 54s	the patch passed
+1 💚	checkstyle	1m 36s	the patch passed
-0 ⚠️	rubocop	0m 7s	The patch generated 7 new + 425 unchanged - 1 fixed = 432 total (was 426)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 11s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	hbaseprotoc	2m 3s	the patch passed
-1 ❌	spotless	0m 36s	patch has 22 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	5m 52s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 45s	The patch does not generate ASF License warnings.
		57m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux c5926117925e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bc21967`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/artifact/yetus-general-check/output/branch-spotless.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-24T06:16:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 7s	master passed
+1 💚	compile	1m 46s	master passed
+1 💚	shadedjars	3m 57s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 13s	the patch passed
+1 💚	compile	1m 48s	the patch passed
+1 💚	javac	1m 48s	the patch passed
+1 💚	shadedjars	3m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 25s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 8s	hbase-client in the patch passed.
+1 💚	unit	198m 37s	hbase-server in the patch passed.
+1 💚	unit	6m 44s	hbase-thrift in the patch passed.
+1 💚	unit	7m 42s	hbase-shell in the patch passed.
		236m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 734122f64bd6 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bc21967`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/testReport/
Max. process+thread count	2730 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-24T06:22:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 30s	master passed
+1 💚	compile	2m 25s	master passed
+1 💚	shadedjars	3m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	2m 25s	the patch passed
+1 💚	javac	2m 25s	the patch passed
+1 💚	shadedjars	3m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 39s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 17s	hbase-client in the patch passed.
+1 💚	unit	200m 25s	hbase-server in the patch passed.
+1 💚	unit	8m 37s	hbase-thrift in the patch passed.
+1 💚	unit	7m 7s	hbase-shell in the patch passed.
		242m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bd6e069f329a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bc21967`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/testReport/
Max. process+thread count	2578 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-24T07:18:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 45s	master passed
+1 💚	compile	5m 28s	master passed
+1 💚	checkstyle	1m 31s	master passed
-1 ❌	spotless	0m 41s	branch has 22 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	6m 39s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 40s	the patch passed
+1 💚	compile	4m 43s	the patch passed
+1 💚	cc	4m 43s	the patch passed
+1 💚	javac	4m 43s	the patch passed
+1 💚	checkstyle	1m 25s	the patch passed
-0 ⚠️	rubocop	0m 8s	The patch generated 7 new + 425 unchanged - 1 fixed = 432 total (was 426)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 37s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	hbaseprotoc	1m 55s	the patch passed
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 54s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 47s	The patch does not generate ASF License warnings.
		54m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 57ef16c24015 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bc21967`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/4/artifact/yetus-general-check/output/branch-spotless.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-05-24T07:31:44Z

The failures are caused by #4442

Apache-HBase · 2022-05-24T10:24:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 6s	master passed
+1 💚	compile	1m 48s	master passed
+1 💚	shadedjars	4m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 17s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 7s	the patch passed
+1 💚	compile	1m 46s	the patch passed
+1 💚	javac	1m 46s	the patch passed
+1 💚	shadedjars	3m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 25s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 9s	hbase-client in the patch passed.
+1 💚	unit	202m 26s	hbase-server in the patch passed.
+1 💚	unit	6m 42s	hbase-thrift in the patch passed.
+1 💚	unit	7m 46s	hbase-shell in the patch passed.
		240m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f20db0835477 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bc21967`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/4/testReport/
Max. process+thread count	2773 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-24T10:27:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 34s	master passed
+1 💚	compile	2m 26s	master passed
+1 💚	shadedjars	3m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	2m 26s	the patch passed
+1 💚	javac	2m 26s	the patch passed
+1 💚	shadedjars	3m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 39s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 17s	hbase-client in the patch passed.
+1 💚	unit	201m 29s	hbase-server in the patch passed.
+1 💚	unit	8m 41s	hbase-thrift in the patch passed.
+1 💚	unit	7m 1s	hbase-shell in the patch passed.
		243m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6b595e081fb5 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bc21967`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/4/testReport/
Max. process+thread count	2444 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

2005hithlj · 2022-05-24T10:28:27Z

The failures are caused by #4442

This problem has been solved in my latest commit,
Do I still need to wait for another PR to solve this problem?
@Apache9

2005hithlj · 2022-05-24T10:30:21Z

@carp84 Could you take a look? Thanks.

Apache-HBase · 2022-05-27T17:17:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 9s	master passed
+1 💚	compile	4m 39s	master passed
+1 💚	checkstyle	1m 25s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 21s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 10s	the patch passed
+1 💚	compile	4m 39s	the patch passed
+1 💚	cc	4m 39s	the patch passed
+1 💚	javac	4m 39s	the patch passed
+1 💚	checkstyle	1m 21s	the patch passed
-0 ⚠️	rubocop	0m 6s	The patch generated 7 new + 425 unchanged - 1 fixed = 432 total (was 426)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 26s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	hbaseprotoc	1m 56s	the patch passed
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 54s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 45s	The patch does not generate ASF License warnings.
		51m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux e63113f0efe7 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fdf054d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-27T20:25:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 33s	master passed
+1 💚	compile	2m 21s	master passed
+1 💚	shadedjars	3m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	2m 25s	the patch passed
+1 💚	javac	2m 25s	the patch passed
+1 💚	shadedjars	3m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 39s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 16s	hbase-client in the patch passed.
-1 ❌	unit	198m 22s	hbase-server in the patch failed.
+1 💚	unit	8m 38s	hbase-thrift in the patch passed.
+1 💚	unit	7m 0s	hbase-shell in the patch passed.
		240m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4cec8c6db1f5 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fdf054d`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/5/testReport/
Max. process+thread count	2457 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-27T21:00:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 54s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 40s	master passed
+1 💚	compile	2m 15s	master passed
+1 💚	shadedjars	4m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 22s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 25s	the patch passed
+1 💚	compile	2m 3s	the patch passed
+1 💚	javac	2m 3s	the patch passed
+1 💚	shadedjars	4m 20s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 29s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 12s	hbase-client in the patch passed.
-1 ❌	unit	233m 15s	hbase-server in the patch failed.
+1 💚	unit	6m 44s	hbase-thrift in the patch passed.
+1 💚	unit	7m 38s	hbase-shell in the patch passed.
		274m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a8d4a993fa2a 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fdf054d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/5/testReport/
Max. process+thread count	2280 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

So the implementation is just to request a flush, not complete the flush, but the method name is called flush and we returns a CompletableFuture, which seems to tell users that joining on the future then you can wait for the flush to complete...

Better have a more clear design and naming of the method name and behavior.

Apache9 · 2022-05-28T02:03:57Z

 return region.getScanner(scan);
 }

+ public void rpcRequestFlush() {


Just call it requestFlush?

2005hithlj · 2022-05-30T06:21:23Z

Thanks @Apache9 for the review. I will revise it according to your suggestion.

Apache9

Why only requestFlush, not flush? We do not have a requestFlush method in the Admin interface in the past?

Apache9 · 2022-05-31T04:35:13Z

+ /**
+ * Force request flush master local region
+ */
+ void forceRequestFlushMasterStore() throws IOException;


I mean add a force flag... Not add a force to the method name...
Checked the code, we do not have this flag in the Admin interface, and at rs side, it will always use true when calling region.flush...
So sorry, let's keep align with other methods in this interface, just call it flushMasterStore, and at master side, we call region.flush(true).

Thanks @Apache9 for the review.
If we call region.flush(true) at the master side, the changesAfterLastFlush value of MasterRegionFlusherAndCompactor will become incorrect, which may trigger an invalid flush operation.
But we can call MasterRegionFlusherAndCompactor.requestFlush() to avoid this.
Do we need to consider this situation?

Then we could introduce a method in MasterRegionFlusherAndCompactor? Just reset changesAfterLastFlush after calling flush?
Anyway, what I mean is we should try our best to align the behavior in our Admin interface.

Yes, we need to introduce a new method to reset the value of changesAfterLastFlush after calling flush.
Let me modify the code here. Thanks @Apache9 .

I checked the code, because region.flush() is a synchronous method, we should call resetChangesAfterLastFlush() before calling region.flush() method, which should be similar to MasterRegionFlusherAndCompactor.flushLoop() method code logic. @Apache9

Apache-HBase · 2022-05-31T05:12:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 11s	master passed
+1 💚	compile	4m 39s	master passed
+1 💚	checkstyle	1m 24s	master passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 17s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 7s	the patch passed
+1 💚	compile	4m 40s	the patch passed
+1 💚	cc	4m 40s	the patch passed
+1 💚	javac	4m 40s	the patch passed
+1 💚	checkstyle	1m 25s	the patch passed
-0 ⚠️	rubocop	0m 7s	The patch generated 7 new + 425 unchanged - 1 fixed = 432 total (was 426)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 29s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	hbaseprotoc	1m 56s	the patch passed
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 51s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 45s	The patch does not generate ASF License warnings.
		51m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux a2e4df00fb9e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c116d2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/6/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-31T08:17:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 47s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 37s	master passed
+1 💚	compile	1m 45s	master passed
+1 💚	shadedjars	3m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 17s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 12s	the patch passed
+1 💚	compile	1m 46s	the patch passed
+1 💚	javac	1m 46s	the patch passed
+1 💚	shadedjars	3m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 25s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 8s	hbase-client in the patch passed.
+1 💚	unit	196m 43s	hbase-server in the patch passed.
+1 💚	unit	6m 47s	hbase-thrift in the patch passed.
+1 💚	unit	7m 45s	hbase-shell in the patch passed.
		236m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1ea2ac37f52f 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c116d2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/6/testReport/
Max. process+thread count	3061 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-31T08:19:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 32s	master passed
+1 💚	compile	2m 24s	master passed
+1 💚	shadedjars	3m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 37s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	2m 25s	the patch passed
+1 💚	javac	2m 25s	the patch passed
+1 💚	shadedjars	3m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 38s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 17s	hbase-client in the patch passed.
+1 💚	unit	197m 44s	hbase-server in the patch passed.
+1 💚	unit	8m 39s	hbase-thrift in the patch passed.
+1 💚	unit	7m 2s	hbase-shell in the patch passed.
		239m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6bdd1ad4ea1b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c116d2`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/6/testReport/
Max. process+thread count	2819 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-01T20:02:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 1s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 30s	master passed
+1 💚	compile	2m 25s	master passed
+1 💚	shadedjars	3m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	2m 25s	the patch passed
+1 💚	javac	2m 25s	the patch passed
+1 💚	shadedjars	3m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 39s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 16s	hbase-client in the patch passed.
+1 💚	unit	198m 0s	hbase-server in the patch passed.
+1 💚	unit	8m 37s	hbase-thrift in the patch passed.
+1 💚	unit	7m 5s	hbase-shell in the patch passed.
		239m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a7f6e632b1ea 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `99e4e3e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/9/testReport/
Max. process+thread count	2493 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/9/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-01T20:54:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 16s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 12s	master passed
+1 💚	compile	4m 44s	master passed
+1 💚	checkstyle	1m 27s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 25s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 10s	the patch passed
+1 💚	compile	4m 42s	the patch passed
+1 💚	cc	4m 42s	the patch passed
+1 💚	javac	4m 42s	the patch passed
+1 💚	checkstyle	1m 24s	the patch passed
-0 ⚠️	rubocop	0m 6s	The patch generated 7 new + 425 unchanged - 1 fixed = 432 total (was 426)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 29s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	hbaseprotoc	1m 56s	the patch passed
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 52s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 44s	The patch does not generate ASF License warnings.
		50m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/10/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 33194157020e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `99e4e3e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/10/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	65 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/10/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-02T00:01:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 36s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 22s	master passed
+1 💚	compile	1m 52s	master passed
+1 💚	shadedjars	4m 30s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 30s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 45s	the patch passed
+1 💚	compile	2m 23s	the patch passed
+1 💚	javac	2m 23s	the patch passed
+1 💚	shadedjars	4m 2s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 25s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 7s	hbase-client in the patch passed.
+1 💚	unit	196m 47s	hbase-server in the patch passed.
+1 💚	unit	6m 40s	hbase-thrift in the patch passed.
+1 💚	unit	7m 44s	hbase-shell in the patch passed.
		236m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/10/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cd7a20ca596e 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `99e4e3e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/10/testReport/
Max. process+thread count	3421 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/10/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-02T00:06:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 30s	master passed
+1 💚	compile	2m 25s	master passed
+1 💚	shadedjars	3m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 34s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	2m 26s	the patch passed
+1 💚	javac	2m 26s	the patch passed
+1 💚	shadedjars	3m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 39s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 17s	hbase-client in the patch passed.
-1 ❌	unit	201m 1s	hbase-server in the patch failed.
+1 💚	unit	8m 35s	hbase-thrift in the patch passed.
+1 💚	unit	7m 2s	hbase-shell in the patch passed.
		242m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 022aba87152a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `99e4e3e`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/10/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/10/testReport/
Max. process+thread count	2821 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/10/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-04T16:06:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 16s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 12s	master passed
+1 💚	compile	4m 38s	master passed
+1 💚	checkstyle	1m 24s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 24s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 9s	the patch passed
+1 💚	compile	4m 40s	the patch passed
+1 💚	cc	4m 40s	the patch passed
+1 💚	javac	4m 40s	the patch passed
+1 💚	checkstyle	1m 25s	the patch passed
-0 ⚠️	rubocop	0m 7s	The patch generated 7 new + 425 unchanged - 1 fixed = 432 total (was 426)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 34s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	hbaseprotoc	1m 56s	the patch passed
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 56s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 45s	The patch does not generate ASF License warnings.
		50m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/11/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 174db5e8d43d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d57159f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/11/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/11/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-04T19:18:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 33s	master passed
+1 💚	compile	2m 25s	master passed
+1 💚	shadedjars	3m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	2m 22s	the patch passed
+1 💚	javac	2m 22s	the patch passed
+1 💚	shadedjars	3m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 40s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 16s	hbase-client in the patch passed.
+1 💚	unit	200m 51s	hbase-server in the patch passed.
+1 💚	unit	8m 39s	hbase-thrift in the patch passed.
+1 💚	unit	7m 3s	hbase-shell in the patch passed.
		242m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/11/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 10238dd2a143 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d57159f`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/11/testReport/
Max. process+thread count	2940 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/11/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

2005hithlj · 2022-06-05T10:24:09Z

I have a new commit, could you take a look ?
@Apache9 sir.

Apache9 · 2022-06-07T01:19:10Z

 private static final boolean DEFAULT_WARMUP_BEFORE_MOVE = true;

+ // Only for testing
+ private boolean isLocalRegionFlushed = false;


Is it possible to not adding a flag which is only used to verify test result? I think you can add a CP method for the flushMasterRegion call, and use attach a CP to verify that whether the master is called.

Does CP here mean coprocessor? Is there a similar implementation example? sir @Apache9

Apache9 · 2022-06-07T01:22:49Z


 public FlushResult flush(boolean force) throws IOException {
- return region.flush(force);
+ flusherAndCompactor.resetChangesAfterLastFlush();


We do not need to record the lastFlushTime here?

Apache-HBase · 2022-06-07T17:32:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 18s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 48s	master passed
+1 💚	compile	5m 35s	master passed
+1 💚	checkstyle	1m 32s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 26s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
-1 ❌	mvninstall	1m 41s	root in the patch failed.
+1 💚	compile	4m 35s	the patch passed
+1 💚	cc	4m 35s	the patch passed
+1 💚	javac	4m 35s	the patch passed
-0 ⚠️	checkstyle	0m 29s	hbase-server: The patch generated 1 new + 7 unchanged - 0 fixed = 8 total (was 7)
-0 ⚠️	rubocop	0m 8s	The patch generated 7 new + 425 unchanged - 1 fixed = 432 total (was 426)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	hadoopcheck	1m 54s	The patch causes 40 errors with Hadoop v3.1.2.
-1 ❌	hadoopcheck	3m 54s	The patch causes 40 errors with Hadoop v3.2.2.
-1 ❌	hadoopcheck	5m 49s	The patch causes 40 errors with Hadoop v3.3.1.
-1 ❌	hbaseprotoc	0m 39s	hbase-protocol-shaded in the patch failed.
-1 ❌	hbaseprotoc	0m 14s	hbase-client in the patch failed.
-1 ❌	hbaseprotoc	0m 24s	hbase-server in the patch failed.
-1 ❌	hbaseprotoc	0m 17s	hbase-thrift in the patch failed.
-1 ❌	hbaseprotoc	0m 16s	hbase-shell in the patch failed.
-1 ❌	spotless	0m 34s	patch has 40 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	5m 48s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 38s	The patch does not generate ASF License warnings.
		42m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 256516436cde 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `176c43c`
Default Java	AdoptOpenJDK-1.8.0_282-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-general-check/output/patch-mvninstall-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-general-check/output/diff-patch-rubocop.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-general-check/output/patch-javac-3.2.2.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-general-check/output/patch-javac-3.3.1.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-protocol-shaded.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-client.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-thrift.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-shell.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	68 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-07T21:01:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	5m 51s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 3s	master passed
+1 💚	compile	2m 27s	master passed
+1 💚	shadedjars	4m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 1s	the patch passed
+1 💚	compile	2m 24s	the patch passed
+1 💚	javac	2m 24s	the patch passed
+1 💚	shadedjars	4m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 34s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 38s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 17s	hbase-client in the patch passed.
+1 💚	unit	201m 42s	hbase-server in the patch passed.
+1 💚	unit	8m 37s	hbase-thrift in the patch passed.
+1 💚	unit	7m 5s	hbase-shell in the patch passed.
		250m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2f4d13c951c1 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `176c43c`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/testReport/
Max. process+thread count	2596 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/12/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

2005hithlj · 2022-06-08T02:23:10Z

@Apache9 I have a new commit, could you take a look? Thanks.

Apache-HBase · 2022-06-08T04:13:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 33s	master passed
+1 💚	compile	7m 27s	master passed
+1 💚	checkstyle	1m 56s	master passed
+1 💚	spotless	1m 1s	branch has no errors when running spotless:check.
+1 💚	spotbugs	8m 11s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 9s	the patch passed
+1 💚	compile	7m 45s	the patch passed
+1 💚	cc	7m 45s	the patch passed
+1 💚	javac	7m 45s	the patch passed
+1 💚	checkstyle	2m 0s	the patch passed
-0 ⚠️	rubocop	0m 11s	The patch generated 7 new + 425 unchanged - 1 fixed = 432 total (was 426)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	20m 29s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
-1 ❌	hbaseprotoc	1m 0s	hbase-protocol-shaded in the patch failed.
-1 ❌	hbaseprotoc	0m 18s	hbase-client in the patch failed.
-1 ❌	hbaseprotoc	0m 31s	hbase-server in the patch failed.
-1 ❌	hbaseprotoc	0m 23s	hbase-thrift in the patch failed.
-1 ❌	hbaseprotoc	0m 18s	hbase-shell in the patch failed.
+1 💚	spotless	1m 3s	patch has no errors when running spotless:check.
+1 💚	spotbugs	9m 59s	the patch passed
		_ Other Tests _
+1 💚	asflicense	1m 2s	The patch does not generate ASF License warnings.
		81m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/13/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 25e70bf29f02 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9342653`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/13/artifact/yetus-general-check/output/diff-patch-rubocop.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/13/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-protocol-shaded.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/13/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-client.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/13/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/13/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-thrift.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/13/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-shell.txt
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/13/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Overall LGTM. Just a naming problem. Will merge after you fix it.

Thanks @2005hithlj for the patient.

Apache9 · 2022-06-09T15:46:15Z

+ changesAfterLastFlush.set(0);
+ }
+
+ void resetLastFlushTime() {


Should name it recordLastFlushTime?

Thanks @Apache9 for the review.
I have modified it in the latest commit.

Apache-HBase · 2022-06-10T11:10:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 52s	master passed
+1 💚	compile	4m 50s	master passed
+1 💚	checkstyle	1m 18s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 49s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	4m 39s	the patch passed
+1 💚	cc	4m 39s	the patch passed
+1 💚	javac	4m 39s	the patch passed
+1 💚	checkstyle	1m 25s	the patch passed
-0 ⚠️	rubocop	0m 6s	The patch generated 7 new + 425 unchanged - 1 fixed = 432 total (was 426)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 19s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
-1 ❌	hbaseprotoc	0m 39s	hbase-protocol-shaded in the patch failed.
-1 ❌	hbaseprotoc	0m 16s	hbase-client in the patch failed.
-1 ❌	hbaseprotoc	0m 25s	hbase-server in the patch failed.
-1 ❌	hbaseprotoc	0m 20s	hbase-thrift in the patch failed.
-1 ❌	hbaseprotoc	0m 17s	hbase-shell in the patch failed.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 48s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 45s	The patch does not generate ASF License warnings.
		54m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/14/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 8059310aac17 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c24ba54`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/14/artifact/yetus-general-check/output/diff-patch-rubocop.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/14/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-protocol-shaded.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/14/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-client.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/14/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/14/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-thrift.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/14/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-shell.txt
Max. process+thread count	69 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/14/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-11T13:04:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 42s	master passed
+1 💚	compile	4m 43s	master passed
+1 💚	checkstyle	1m 23s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 29s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	4m 41s	the patch passed
+1 💚	cc	4m 41s	the patch passed
+1 💚	javac	4m 41s	the patch passed
+1 💚	checkstyle	1m 26s	the patch passed
-0 ⚠️	rubocop	0m 7s	The patch generated 7 new + 425 unchanged - 1 fixed = 432 total (was 426)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 15s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
-1 ❌	hbaseprotoc	0m 40s	hbase-protocol-shaded in the patch failed.
-1 ❌	hbaseprotoc	0m 16s	hbase-client in the patch failed.
-1 ❌	hbaseprotoc	0m 25s	hbase-server in the patch failed.
-1 ❌	hbaseprotoc	0m 19s	hbase-thrift in the patch failed.
-1 ❌	hbaseprotoc	0m 16s	hbase-shell in the patch failed.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 56s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 45s	The patch does not generate ASF License warnings.
		53m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 43e7fbbbec39 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b7065c1`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/artifact/yetus-general-check/output/diff-patch-rubocop.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-protocol-shaded.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-client.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-thrift.txt
hbaseprotoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-shell.txt
Max. process+thread count	69 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-06-11T13:10:38Z

Checked the output, I think the problem is that, we run protoc test in the sub module directory so the session.executionRootDirectory is pointed to the sub module then we can not find license-header file.

Let me file an issue about this.

Apache-HBase · 2022-06-11T17:38:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 22s	master passed
+1 💚	compile	3m 5s	master passed
+1 💚	shadedjars	4m 55s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 48s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 10s	the patch passed
+1 💚	compile	3m 0s	the patch passed
+1 💚	javac	3m 0s	the patch passed
+1 💚	shadedjars	4m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 6s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 3s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	2m 12s	hbase-client in the patch passed.
-1 ❌	unit	274m 48s	hbase-server in the patch failed.
+1 💚	unit	9m 15s	hbase-thrift in the patch passed.
+1 💚	unit	7m 24s	hbase-shell in the patch passed.
		327m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 36567274709e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b7065c1`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/testReport/
Max. process+thread count	2498 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-11T17:51:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 51s	master passed
+1 💚	compile	2m 29s	master passed
+1 💚	shadedjars	5m 0s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 26s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 42s	the patch passed
+1 💚	compile	2m 34s	the patch passed
+1 💚	javac	2m 34s	the patch passed
+1 💚	shadedjars	5m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 28s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 31s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 20s	hbase-client in the patch passed.
-1 ❌	unit	293m 26s	hbase-server in the patch failed.
+1 💚	unit	8m 46s	hbase-thrift in the patch passed.
+1 💚	unit	7m 2s	hbase-shell in the patch passed.
		341m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 163840ecc0b7 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b7065c1`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/testReport/
Max. process+thread count	2515 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/15/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-12T08:19:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 12s	master passed
+1 💚	compile	4m 45s	master passed
+1 💚	checkstyle	1m 24s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 25s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 12s	the patch passed
+1 💚	compile	4m 45s	the patch passed
+1 💚	cc	4m 45s	the patch passed
+1 💚	javac	4m 45s	the patch passed
+1 💚	checkstyle	1m 24s	the patch passed
-0 ⚠️	rubocop	0m 7s	The patch generated 7 new + 425 unchanged - 1 fixed = 432 total (was 426)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 31s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	hbaseprotoc	1m 54s	the patch passed
+1 💚	spotless	0m 42s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 51s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 46s	The patch does not generate ASF License warnings.
		50m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/16/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 799d717ff03a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3e98869`
Default Java	AdoptOpenJDK-1.8.0_282-b08
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/16/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/16/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-12T11:30:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 36s	master passed
+1 💚	compile	2m 26s	master passed
+1 💚	shadedjars	3m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	2m 26s	the patch passed
+1 💚	javac	2m 26s	the patch passed
+1 💚	shadedjars	3m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 39s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 16s	hbase-client in the patch passed.
+1 💚	unit	199m 50s	hbase-server in the patch passed.
+1 💚	unit	8m 36s	hbase-thrift in the patch passed.
+1 💚	unit	7m 2s	hbase-shell in the patch passed.
		241m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/16/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 645a383ed980 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3e98869`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/16/testReport/
Max. process+thread count	2426 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/16/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-12T11:33:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 22s	master passed
+1 💚	compile	1m 49s	master passed
+1 💚	shadedjars	3m 57s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 12s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	compile	1m 45s	the patch passed
+1 💚	javac	1m 45s	the patch passed
+1 💚	shadedjars	3m 57s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 25s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 8s	hbase-client in the patch passed.
-1 ❌	unit	206m 26s	hbase-server in the patch failed.
+1 💚	unit	6m 43s	hbase-thrift in the patch passed.
+1 💚	unit	7m 44s	hbase-shell in the patch passed.
		244m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/16/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4457
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9f5e8775fb0c 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3e98869`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/16/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/16/testReport/
Max. process+thread count	2798 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/16/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

2005hithlj · 2022-06-13T02:54:53Z

In my local environment, the UT TestReplicationDroppedTables can be executed successfully.
Can you help me with this? @Apache9 Thanks.

…che#4457) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…ion (apache#4457)" This reverts commit 958ecc3.

Apache9 requested changes May 22, 2022
View reviewed changes

2005hithlj force-pushed the HBASE-27028 branch 2 times, most recently from 5292647 to 21f9cc4Compare May 24, 2022 02:10

2005hithlj force-pushed the HBASE-27028 branch from 21f9cc4 to ec200e7Compare May 24, 2022 04:08

2005hithlj force-pushed the HBASE-27028 branch from ec200e7 to 0c02e5fCompare May 27, 2022 16:21

Apache9 reviewed May 28, 2022
View reviewed changes

Apache9 reviewed May 31, 2022
View reviewed changes

HBASE-27028 Add a shell command for flushing master local region
eda23a5

2005hithlj force-pushed the HBASE-27028 branch from 05b97d9 to eda23a5Compare June 4, 2022 15:01

Apache9 reviewed Jun 7, 2022
View reviewed changes

2005hithlj added 2 commits June 8, 2022 00:46

HBASE-27028 Add a shell command for flushing master local region
8718a5e

HBASE-27028 Add a shell command for flushing master local region
638621d

Apache9 approved these changes Jun 9, 2022
View reviewed changes

HBASE-27028 Add a shell command for flushing master local region
83b4092

Apache9 merged commit 002c92c into apache:masterJun 13, 2022

wenwj0 pushed a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022
HBASE-27028 Add a shell command for flushing master local region (apa…
958ecc3
…che#4457) Signed-off-by: Duo Zhang <zhangduo@apache.org>

wenwj0 added a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022
Revert "HBASE-27028 Add a shell command for flushing master local reg…
050b287
…ion (apache#4457)" This reverts commit 958ecc3.

Uh oh!

Conversation

2005hithlj commented May 21, 2022

Uh oh!

Apache-HBase commented May 21, 2022

Uh oh!

Apache-HBase commented May 21, 2022

Uh oh!

Apache-HBase commented May 21, 2022

Uh oh!

Apache-HBase commented May 22, 2022

Uh oh!

Apache-HBase commented May 22, 2022

Uh oh!

Apache-HBase commented May 22, 2022

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

2005hithlj commented May 22, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented May 24, 2022

Uh oh!

Apache-HBase commented May 24, 2022

Uh oh!

Apache-HBase commented May 24, 2022

Uh oh!

Apache-HBase commented May 24, 2022

Uh oh!

Apache9 commented May 24, 2022

Uh oh!

Apache-HBase commented May 24, 2022

Uh oh!

Apache-HBase commented May 24, 2022

Uh oh!

2005hithlj commented May 24, 2022

Uh oh!

2005hithlj commented May 24, 2022

Uh oh!

Apache-HBase commented May 27, 2022

Uh oh!

Apache-HBase commented May 27, 2022

Uh oh!

Apache-HBase commented May 27, 2022

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

2005hithlj commented May 30, 2022

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

2005hithljMay 31, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented May 31, 2022

Uh oh!

Apache-HBase commented May 31, 2022

Uh oh!

Apache-HBase commented May 31, 2022

Uh oh!

Apache-HBase commented Jun 1, 2022

Uh oh!

Apache-HBase commented Jun 1, 2022

Uh oh!

Apache-HBase commented Jun 2, 2022

2005hithlj commented May 22, 2022•
edited
Loading

2005hithljMay 31, 2022•
edited
Loading