Skip to content

HBASE-26366 Provide meaningful parent spans to ZK interactions - #4459

Merged
ndimiduk merged 2 commits into
apache:masterfrom
ndimiduk:26366-meaningful-parents-zk-spans
Jun 10, 2022
Merged

HBASE-26366 Provide meaningful parent spans to ZK interactions#4459
ndimiduk merged 2 commits into
apache:masterfrom
ndimiduk:26366-meaningful-parents-zk-spans

Conversation

@ndimiduk

@ndimidukndimiduk commented May 23, 2022

Copy link
Copy Markdown
Member

As of this patch, now every span that's emitted in my unit test has a meaningful parent span, tied back to either a server activity or the ZKWatcher handler pool. PTAL.

@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
apurtell
apurtell approved these changes May 26, 2022
View reviewed changes
Comment thread...ver/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerInternalsTracing.java
@@ -0,0 +1,313 @@
/*

@apurtellapurtellMay 26, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed the rest of the changes. Spent more time here. LGTM

@ndimiduk
ndimidukforce-pushed the 26366-meaningful-parents-zk-spans branch from 249a944 to c17b447CompareMay 31, 2022 13:55
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
Apache9
Apache9 reviewed Jun 2, 2022
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think the approach is fine, my only concern is about passing the span to another thread, as the span may end before its sub spans? I'm not sure if this is a big problem...

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/MetaRegionLocationCache.java Outdated
@ndimiduk

ndimiduk commented Jun 2, 2022

Copy link
Copy Markdown
MemberAuthor

FYI I'm working through the branch-2 back-port and it's finding some other places I missed in this patch for master. Will be back.

@ndimiduk
ndimidukforce-pushed the 26366-meaningful-parents-zk-spans branch from c17b447 to a8a8c9dCompareJune 3, 2022 14:47
@ndimiduk

ndimiduk commented Jun 3, 2022

Copy link
Copy Markdown
MemberAuthor
  • rebased
  • decouple spawned thread spans from parent thread spans, just in case
  • ensure all manually-managed spans have a status set
  • rename/move test to better match its scope

@ndimidukndimiduk mentioned this pull request Jun 3, 2022
Merged
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk
ndimidukforce-pushed the 26366-meaningful-parents-zk-spans branch from a8a8c9d to 3c2f637CompareJune 6, 2022 09:14
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk

ndimiduk commented Jun 9, 2022

Copy link
Copy Markdown
MemberAuthor

I tracked down the broken test to 313a37f.

@ndimiduk
HBASE-26366 Provide meaningful parent spans to ZK interactions
51eef0d
Signed-off-by: Andrew Purtell <apurtell@apache.org>
@ndimiduk
PR feedback, also...
b933fca
- decouple spawned thread spans from parent thread spans, just in case
- ensure all manually-managed spans have a status set
- rename/move test to better match its scope
@ndimiduk
ndimidukforce-pushed the 26366-meaningful-parents-zk-spans branch from 3c2f637 to b933fcaCompareJune 9, 2022 12:35
@Apache-HBase

Apache-HBase commented Jun 9, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 53sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 10smaster passed
+1 💚compile5m 39smaster passed
+1 💚checkstyle1m 24smaster passed
+1 💚spotless1m 1sbranch has no errors when running spotless:check.
+1 💚spotbugs3m 59smaster passed
-0 ⚠️patch0m 51sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 41sthe patch passed
+1 💚compile4m 30sthe patch passed
+1 💚javac4m 30sthe patch passed
-0 ⚠️checkstyle0m 30shbase-server: The patch generated 1 new + 13 unchanged - 1 fixed = 14 total (was 14)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck16m 15sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
+1 💚spotbugs3m 9sthe patch passed
_ Other Tests _
+1 💚asflicense0m 37sThe patch does not generate ASF License warnings.
54m 49s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4459
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux f75666d32a19 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 414cfb3
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count73 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/5/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 9, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 15sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 24smaster passed
+1 💚compile1m 38smaster passed
+1 💚shadedjars4m 15sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 15smaster passed
-0 ⚠️patch6m 4sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 7sthe patch passed
+1 💚compile1m 37sthe patch passed
+1 💚javac1m 37sthe patch passed
+1 💚shadedjars4m 12spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 13sthe patch passed
_ Other Tests _
+1 💚unit2m 3shbase-common in the patch passed.
+1 💚unit1m 14shbase-client in the patch passed.
+1 💚unit0m 38shbase-zookeeper in the patch passed.
+1 💚unit201m 54shbase-server in the patch passed.
230m 5s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4459
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5239da22b171 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 414cfb3
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/5/testReport/
Max. process+thread count2487 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 9, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 27sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall3m 17smaster passed
+1 💚compile1m 38smaster passed
+1 💚shadedjars5m 15sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 17smaster passed
-0 ⚠️patch7m 3sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 3sthe patch passed
+1 💚compile1m 37sthe patch passed
+1 💚javac1m 37sthe patch passed
+1 💚shadedjars4m 57spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 9sthe patch passed
_ Other Tests _
+1 💚unit1m 39shbase-common in the patch passed.
+1 💚unit1m 16shbase-client in the patch passed.
+1 💚unit0m 39shbase-zookeeper in the patch passed.
+1 💚unit235m 53shbase-server in the patch passed.
265m 34s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4459
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7b6103d087f2 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 414cfb3
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/5/testReport/
Max. process+thread count2407 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit ed7e15d into apache:masterJun 10, 2022
@ndimiduk
ndimiduk deleted the 26366-meaningful-parents-zk-spans branch June 10, 2022 14:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 left review comments
@apurtellapurtellapurtell approved these changes
@joshelserjoshelserAwaiting requested review from joshelser
@taklwutaklwuAwaiting requested review from taklwu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ndimiduk@Apache-HBase@apurtell@Apache9