Skip to content

Backport "HBASE-26366 Provide meaningful parent spans to ZK interactions" to branch-2 - #4487

Merged
ndimiduk merged 3 commits into
apache:branch-2from
ndimiduk:26366-meaningful-parents-zk-spans-branch-2
Jun 10, 2022
Merged

Backport "HBASE-26366 Provide meaningful parent spans to ZK interactions" to branch-2#4487
ndimiduk merged 3 commits into
apache:branch-2from
ndimiduk:26366-meaningful-parents-zk-spans-branch-2

Conversation

@ndimiduk

@ndimidukndimiduk commented Jun 3, 2022

Copy link
Copy Markdown
Member

A backport of #4459 to branch-2.

@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Jun 3, 2022
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk
ndimidukforce-pushed the 26366-meaningful-parents-zk-spans-branch-2 branch from 81d5468 to e76f01dCompareJune 6, 2022 09:11
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk
HBASE-26366 Provide meaningful parent spans to ZK interactions
3b03d88
Signed-off-by: Andrew Purtell <apurtell@apache.org>
@ndimiduk
additional changes for branch-2
dbbfdf9
@ndimiduk
PR feedback, also...
050427b
- decouple spawned thread spans from parent thread spans, just in case
- ensure all manually-managed spans have a status set
- rename/move test to better match its scope
@ndimiduk
ndimidukforce-pushed the 26366-meaningful-parents-zk-spans-branch-2 branch from e76f01d to 050427bCompareJune 9, 2022 13:04
@Apache-HBase

Apache-HBase commented Jun 9, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 31sbranch-2 passed
+1 💚compile4m 28sbranch-2 passed
+1 💚checkstyle1m 25sbranch-2 passed
+1 💚spotless0m 49sbranch has no errors when running spotless:check.
+1 💚spotbugs3m 13sbranch-2 passed
-0 ⚠️patch0m 44sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall3m 28sthe patch passed
+1 💚compile4m 17sthe patch passed
-0 ⚠️javac2m 34shbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
-0 ⚠️checkstyle0m 34shbase-server: The patch generated 1 new + 14 unchanged - 1 fixed = 15 total (was 15)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck10m 44sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotless0m 46spatch has no errors when running spotless:check.
+1 💚spotbugs3m 47sthe patch passed
_ Other Tests _
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
46m 20s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4487
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux e68b9595254d 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b3c9ef3
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count69 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 9, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 59sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 44sMaven dependency ordering for branch
+1 💚mvninstall3m 20sbranch-2 passed
+1 💚compile1m 33sbranch-2 passed
+1 💚shadedjars5m 3sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 9sbranch-2 passed
-0 ⚠️patch6m 38sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 5sthe patch passed
+1 💚compile1m 29sthe patch passed
+1 💚javac1m 29sthe patch passed
+1 💚shadedjars4m 50spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 8sthe patch passed
_ Other Tests _
+1 💚unit1m 35shbase-common in the patch passed.
+1 💚unit2m 54shbase-client in the patch passed.
+1 💚unit0m 37shbase-zookeeper in the patch passed.
+1 💚unit206m 44shbase-server in the patch passed.
237m 56s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4487
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9b17373570b5 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b3c9ef3
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/testReport/
Max. process+thread count2314 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 9, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 23sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 12sbranch-2 passed
+1 💚compile1m 43sbranch-2 passed
+1 💚shadedjars4m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 17sbranch-2 passed
-0 ⚠️patch6m 13sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall3m 9sthe patch passed
+1 💚compile1m 43sthe patch passed
+1 💚javac1m 43sthe patch passed
+1 💚shadedjars4m 22spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 15sthe patch passed
_ Other Tests _
+1 💚unit1m 59shbase-common in the patch passed.
+1 💚unit2m 44shbase-client in the patch passed.
+1 💚unit0m 42shbase-zookeeper in the patch passed.
+1 💚unit229m 48shbase-server in the patch passed.
261m 20s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4487
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 72d6ffce8f64 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b3c9ef3
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/testReport/
Max. process+thread count2434 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4487/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit 9b8bb58 into apache:branch-2Jun 10, 2022
@ndimiduk
ndimiduk deleted the 26366-meaningful-parents-zk-spans-branch-2 branch June 10, 2022 14:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndimiduk@Apache-HBase