Skip to content

Backport "HBASE-27095 HbckChore should produce a report" to branch-2.5 - #4510

Merged
ndimiduk merged 2 commits into
apache:branch-2.5from
ndimiduk:27095-hbckchore-report-branch-2.5
Jun 10, 2022
Merged

Backport "HBASE-27095 HbckChore should produce a report" to branch-2.5#4510
ndimiduk merged 2 commits into
apache:branch-2.5from
ndimiduk:27095-hbckchore-report-branch-2.5

Conversation

@ndimiduk

@ndimidukndimiduk commented Jun 9, 2022

Copy link
Copy Markdown
Member

No description provided.

@ndimiduk
Rename master.janitor.Report -> CatalogJanitorReport
db03c17
Done because we want to make HbckChore also generate a report object, and the results of both
chores are consumed in a shared context (hbck.jsp). Give the classes different names so that they
can be used in the same scope.
Done as a separate commit to make things easier to review.
@ndimiduk
HBASE-27095 HbckChore should produce a report
7bd0484
In apache#4470 for HBASE-26192, it was noted that the HbckChore is kind of a pain to use and test
because it maintains a bunch of local state. By contract, the CatalogJanitorChore makes a nice
self-contained report. Let's update HbckChore to do the same.
Signed-off-by: Andrew Purtell <apurtell@apache.org>
@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Jun 9, 2022
@ndimiduk

ndimiduk commented Jun 9, 2022

Copy link
Copy Markdown
MemberAuthor

Backport of #4498

@Apache-HBase

Apache-HBase commented Jun 9, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 45sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+1 💚mvninstall4m 14sbranch-2.5 passed
+1 💚compile3m 18sbranch-2.5 passed
+1 💚checkstyle0m 43sbranch-2.5 passed
+1 💚spotless0m 52sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 38sbranch-2.5 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 52sthe patch passed
+1 💚compile3m 6sthe patch passed
+1 💚javac3m 6sthe patch passed
+1 💚checkstyle0m 47sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck19m 17sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚spotless0m 55spatch has no errors when running spotless:check.
+1 💚spotbugs2m 2sthe patch passed
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
49m 58s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4510/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4510
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 0e90c4a3d824 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 7ead4b1
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count70 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4510/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 9, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 💚mvninstall2m 53sbranch-2.5 passed
+1 💚compile0m 39sbranch-2.5 passed
+1 💚shadedjars4m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sbranch-2.5 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 35sthe patch passed
+1 💚compile0m 39sthe patch passed
+1 💚javac0m 39sthe patch passed
+1 💚shadedjars4m 12spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
-1 ❌unit197m 28shbase-server in the patch failed.
216m 46s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4510/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4510
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4399c315e8f4 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 7ead4b1
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4510/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4510/1/testReport/
Max. process+thread count2207 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4510/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 9, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 24sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 💚mvninstall6m 45sbranch-2.5 passed
+1 💚compile0m 54sbranch-2.5 passed
+1 💚shadedjars5m 25sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 34sbranch-2.5 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 28sthe patch passed
+1 💚compile0m 47sthe patch passed
+1 💚javac0m 47sthe patch passed
-1 ❌shadedjars6m 14spatch has 1 errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39sthe patch passed
_ Other Tests _
+1 💚unit221m 39shbase-server in the patch passed.
250m 43s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4510/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4510
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5e7b3e95a777 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 7ead4b1
Default JavaAdoptOpenJDK-11.0.10+9
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4510/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4510/1/testReport/
Max. process+thread count2652 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4510/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit cc2af76 into apache:branch-2.5Jun 10, 2022
@ndimiduk
ndimiduk deleted the 27095-hbckchore-report-branch-2.5 branch June 10, 2022 13:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndimiduk@Apache-HBase