HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split by Reidddddd · Pull Request #460 · apache/hbase

Reidddddd · 2019-08-06T15:16:27Z

Apache-HBase · 2019-08-06T17:00:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1322	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1	mvninstall	153	branch-1 passed
+1	compile	49	branch-1 passed with JDK v1.8.0_222
+1	compile	52	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	111	branch-1 passed
+1	shadedjars	202	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	39	branch-1 passed with JDK v1.8.0_222
+1	javadoc	49	branch-1 passed with JDK v1.7.0_232
0	spotbugs	198	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	195	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	138	the patch passed
+1	compile	49	the patch passed with JDK v1.8.0_222
+1	javac	49	the patch passed
+1	compile	57	the patch passed with JDK v1.7.0_232
+1	javac	57	the patch passed
+1	checkstyle	119	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	226	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	301	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	38	the patch passed with JDK v1.8.0_222
+1	javadoc	50	the patch passed with JDK v1.7.0_232
+1	findbugs	222	the patch passed
		_ Other Tests _
-1	unit	2100	hbase-server in the patch failed.
+1	asflicense	16	The patch does not generate ASF License warnings.
		5738

Reason	Tests
Failed junit tests	hadoop.hbase.coprocessor.TestCoprocessorInterface

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/1/artifact/out/Dockerfile
GITHUB PR	#460
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 019f10357fb9 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-460/out/precommit/personality/provided.sh
git revision	branch-1 / `e26f695`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/1/testReport/
Max. process+thread count	729 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/1/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-06T18:33:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	69	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1	mvninstall	611	branch-1 passed
+1	compile	51	branch-1 passed with JDK v1.8.0_222
+1	compile	53	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	131	branch-1 passed
+1	shadedjars	249	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	48	branch-1 passed with JDK v1.8.0_222
+1	javadoc	54	branch-1 passed with JDK v1.7.0_232
0	spotbugs	244	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	240	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	161	the patch passed
+1	compile	53	the patch passed with JDK v1.8.0_222
+1	javac	53	the patch passed
+1	compile	59	the patch passed with JDK v1.7.0_232
+1	javac	59	the patch passed
+1	checkstyle	130	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	254	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	374	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	37	the patch passed with JDK v1.8.0_222
+1	javadoc	47	the patch passed with JDK v1.7.0_232
+1	findbugs	224	the patch passed
		_ Other Tests _
-1	unit	2177	hbase-server in the patch failed.
+1	asflicense	22	The patch does not generate ASF License warnings.
		5292

Reason	Tests
Failed junit tests	hadoop.hbase.coprocessor.TestCoprocessorInterface

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/2/artifact/out/Dockerfile
GITHUB PR	#460
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7f9d0ce68505 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-460/out/precommit/personality/provided.sh
git revision	branch-1 / `e7114f7`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/2/testReport/
Max. process+thread count	742 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/2/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Reidddddd · 2019-08-08T04:28:56Z

 // Create the daughter HRegion instance
- HRegion r = HRegion.newHRegion(this.fs.getTableDir(), this.getWAL(), fs.getFileSystem(),
- this.getBaseConf(), hri, this.getTableDesc(), rsServices);
+ HRegion r = HRegion.newHRegion(this.fs.getTableDir(), rsServices.getWAL(hri),


rsServices.getWAL(hri)
Based on WALProvider impl, it will create a new wal according to strategy or inherit parent's wal by default mode.

Reidddddd · 2019-08-08T05:10:19Z

2nd commit, improve some naming readability.
Original version is this kind of format (under RegionGroupingProvider): factoryID.providerID.***.
In fact, factoryID and providerID is the same thing which is hostname,port,startcode.
It repeats twice, that's why i remove them in second commit.

Apache-HBase · 2019-08-08T07:32:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1224	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1	mvninstall	543	branch-1 passed
+1	compile	35	branch-1 passed with JDK v1.8.0_222
+1	compile	41	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	89	branch-1 passed
+1	shadedjars	160	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	34	branch-1 passed with JDK v1.8.0_222
+1	javadoc	36	branch-1 passed with JDK v1.7.0_232
0	spotbugs	161	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	157	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	100	the patch passed
+1	compile	35	the patch passed with JDK v1.8.0_222
+1	javac	35	the patch passed
+1	compile	41	the patch passed with JDK v1.7.0_232
+1	javac	41	the patch passed
+1	checkstyle	83	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	154	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	277	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	29	the patch passed with JDK v1.8.0_222
+1	javadoc	37	the patch passed with JDK v1.7.0_232
+1	findbugs	162	the patch passed
		_ Other Tests _
-1	unit	1862	hbase-server in the patch failed.
+1	asflicense	22	The patch does not generate ASF License warnings.
		5305

Reason	Tests
Failed junit tests	hadoop.hbase.coprocessor.TestCoprocessorInterface

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/3/artifact/out/Dockerfile
GITHUB PR	#460
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 4e285093879c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-460/out/precommit/personality/provided.sh
git revision	branch-1 / `e7114f7`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/3/testReport/
Max. process+thread count	731 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/3/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Reidddddd · 2019-08-08T08:23:01Z

Related failure, working..

Reidddddd · 2019-08-08T11:35:04Z

mvn clean package -Dtest=TestCoprocessorInterface,TestSplitTransaction
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.coprocessor.TestCoprocessorInterface
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.982 s - in org.apache.hadoop.hbase.coprocessor.TestCoprocessorInterface
[INFO] Running org.apache.hadoop.hbase.regionserver.TestSplitTransaction
[INFO] Tests run: 36, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.527 s - in org.apache.hadoop.hbase.regionserver.TestSplitTransaction
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 38, Failures: 0, Errors: 0, Skipped: 0

3rd commit should fix the UT failure.

Reidddddd · 2019-08-08T11:36:51Z

 assertTrue(count > 0 && count != rowcount);
 daughtersRowCount += count;
 } finally {
-HRegion.closeHRegion((HRegion)openRegion);


HRegion.closeHRegion method will close WAL, then second daughter region will get exception. That's why i replace it with ((HRegion) openRegion).close()

Makes sense! 👍

Apache-HBase · 2019-08-08T17:32:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1580	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1	mvninstall	566	branch-1 passed
+1	compile	40	branch-1 passed with JDK v1.8.0_222
+1	compile	47	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	93	branch-1 passed
+1	shadedjars	187	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	branch-1 passed with JDK v1.8.0_222
+1	javadoc	38	branch-1 passed with JDK v1.7.0_232
0	spotbugs	179	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	176	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	130	the patch passed
+1	compile	41	the patch passed with JDK v1.8.0_222
+1	javac	41	the patch passed
+1	compile	46	the patch passed with JDK v1.7.0_232
+1	javac	46	the patch passed
+1	checkstyle	92	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	170	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	318	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	29	the patch passed with JDK v1.8.0_222
+1	javadoc	41	the patch passed with JDK v1.7.0_232
+1	findbugs	176	the patch passed
		_ Other Tests _
-1	unit	9611	hbase-server in the patch failed.
+1	asflicense	35	The patch does not generate ASF License warnings.
		13674

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAdmin1
	hadoop.hbase.master.TestMasterBalanceThrottling

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/4/artifact/out/Dockerfile
GITHUB PR	#460
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux a878a7d0c8bc 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-460/out/precommit/personality/provided.sh
git revision	branch-1 / `e7114f7`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/4/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/4/testReport/
Max. process+thread count	4137 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/4/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-10T00:23:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	45	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1	mvninstall	484	branch-1 passed
+1	compile	36	branch-1 passed with JDK v1.8.0_222
+1	compile	42	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	91	branch-1 passed
+1	shadedjars	161	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	34	branch-1 passed with JDK v1.8.0_222
+1	javadoc	36	branch-1 passed with JDK v1.7.0_232
0	spotbugs	163	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	161	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	100	the patch passed
+1	compile	38	the patch passed with JDK v1.8.0_222
+1	javac	38	the patch passed
+1	compile	40	the patch passed with JDK v1.7.0_232
+1	javac	40	the patch passed
+1	checkstyle	82	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	155	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	264	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	31	the patch passed with JDK v1.8.0_222
+1	javadoc	37	the patch passed with JDK v1.7.0_232
+1	findbugs	169	the patch passed
		_ Other Tests _
-1	unit	7010	hbase-server in the patch failed.
+1	asflicense	27	The patch does not generate ASF License warnings.
		9232

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestReplicasClient

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/5/artifact/out/Dockerfile
GITHUB PR	#460
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 71d3b929debf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-460/out/precommit/personality/provided.sh
git revision	branch-1 / `9888217`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/5/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/5/testReport/
Max. process+thread count	4415 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/5/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Reidddddd · 2019-08-10T07:14:48Z

Unrelated failure.

Apache-HBase · 2019-08-12T00:48:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1211	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1	mvninstall	510	branch-1 passed
+1	compile	52	branch-1 passed with JDK v1.8.0_222
+1	compile	54	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	120	branch-1 passed
+1	shadedjars	202	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	43	branch-1 passed with JDK v1.8.0_222
+1	javadoc	50	branch-1 passed with JDK v1.7.0_232
0	spotbugs	205	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	202	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	129	the patch passed
+1	compile	50	the patch passed with JDK v1.8.0_222
+1	javac	50	the patch passed
+1	compile	54	the patch passed with JDK v1.7.0_232
+1	javac	54	the patch passed
+1	checkstyle	102	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	193	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	331	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	36	the patch passed with JDK v1.8.0_222
+1	javadoc	48	the patch passed with JDK v1.7.0_232
+1	findbugs	212	the patch passed
		_ Other Tests _
+1	unit	9226	hbase-server in the patch passed.
+1	asflicense	33	The patch does not generate ASF License warnings.
		13087

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/6/artifact/out/Dockerfile
GITHUB PR	#460
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 1cab1d424e41 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-460/out/precommit/personality/provided.sh
git revision	branch-1 / `2d9d405`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/6/testReport/
Max. process+thread count	4059 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/6/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

petersomogyi · 2019-08-12T11:10:45Z

- HRegion r = HRegion.newHRegion(this.fs.getTableDir(), this.getWAL(), fs.getFileSystem(),
- this.getBaseConf(), hri, this.getTableDesc(), rsServices);
+ HRegion r = HRegion.newHRegion(this.fs.getTableDir(),
+ rsServices == null ? getWAL() :rsServices.getWAL(hri), // rsServices can be null in UT


Please extract this expression to a variable.

petersomogyi · 2019-08-12T11:16:11Z

 int regionGroupNumber = config.getInt(NUM_REGION_GROUPS, DEFAULT_NUM_REGION_GROUPS);
 groupNames = new String[regionGroupNumber];
 for (int i = 0; i < regionGroupNumber; i++) {
- groupNames[i] = providerId + GROUP_NAME_DELIMITER + "regiongroup-" + i;


GROUP_NAME_DELIMITER is unused from now on. Can it be removed? It is in IA.Private class.

petersomogyi · 2019-08-12T11:18:11Z

 assertTrue(count > 0 && count != rowcount);
 daughtersRowCount += count;
 } finally {
-HRegion.closeHRegion((HRegion)openRegion);


Makes sense! 👍

Apache-HBase · 2019-08-12T18:10:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1874	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1	mvninstall	489	branch-1 passed
+1	compile	36	branch-1 passed with JDK v1.8.0_222
+1	compile	42	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	90	branch-1 passed
+1	shadedjars	165	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	36	branch-1 passed with JDK v1.8.0_222
+1	javadoc	37	branch-1 passed with JDK v1.7.0_232
0	spotbugs	169	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	163	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	128	the patch passed
+1	compile	38	the patch passed with JDK v1.8.0_222
+1	javac	38	the patch passed
+1	compile	42	the patch passed with JDK v1.7.0_232
+1	javac	42	the patch passed
+1	checkstyle	87	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	164	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	281	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	27	the patch passed with JDK v1.8.0_222
+1	javadoc	38	the patch passed with JDK v1.7.0_232
+1	findbugs	163	the patch passed
		_ Other Tests _
-1	unit	9691	hbase-server in the patch failed.
+1	asflicense	46	The patch does not generate ASF License warnings.
		13845

Reason	Tests
Failed junit tests	hadoop.hbase.replication.TestReplicationKillSlaveRS
	hadoop.hbase.client.TestAdmin1

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/7/artifact/out/Dockerfile
GITHUB PR	#460
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 1e8dd67d78e4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-460/out/precommit/personality/provided.sh
git revision	branch-1 / `2d9d405`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/7/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/7/testReport/
Max. process+thread count	4311 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/7/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Reidddddd · 2019-08-13T02:58:01Z

2nd commit addressed comments only, failed tests are not related.

petersomogyi

Looks good!

Reidddddd · 2019-08-13T10:08:36Z

Thanks Peter for the review! @petersomogyi

Apache-HBase · 2019-08-13T10:45:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	70	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1	mvninstall	500	branch-1 passed
+1	compile	40	branch-1 passed with JDK v1.8.0_222
+1	compile	42	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	91	branch-1 passed
+1	shadedjars	208	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	51	branch-1 passed with JDK v1.8.0_222
+1	javadoc	74	branch-1 passed with JDK v1.7.0_232
0	spotbugs	201	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	196	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	117	the patch passed
+1	compile	38	the patch passed with JDK v1.8.0_222
+1	javac	38	the patch passed
+1	compile	42	the patch passed with JDK v1.7.0_232
+1	javac	42	the patch passed
+1	checkstyle	84	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	160	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	271	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	29	the patch passed with JDK v1.8.0_222
+1	javadoc	38	the patch passed with JDK v1.7.0_232
+1	findbugs	166	the patch passed
		_ Other Tests _
-1	unit	10503	hbase-server in the patch failed.
+1	asflicense	29	The patch does not generate ASF License warnings.
		12957

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAdmin2
	hadoop.hbase.client.TestAdmin1

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/8/artifact/out/Dockerfile
GITHUB PR	#460
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 837215e593a6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-460/out/precommit/personality/provided.sh
git revision	branch-1 / `96ff5f2`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/8/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/8/testReport/
Max. process+thread count	4678 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/8/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-14T03:16:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1194	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1	mvninstall	488	branch-1 passed
+1	compile	39	branch-1 passed with JDK v1.8.0_222
+1	compile	42	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	90	branch-1 passed
+1	shadedjars	170	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	39	branch-1 passed with JDK v1.8.0_222
+1	javadoc	38	branch-1 passed with JDK v1.7.0_232
0	spotbugs	167	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	164	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	108	the patch passed
+1	compile	41	the patch passed with JDK v1.8.0_222
+1	javac	41	the patch passed
+1	compile	46	the patch passed with JDK v1.7.0_232
+1	javac	46	the patch passed
+1	checkstyle	87	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	161	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	284	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	29	the patch passed with JDK v1.8.0_222
+1	javadoc	40	the patch passed with JDK v1.7.0_232
+1	findbugs	167	the patch passed
		_ Other Tests _
-1	unit	11306	hbase-server in the patch failed.
+1	asflicense	29	The patch does not generate ASF License warnings.
		14763

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAdmin2
	hadoop.hbase.replication.TestReplicationKillSlaveRS
	hadoop.hbase.client.TestAdmin1

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/9/artifact/out/Dockerfile
GITHUB PR	#460
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux ee08c856ff10 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-460/out/precommit/personality/provided.sh
git revision	branch-1 / `73a48b7`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/9/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/9/testReport/
Max. process+thread count	4804 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/9/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-14T03:16:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	53	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1	mvninstall	492	branch-1 passed
+1	compile	38	branch-1 passed with JDK v1.8.0_222
+1	compile	42	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	92	branch-1 passed
+1	shadedjars	169	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	36	branch-1 passed with JDK v1.8.0_222
+1	javadoc	39	branch-1 passed with JDK v1.7.0_232
0	spotbugs	171	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	168	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	105	the patch passed
+1	compile	40	the patch passed with JDK v1.8.0_222
+1	javac	40	the patch passed
+1	compile	44	the patch passed with JDK v1.7.0_232
+1	javac	44	the patch passed
+1	checkstyle	90	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	166	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	304	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	31	the patch passed with JDK v1.8.0_222
+1	javadoc	39	the patch passed with JDK v1.7.0_232
+1	findbugs	171	the patch passed
		_ Other Tests _
+1	unit	6847	hbase-server in the patch passed.
+1	asflicense	24	The patch does not generate ASF License warnings.
		9205

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/10/artifact/out/Dockerfile
GITHUB PR	#460
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 194476b74556 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-460/out/precommit/personality/provided.sh
git revision	branch-1 / `9821fd8`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/10/testReport/
Max. process+thread count	4396 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/10/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Reidddddd commented Aug 8, 2019
View reviewed changes

HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
7f07375

Reidddddd force-pushed the HBASE-22774 branch from e874aa3 to 7f07375Compare August 8, 2019 11:32

Reidddddd commented Aug 8, 2019
View reviewed changes

petersomogyi requested changes Aug 12, 2019
View reviewed changes

Address review comments
d9be1aa

petersomogyi approved these changes Aug 13, 2019
View reviewed changes

Reidddddd merged commit f887207 into apache:branch-1Aug 14, 2019

Reidddddd deleted the HBASE-22774 branch August 14, 2019 02:28

Uh oh!

Conversation

Reidddddd commented Aug 6, 2019

Uh oh!

Apache-HBase commented Aug 6, 2019

Uh oh!

Apache-HBase commented Aug 6, 2019

Uh oh!

ReiddddddAug 8, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reidddddd commented Aug 8, 2019

Uh oh!

Apache-HBase commented Aug 8, 2019

Uh oh!

Reidddddd commented Aug 8, 2019

Uh oh!

Reidddddd commented Aug 8, 2019

Uh oh!

ReiddddddAug 8, 2019

Choose a reason for hiding this comment

Uh oh!

petersomogyiAug 12, 2019

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Aug 8, 2019

Uh oh!

Apache-HBase commented Aug 10, 2019

Uh oh!

Reidddddd commented Aug 10, 2019

Uh oh!

Apache-HBase commented Aug 12, 2019

Uh oh!

petersomogyiAug 12, 2019

Choose a reason for hiding this comment

Uh oh!

petersomogyiAug 12, 2019

Choose a reason for hiding this comment

Uh oh!

petersomogyiAug 12, 2019

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Aug 12, 2019

Uh oh!

Reidddddd commented Aug 13, 2019

Uh oh!

petersomogyi left a comment

Choose a reason for hiding this comment

Uh oh!

Reidddddd commented Aug 13, 2019

Uh oh!

Apache-HBase commented Aug 13, 2019

Uh oh!

Apache-HBase commented Aug 14, 2019

Uh oh!

Apache-HBase commented Aug 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ReiddddddAug 8, 2019•
edited
Loading